Rename isNewUser to shouldHideForYouSection

Author: adamgrzybowski

src/pages/home/ForYouSection/index.tsx

@@ -19,6 +19,7 @@ import {accountIDSelector} from '@src/selectors/Session';
 import todosReportCountsSelector, {EMPTY_TODOS_SINGLE_REPORT_IDS, todosSingleReportIDsSelector} from '@src/selectors/Todos';
 import EmptyState from './EmptyState';
 import ForYouSkeleton from './ForYouSkeleton';
+import shouldHideForYouSection from './shouldHideForYouSection';
 import useReviewFlaggedExpenses from './useReviewFlaggedExpenses';
 
 function ForYouSection() {
@@ -33,6 +34,7 @@ function ForYouSection() {
     // Gating the skeleton on it prevents the section from flashing skeleton on every foreground/reconnect
     // when IS_LOADING_REPORT_DATA is optimistically set to true by ReconnectApp.
     const [hasLoadedApp = false] = useOnyx(ONYXKEYS.HAS_LOADED_APP);
+    const [firstDayFreeTrial] = useOnyx(ONYXKEYS.NVP_FIRST_DAY_FREE_TRIAL);
     const [reportCounts = CONST.EMPTY_TODOS_REPORT_COUNTS] = useOnyx(ONYXKEYS.DERIVED.TODOS, {selector: todosReportCountsSelector});
     const [singleReportIDs = EMPTY_TODOS_SINGLE_REPORT_IDS] = useOnyx(ONYXKEYS.DERIVED.TODOS, {selector: todosSingleReportIDsSelector});
     const {count: flaggedExpensesCount, reviewExpenses} = useReviewFlaggedExpenses();
@@ -162,8 +164,9 @@ function ForYouSection() {
         </View>
     );
 
+    const isInitialLoad = !hasLoadedApp && (isLoadingApp || isLoadingReportData || reportCounts === undefined);
+
     const renderContent = () => {
-        const isInitialLoad = !hasLoadedApp && (isLoadingApp || isLoadingReportData || reportCounts === undefined);
         if (isInitialLoad) {
             const reasonAttributes: SkeletonSpanReasonAttributes = {
                 context: 'ForYouSection.ForYouSkeleton',
@@ -178,6 +181,10 @@ function ForYouSection() {
         return hasAnyTodos ? renderTodoItems() : <EmptyState />;
     };
 
+    if (shouldHideForYouSection({isInitialLoad, hasAnyTodos, firstDayFreeTrial, cutoffDate: CONST.HOME.FOR_YOU_NEW_USER_CUTOFF_DATE})) {
+        return null;
+    }
+
     return <WidgetContainer title={translate('homePage.forYou')}>{renderContent()}</WidgetContainer>;
 }
 

src/pages/home/ForYouSection/shouldHideForYouSection.ts

@@ -0,0 +1,41 @@
+type ShouldHideForYouSectionParams = {
+    /** Whether the section is still in its initial load (skeleton) state. */
+    isInitialLoad: boolean;
+
+    /** Whether the user currently has any actionable to-do. */
+    hasAnyTodos: boolean;
+
+    /** The user's free-trial start date (`nvp_private_firstDayFreeTrial`), e.g. "2026-06-24". */
+    firstDayFreeTrial: string | undefined;
+
+    /** The cutoff date that splits new from old users. */
+    cutoffDate: string;
+};
+
+/**
+ * Decides whether the empty "For You" section should be hidden.
+ *
+ * New users (free-trial start on/after the cutoff date) have the empty section hidden until they have an actionable
+ * to-do, while old users (onboarded before the cutoff, or without a trial start date) always keep the section. We
+ * never hide during the initial load so the skeleton can render regardless of segment.
+ */
+function shouldHideForYouSection({isInitialLoad, hasAnyTodos, firstDayFreeTrial, cutoffDate}: ShouldHideForYouSectionParams): boolean {
+    if (isInitialLoad || hasAnyTodos) {
+        return false;
+    }
+
+    if (!firstDayFreeTrial) {
+        return false;
+    }
+
+    const trialStartMs = new Date(firstDayFreeTrial).getTime();
+    const cutoffMs = new Date(cutoffDate).getTime();
+
+    if (Number.isNaN(trialStartMs) || Number.isNaN(cutoffMs)) {
+        return false;
+    }
+
+    return trialStartMs >= cutoffMs;
+}
+
+export default shouldHideForYouSection;

tests/unit/pages/home/ForYouSection/isNewUserTest.ts

@@ -0,0 +1,40 @@
+import shouldHideForYouSection from '@pages/home/ForYouSection/shouldHideForYouSection';
+
+const CUTOFF = '2026-06-24';
+
+const baseParams = {
+    isInitialLoad: false,
+    hasAnyTodos: false,
+    firstDayFreeTrial: undefined as string | undefined,
+    cutoffDate: CUTOFF,
+};
+
+describe('shouldHideForYouSection', () => {
+    it('hides the section for a user who onboarded on the cutoff date', () => {
+        expect(shouldHideForYouSection({...baseParams, firstDayFreeTrial: '2026-06-24'})).toBe(true);
+    });
+
+    it('hides the section for a user who onboarded after the cutoff date', () => {
+        expect(shouldHideForYouSection({...baseParams, firstDayFreeTrial: '2026-07-01'})).toBe(true);
+    });
+
+    it('keeps the section for a user who onboarded before the cutoff date', () => {
+        expect(shouldHideForYouSection({...baseParams, firstDayFreeTrial: '2026-01-01'})).toBe(false);
+    });
+
+    it('keeps the section when the trial start date is missing', () => {
+        expect(shouldHideForYouSection({...baseParams, firstDayFreeTrial: undefined})).toBe(false);
+    });
+
+    it('keeps the section when the trial start date is unparseable', () => {
+        expect(shouldHideForYouSection({...baseParams, firstDayFreeTrial: 'not-a-date'})).toBe(false);
+    });
+
+    it('keeps the section during the initial load even for a new user', () => {
+        expect(shouldHideForYouSection({...baseParams, isInitialLoad: true, firstDayFreeTrial: '2026-07-01'})).toBe(false);
+    });
+
+    it('keeps the section when the user has actionable to-dos even for a new user', () => {
+        expect(shouldHideForYouSection({...baseParams, hasAnyTodos: true, firstDayFreeTrial: '2026-07-01'})).toBe(false);
+    });
+});