use CreateDomainSecurityGroup instead of UpdateDomainSecurityGroup API command for group creation, enable offline form handling

Author: jakubstec

src/libs/API/types.ts

@@ -573,6 +573,7 @@ const WRITE_COMMANDS = {
     EXPORT_DOMAIN_MEMBERS_CSV: 'ExportDomainMembersCSV',
     INITIATE_BANK_ACCOUNT_UNLOCK: 'InitiateBankAccountUnlock',
     UPDATE_DOMAIN_SECURITY_GROUP: 'UpdateDomainSecurityGroupForNewDot',
+    CREATE_DOMAIN_SECURITY_GROUP: 'CreateDomainSecurityGroup',
     SET_DEFAULT_DOMAIN_SECURITY_GROUP: 'SetDefaultDomainSecurityGroup',
 } as const;
 
@@ -1164,6 +1165,7 @@ type WriteCommandParameters = {
     [WRITE_COMMANDS.RESET_DOMAIN_MEMBER_TWO_FACTOR_AUTH]: Parameters.ResetDomainMemberTwoFactorAuthParams;
     [WRITE_COMMANDS.EXPORT_DOMAIN_MEMBERS_CSV]: Parameters.ExportDomainMembersCSVParams;
     [WRITE_COMMANDS.UPDATE_DOMAIN_SECURITY_GROUP]: Parameters.UpdateDomainSecurityGroupParams;
+    [WRITE_COMMANDS.CREATE_DOMAIN_SECURITY_GROUP]: Parameters.CreateDomainSecurityGroupParams;
     [WRITE_COMMANDS.SET_DEFAULT_DOMAIN_SECURITY_GROUP]: Parameters.SetDefaultDomainSecurityGroupParams;
 };
 

src/libs/actions/Domain.ts

@@ -1915,11 +1915,12 @@ function createDomainSecurityGroup(domainAccountID: number, newSecurityGroup: Do
         },
     ];
 
+    // using the same interface as UpdateDomainSecurityGroup to correctly handle errors
     const params: UpdateDomainSecurityGroupParams = {
         domainAccountID,
         name: SECURITY_GROUP_KEY,
         value: JSON.stringify(newSecurityGroup),
-        settingsName: 'createGroup', // placeholder, waiting for BE
+        settingsName: 'createGroup',
     };
 
     API.write(WRITE_COMMANDS.UPDATE_DOMAIN_SECURITY_GROUP, params, {optimisticData, failureData, successData});

src/pages/domain/Groups/DomainGroupCreatePage.tsx

@@ -111,6 +111,7 @@ function DomainGroupCreatePage({route}: DomainGroupCreatePageProps) {
                         clearDomainGroupCreatePreferredPolicyID();
                         Navigation.goBack(ROUTES.DOMAIN_GROUPS.getRoute(domainAccountID));
                     }}
+                    enabledWhenOffline
                     submitButtonText={translate('domain.groups.createGroupSubmitButton')}
                     style={[styles.flex1]}
                     submitButtonStyles={[styles.ph5, styles.pb3]}