refactor(mfa): rename idle input state

Author: dariusz-biela

src/components/MultifactorAuthentication/machine/mfaMachine.ts

@@ -226,21 +226,21 @@ const MFAMachine = setup({
                         // while the challenge request is in flight is dropped instead of emailing a
                         // code the pending submission ignores.
                         [MFA_STATE.AWAITING_VALIDATE_CODE]: {
-                            initial: MFA_STATE.IDLE,
+                            initial: MFA_STATE.AWAITING_INPUT,
                             on: {
                                 VALIDATE_CODE_ENTERED: {target: MFA_STATE.REQUESTING_REGISTRATION_CHALLENGE, actions: 'submitValidateCode'},
-                                RESEND_VALIDATE_CODE: {target: `.${MFA_STATE.IDLE}`, actions: 'requestValidateCode'},
+                                RESEND_VALIDATE_CODE: {target: `.${MFA_STATE.AWAITING_INPUT}`, actions: 'requestValidateCode'},
                             },
                             states: {
-                                [MFA_STATE.IDLE]: {},
+                                [MFA_STATE.AWAITING_INPUT]: {},
                                 // The backend rejected the submitted code. The screen shows the
                                 // inline error exactly while this state is active, so every way out
                                 // (typing, a resend, a new submission) drops the error by
                                 // construction and nothing stale can outlive the screen.
                                 [MFA_STATE.INVALID_CODE]: {
                                     tags: 'showsInvalidCodeError',
                                     on: {
-                                        VALIDATE_CODE_CHANGED: MFA_STATE.IDLE,
+                                        VALIDATE_CODE_CHANGED: MFA_STATE.AWAITING_INPUT,
                                     },
                                 },
                             },

src/libs/MultifactorAuthentication/shared/VALUES.ts

@@ -225,7 +225,7 @@ const MFA_STATE = {
     CHECKING_SOFT_PROMPT_ACCEPTANCE: 'checkingSoftPromptAcceptance',
     MAGIC_CODE: 'magicCode',
     AWAITING_VALIDATE_CODE: 'awaitingValidateCode',
-    IDLE: 'idle',
+    AWAITING_INPUT: 'awaitingInput',
     INVALID_CODE: 'invalidCode',
     REQUESTING_REGISTRATION_CHALLENGE: 'requestingRegistrationChallenge',
     PROMPT: 'prompt',

tests/unit/components/MultifactorAuthentication/machine/graphTraversal/viewMatchesMachine.test.tsx

@@ -218,7 +218,7 @@ const testConfig = {
             expect(screen.getByText(translateLocal('multifactorAuthentication.letsVerifyItsYou'))).toBeOnTheScreen();
             expect(state.context.error).toBeUndefined();
         },
-        [`${MFA_STATE.OPEN}.${MFA_STATE.MAGIC_CODE}.${MFA_STATE.AWAITING_VALIDATE_CODE}.${MFA_STATE.IDLE}`]: () => {
+        [`${MFA_STATE.OPEN}.${MFA_STATE.MAGIC_CODE}.${MFA_STATE.AWAITING_VALIDATE_CODE}.${MFA_STATE.AWAITING_INPUT}`]: () => {
             expect(screen.queryByText(translateLocal('validateCodeForm.error.incorrectSecurityCode'))).not.toBeOnTheScreen();
         },
         [`${MFA_STATE.OPEN}.${MFA_STATE.MAGIC_CODE}.${MFA_STATE.AWAITING_VALIDATE_CODE}.${MFA_STATE.INVALID_CODE}`]: () => {

tests/unit/components/MultifactorAuthentication/machine/validateCodeTransition.test.ts

@@ -122,7 +122,7 @@ describe('MFA magic code and registration decision', () => {
         actor.send({type: 'RESEND_VALIDATE_CODE'});
 
         const result = actor.getSnapshot();
-        expect(result.matches({[MFA_STATE.OPEN]: {[MFA_STATE.MAGIC_CODE]: {[MFA_STATE.AWAITING_VALIDATE_CODE]: MFA_STATE.IDLE}}})).toBe(true);
+        expect(result.matches({[MFA_STATE.OPEN]: {[MFA_STATE.MAGIC_CODE]: {[MFA_STATE.AWAITING_VALIDATE_CODE]: MFA_STATE.AWAITING_INPUT}}})).toBe(true);
         expect(result.hasTag('showsInvalidCodeError')).toBe(false);
         expect(requestValidateCodeActionMock).toHaveBeenCalledTimes(1);
 
@@ -249,7 +249,7 @@ describe('MFA magic code and registration decision', () => {
         actor.send({type: 'VALIDATE_CODE_CHANGED'});
 
         const result = actor.getSnapshot();
-        expect(result.matches({[MFA_STATE.OPEN]: {[MFA_STATE.MAGIC_CODE]: {[MFA_STATE.AWAITING_VALIDATE_CODE]: MFA_STATE.IDLE}}})).toBe(true);
+        expect(result.matches({[MFA_STATE.OPEN]: {[MFA_STATE.MAGIC_CODE]: {[MFA_STATE.AWAITING_VALIDATE_CODE]: MFA_STATE.AWAITING_INPUT}}})).toBe(true);
         expect(result.hasTag('showsInvalidCodeError')).toBe(false);
 
         actor.stop();