resolved comments from dylan

Author: thelullabyy

src/hooks/useSelectedExpenseReports.ts

@@ -17,31 +17,28 @@ type PolicyExpenseParticipant = {
 
 /**
  * Resolves the expense reports for the policy expense chat participants without subscribing the consumer to the
- * entire reports collection. Returns a `getReportByID` resolver so callers only re-render when one of the relevant
- * reports changes.
+ * entire reports collection, so callers only re-render when one of the relevant reports changes.
+ *
+ * Returns a `getReportByID` resolver (rather than the raw reports collection) because it matches the resolver
+ * contract expected by `formatSectionsFromSearchTerm` and keeps the Onyx key construction encapsulated here
+ * instead of being duplicated at every call site.
  */
 export default function useSelectedExpenseReports(participants: readonly PolicyExpenseParticipant[]) {
     const expenseReportIDs = participants
         .filter((participant): participant is PolicyExpenseParticipant & {reportID: string} => !!participant.isPolicyExpenseChat && !!participant.reportID)
         .map((participant) => participant.reportID);
 
-    // Serialized key used to refresh the selector only when the set of relevant report IDs actually changes.
-    const expenseReportIDsKey = expenseReportIDs.join(',');
-
-    const [expenseReports] = useOnyx(
-        ONYXKEYS.COLLECTION.REPORT,
-        {
-            selector: (reports: OnyxCollection<Report>) => {
-                const result: OnyxCollection<Report> = {};
-                for (const reportID of expenseReportIDs) {
-                    const key = `${ONYXKEYS.COLLECTION.REPORT}${getNonEmptyStringOnyxID(reportID)}` as const;
-                    result[key] = reports?.[key];
-                }
-                return result;
-            },
+    // React Compiler memoizes the selector on `expenseReportIDs`, so it re-runs whenever the set of relevant report IDs changes.
+    const [expenseReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {
+        selector: (reports: OnyxCollection<Report>) => {
+            const result: OnyxCollection<Report> = {};
+            for (const reportID of expenseReportIDs) {
+                const key = `${ONYXKEYS.COLLECTION.REPORT}${getNonEmptyStringOnyxID(reportID)}` as const;
+                result[key] = reports?.[key];
+            }
+            return result;
         },
-        [expenseReportIDsKey],
-    );
+    });
 
     return (reportID: string | undefined): OnyxEntry<Report> => expenseReports?.[`${ONYXKEYS.COLLECTION.REPORT}${getNonEmptyStringOnyxID(reportID)}`];
 }

tests/unit/OptionsListUtilsTest.tsx

@@ -7948,6 +7948,7 @@ describe('OptionsListUtils', () => {
                 privateIsArchivedMap,
                 CURRENT_USER_ACCOUNT_ID,
                 undefined,
+                translateLocal,
                 formatPersonalDetails,
                 true,
                 undefined,