Skip to content

Commit a9af1f0

Browse files
authored
Merge pull request Expensify#93790 from daledah/fix/66424-3
refactor prepareOnboardingOnyxData function to always use hasCompletedGuidedSetupFlow as false in failureData
2 parents d3f4805 + ec6accd commit a9af1f0

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

src/libs/ReportUtils.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11535,8 +11535,6 @@ type PrepareOnboardingOnyxDataParams = {
1153511535
onboardingPurposeSelected?: OnboardingPurpose;
1153611536
// TODO: isSelfTourViewed will be required eventually. Refactor issue: https://github.com/Expensify/App/issues/66424
1153711537
isSelfTourViewed?: boolean;
11538-
// TODO: hasCompletedGuidedSetupFlow will be required eventually. Refactor issue: https://github.com/Expensify/App/issues/66424
11539-
hasCompletedGuidedSetupFlow?: boolean;
1154011538
};
1154111539

1154211540
function prepareOnboardingOnyxData({
@@ -11551,7 +11549,6 @@ function prepareOnboardingOnyxData({
1155111549
isInvitedAccountant,
1155211550
onboardingPurposeSelected,
1155311551
isSelfTourViewed,
11554-
hasCompletedGuidedSetupFlow,
1155511552
}: PrepareOnboardingOnyxDataParams) {
1155611553
if (engagementChoice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND) {
1155711554
// eslint-disable-next-line no-param-reassign
@@ -12020,7 +12017,7 @@ function prepareOnboardingOnyxData({
1202012017
failureData.push({
1202112018
onyxMethod: Onyx.METHOD.MERGE,
1202212019
key: ONYXKEYS.NVP_ONBOARDING,
12023-
value: {hasCompletedGuidedSetupFlow: hasCompletedGuidedSetupFlow ?? onboarding?.hasCompletedGuidedSetupFlow ?? null},
12020+
value: {hasCompletedGuidedSetupFlow: false},
1202412021
});
1202512022
}
1202612023

src/libs/actions/Report/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1424,7 +1424,6 @@ function getGuidedSetupDataForOpenReport(
14241424
onboardingMessage,
14251425
companySize: introSelected?.companySize as OnboardingCompanySize,
14261426
isSelfTourViewed,
1427-
hasCompletedGuidedSetupFlow,
14281427
});
14291428

14301429
if (!onboardingData) {

0 commit comments

Comments
 (0)