fix: prevent first PDF send foreign key race

Author: kfaracik

components/chat-screen/ChatBar.tsx

@@ -39,7 +39,7 @@ interface Props {
     userInput: string,
     imagePath?: string,
     attachments?: Attachment[]
-  ) => void;
+  ) => void | Promise<void>;
   onSelectModel: () => void;
   onSelectPrompt: (prompt: string) => void;
   ref: Ref<{
@@ -142,7 +142,7 @@ const ChatBar = ({
         onBarGrow?.();
       }
     },
-    [extraContentPadding, onHeightChange, hasMessages]
+    [extraContentPadding, onHeightChange, onBarGrow, hasMessages]
   );
 
   const {
@@ -169,8 +169,17 @@ const ChatBar = ({
 
   const handleSend = useCallback(() => {
     if (hasLoadingAttachment) return;
-    onSend(userInput, imageAttachment?.uri, attachments);
-    clearAll();
+    const attachmentsToSend = attachments;
+    const imageUriToSend = imageAttachment?.uri;
+    const inputToSend = userInput;
+
+    setUserInput('');
+    clearAll({ cleanupSources: false });
+    Promise.resolve(
+      onSend(inputToSend, imageUriToSend, attachmentsToSend)
+    ).catch((error) => {
+      console.error('Failed to send message:', error);
+    });
   }, [
     onSend,
     userInput,
@@ -235,8 +244,14 @@ const ChatBar = ({
     const handleSubmit = (transcript: string) => {
       setShowSpeechInput(false);
       if (transcript) {
-        onSend(transcript, imageAttachment?.uri, attachments);
-        clearAll();
+        const attachmentsToSend = attachments;
+        const imageUriToSend = imageAttachment?.uri;
+        clearAll({ cleanupSources: false });
+        Promise.resolve(
+          onSend(transcript, imageUriToSend, attachmentsToSend)
+        ).catch((error) => {
+          console.error('Failed to send transcript:', error);
+        });
       }
     };
 

components/chat-screen/ChatScreen.tsx

@@ -9,6 +9,7 @@ import { Keyboard, StyleSheet, useWindowDimensions, View } from 'react-native';
 import { LinearGradient } from 'expo-linear-gradient';
 import { BottomSheetModal } from '@gorhom/bottom-sheet';
 import { KeyboardStickyView } from 'react-native-keyboard-controller';
+import { router } from 'expo-router';
 import Animated, {
   useAnimatedStyle,
   useSharedValue,
@@ -94,6 +95,7 @@ export default function ChatScreen({
     isGenerating,
     sendChatMessage,
     loadModel,
+    setActiveChatId,
     model: loadedModel,
   } = useLLMStore();
   const { getModelById } = useModelStore();
@@ -153,14 +155,21 @@ export default function ChatScreen({
     const hasDocuments = attachments?.some((a) => a.type === 'document');
     if ((!userInput.trim() && !imagePath && !hasDocuments) || isGenerating)
       return;
-    if (!(await checkIfChatExists(db, chatId!))) {
+
+    let targetChatId = chatId!;
+    if (!(await checkIfChatExists(db, targetChatId))) {
       const docName = attachments?.find((a) => a.type === 'document')?.name;
       const titleSource = userInput.trim() || docName || 'New chat';
       const newChatTitle =
         titleSource.length > 25
           ? titleSource.slice(0, 25) + '...'
           : titleSource;
-      await addChat(newChatTitle, model!.id);
+      const newChatId = await addChat(newChatTitle, model!.id);
+      if (!newChatId) return;
+
+      targetChatId = newChatId;
+      await setActiveChatId(targetChatId);
+      router.replace(`/chat/${targetChatId}`);
     }
 
     let persistedImagePath: string | undefined = imagePath;
@@ -177,9 +186,8 @@ export default function ChatScreen({
       }
     }
 
-    inputRef.current?.clear();
     Keyboard.dismiss();
-    updateLastUsed(chatId!);
+    updateLastUsed(targetChatId);
 
     // Notify Messages that a send is in flight. It will seed blankSpace to
     // the full container height, then derive the final value from measured
@@ -221,7 +229,7 @@ export default function ChatScreen({
     // Enable new sources for this chat (persists for future messages)
     for (const sourceId of attachmentSourceIds) {
       if (!enabledSources.includes(sourceId)) {
-        await enableSource(chatId!, sourceId);
+        await enableSource(targetChatId, sourceId);
       }
     }
 
@@ -239,7 +247,7 @@ export default function ChatScreen({
         .join(', ') || undefined;
     await sendChatMessage(
       userInput,
-      chatId!,
+      targetChatId,
       context,
       settings,
       persistedImagePath,

hooks/useAttachment.ts

@@ -16,6 +16,10 @@ export interface Attachment {
   sourceId?: number;
 }
 
+interface ClearAllOptions {
+  cleanupSources?: boolean;
+}
+
 const requestAndroidGalleryPermission = async (): Promise<boolean> => {
   if (Platform.OS !== 'android') return true;
 
@@ -175,13 +179,17 @@ export const useAttachment = () => {
     [vectorStore]
   );
 
-  const clearAll = useCallback(() => {
-    const hadDocuments = attachmentsRef.current.some((a) => a.sourceId);
-    setAttachments([]);
-    if (hadDocuments && vectorStore) {
-      useSourceStore.getState().cleanupOrphanedSources(vectorStore);
-    }
-  }, [vectorStore]);
+  const clearAll = useCallback(
+    (options: ClearAllOptions = {}) => {
+      const cleanupSources = options.cleanupSources ?? true;
+      const hadDocuments = attachmentsRef.current.some((a) => a.sourceId);
+      setAttachments([]);
+      if (cleanupSources && hadDocuments && vectorStore) {
+        useSourceStore.getState().cleanupOrphanedSources(vectorStore);
+      }
+    },
+    [vectorStore]
+  );
 
   const openSheet = useCallback(() => {
     sheetRef.current?.present();