feat: simplify iOS metro URL passing (#1829)

Simplifies how the Metro server URL is passed to the application.
We make use of a mechanism of `simctl` where extra arguments for the
`launch` command are passed to the application as `UserDefaults`
entries, which is how `react-native` gets the JS bundle URL.

### How Has This Been Tested: 
- open react-native-(75-83) apps in Radon on iOS simulator
- if the app was previously installed, use the "Reinstall App" reload
option to clear the existing `UserDefaults` entries created by Radon
before this change
- verify the app loads and connects to Metro
- [BONUS POINTS] -- you can check that the option is not persistent by
opening the App Switcher, killing the app and restarting it from
Springboard -- the Application should fail to fetch the bundle now

### How Has This Change Been Documented:
INTERNAL

Author: jwajgelt

packages/vscode-extension/src/devices/IosSimulatorDevice.ts

@@ -317,92 +317,6 @@ export class IosSimulatorDevice extends DeviceBase {
     return true;
   }
 
-  async configureMetroPort(bundleID: string, metroPort: number) {
-    const deviceSetLocation = getOrCreateDeviceSet(this.deviceUDID);
-    const { stdout: appDataLocation } = await exec("xcrun", [
-      "simctl",
-      "--set",
-      deviceSetLocation,
-      "get_app_container",
-      this.deviceUDID,
-      bundleID,
-      "data",
-    ]);
-    const userDefaultsLocation = path.join(
-      appDataLocation,
-      "Library",
-      "Preferences",
-      `${bundleID}.plist`
-    );
-    Logger.debug(`Defaults location ${userDefaultsLocation}`);
-    await exec(
-      "/usr/libexec/PlistBuddy",
-      [
-        "-c",
-        "Delete :RCT_jsLocation",
-        "-c",
-        `Add :RCT_jsLocation string localhost:${metroPort}`,
-        userDefaultsLocation,
-      ],
-      { allowNonZeroExit: true, reject: false }
-    );
-
-    // Simulator may keep the defaults in memory with cfprefsd, we restart the daemon to make sure
-    // it reads the latest values from disk.
-    // We'd normally try to use defaults command that would write the updates via the daemon, however
-    // for some reason that doesn't work with custom device sets.
-    await exec(
-      "xcrun",
-      [
-        "simctl",
-        "--set",
-        deviceSetLocation,
-        "spawn",
-        this.deviceUDID,
-        "launchctl",
-        "stop",
-        "com.apple.cfprefsd.xpc.daemon",
-      ],
-      { reject: false }
-    );
-
-    // Restarting cfprefsd breaks the SpringBoard process which in particular controls things like
-    // the appearance settings. We need to restart it following the cfprefsd reset.
-    await exec(
-      "xcrun",
-      [
-        "simctl",
-        "--set",
-        deviceSetLocation,
-        "spawn",
-        this.deviceUDID,
-        "launchctl",
-        "kickstart",
-        "-k",
-        "system/com.apple.SpringBoard",
-      ],
-      { reject: false }
-    );
-
-    // Restarting SpringBoard process breaks the backboardd which in particular controls things like
-    // the rotation settings. We need to restart it following the cfprefsd springboard reset.
-    await exec(
-      "xcrun",
-      [
-        "simctl",
-        "--set",
-        deviceSetLocation,
-        "spawn",
-        this.deviceUDID,
-        "launchctl",
-        "kickstart",
-        "-k",
-        "system/com.apple.backboardd",
-      ],
-      { reject: false }
-    );
-  }
-
   async terminateApp(bundleID: string) {
     const deviceSetLocation = getOrCreateDeviceSet(this.deviceUDID);
 
@@ -551,8 +465,12 @@ export class IosSimulatorDevice extends DeviceBase {
       }
     } else {
       Logger.info("Launching app using bundle ID without deeplink");
-      await this.configureMetroPort(build.bundleID, metroPort);
-      await this.launchWithBuild(build, launchArguments);
+      const launchArgsWithJsLocation = [
+        ...launchArguments,
+        "-RCT_jsLocation",
+        `localhost:${metroPort}`,
+      ];
+      await this.launchWithBuild(build, launchArgsWithJsLocation);
     }
   }