Skip to content

Commit b3b8076

Browse files
authored
chore: remove festive visuals (#1842)
### Description This PR removes `Festive Mode` toggle and visuals. No more cheer. The 894950b and fa86790 commits, which introduced the functionality, were simply reverted as the changes were independent from the rest of the app. ### How Has This Been Tested: Launched the extension and verified that UI functions correctly, the toggle is no longer visible and setting the `"RadonIDE.userInterface.festiveMode": true` in user settings does not cause undefined behaviour. Verified that code changes are independent from the rest of the app. ### How Has This Change Been Documented: Not applicable.
1 parent 28bb9c6 commit b3b8076

File tree

12 files changed

+7
-333
lines changed

12 files changed

+7
-333
lines changed

packages/vscode-extension/package-lock.json

Lines changed: 5 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/vscode-extension/package.json

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -409,12 +409,6 @@
409409
"scope": "window",
410410
"default": true,
411411
"description": "Shows device frame in the IDE panel."
412-
},
413-
"RadonIDE.userInterface.festiveMode": {
414-
"type": "boolean",
415-
"scope": "window",
416-
"default": false,
417-
"description": "Enables festive mode in the IDE panel."
418412
}
419413
}
420414
},
@@ -1363,8 +1357,7 @@
13631357
"vscode-test": "^1.6.1",
13641358
"ws": "^8.18.1",
13651359
"xml2js": "^0.6.2",
1366-
"zod": "^3.25.32",
1367-
"react-snowfall": "^2.4.0"
1360+
"zod": "^3.25.32"
13681361
},
13691362
"optionalDependencies": {
13701363
"@rollup/rollup-linux-x64-gnu": "4.40.0"

packages/vscode-extension/src/common/State.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ export type RadonAISettings = {
9797
export type UserInterfaceSettings = {
9898
panelLocation: PanelLocation;
9999
showDeviceFrame: boolean;
100-
festiveMode?: boolean;
101100
};
102101

103102
export type DeviceControlSettings = {
@@ -628,7 +627,6 @@ export const initialState: State = {
628627
userInterface: {
629628
panelLocation: "tab",
630629
showDeviceFrame: true,
631-
festiveMode: false,
632630
},
633631
deviceSettings: {
634632
deviceRotation: DeviceRotation.Portrait,

packages/vscode-extension/src/utilities/workspaceConfiguration.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ const WorkspaceConfigurationKeyMap = {
2323
userInterface: {
2424
panelLocation: "userInterface.panelLocation",
2525
showDeviceFrame: "userInterface.showDeviceFrame",
26-
festiveMode: "userInterface.festiveMode",
2726
},
2827
deviceSettings: {
2928
deviceRotation: "deviceSettings.deviceRotation",
@@ -65,8 +64,6 @@ export function getCurrentWorkspaceConfiguration(config: WorkspaceConfiguration)
6564
"tab",
6665
showDeviceFrame:
6766
config.get<boolean>(WorkspaceConfigurationKeyMap.userInterface.showDeviceFrame) ?? true,
68-
festiveMode:
69-
config.get<boolean>(WorkspaceConfigurationKeyMap.userInterface.festiveMode) ?? false,
7067
},
7168
deviceControl: {
7269
startDeviceOnLaunch:

packages/vscode-extension/src/webview/components/PreviewLoader.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import classNames from "classnames";
22
import { useEffect, useState } from "react";
3-
import { use$ } from "@legendapp/state/react";
43

54
import "./PreviewLoader.css";
65

@@ -11,6 +10,7 @@ import { useProject } from "../providers/ProjectProvider";
1110
import Button from "./shared/Button";
1211
import { Output } from "../../common/OutputChannel";
1312
import { useStore } from "../providers/storeProvider";
13+
import { use$ } from "@legendapp/state/react";
1414
import {
1515
DevicePlatform,
1616
DeviceRotation,
@@ -19,8 +19,6 @@ import {
1919
} from "../../common/State";
2020
import { useSelectedDeviceSessionState } from "../hooks/selectedSession";
2121

22-
import AsciiChristmasTree from "./festive/AsciiChristmasTree";
23-
2422
const startupStageWeightSum = StartupStageWeight.map((item) => item.weight).reduce(
2523
(acc, cur) => acc + cur,
2624
0
@@ -113,11 +111,8 @@ function PreviewLoader({ onRequestShowPreview }: { onRequestShowPreview: () => v
113111
}
114112
}
115113

116-
const festiveMode = use$(store$.workspaceConfiguration.userInterface.festiveMode);
117-
118114
return (
119115
<div className={`preview-loader-wrapper ${isLandscape ? "landscape" : "portrait"}`}>
120-
{festiveMode && <AsciiChristmasTree />}
121116
<div className="preview-loader-load-info">
122117
<button className="preview-loader-container" onClick={handleLoaderClick}>
123118
<div className="preview-loader-button-group">

packages/vscode-extension/src/webview/components/SettingsDropdown.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import { ActivateLicenseView } from "../views/ActivateLicenseView";
1616
import { LicenseStatus } from "../../common/License";
1717
import ExportLogsView from "../views/ExportLogsView";
1818

19-
import { FestiveModeToggle } from "./festive/FestiveModeToggle";
20-
2119
interface SettingsDropdownProps {
2220
children: React.ReactNode;
2321
isDeviceRunning: boolean;
@@ -168,7 +166,6 @@ function SettingsDropdown({ project, isDeviceRunning, children, disabled }: Sett
168166
</DropdownMenu.Item>
169167
{telemetryEnabled && <SendFeedbackItem />}
170168
{shouldShowActivateLicenseItem && <ActivateLicenseItem />}
171-
<FestiveModeToggle />
172169
<div className="dropdown-menu-item device-settings-version-text">
173170
Radon IDE version: {extensionVersion}
174171
</div>

packages/vscode-extension/src/webview/components/festive/AsciiChristmasTree.css

Lines changed: 0 additions & 24 deletions
This file was deleted.

packages/vscode-extension/src/webview/components/festive/AsciiChristmasTree.tsx

Lines changed: 0 additions & 190 deletions
This file was deleted.

0 commit comments

Comments
 (0)