Skip to content

Commit eec7e00

Browse files
authored
feat: disable maestro UI until it`s ready (#1799)
Removes entry points for Maestro tests from the UI: - CodeLens Provider for editor inline hints - Tools drop-down entry - Diagnostics entry - VSCode commands ### How Has This Been Tested: - run Radon with maestro installed - check that you can't start maestro tests inside Radon ### How Has This Change Been Documented: meh
1 parent f894c22 commit eec7e00

File tree

3 files changed

+0
-56
lines changed

3 files changed

+0
-56
lines changed

packages/vscode-extension/src/extension.ts

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import { PanelLocation } from "./common/State";
3838
import { DeviceRotationDirection, IDEPanelMoveTarget } from "./common/Project";
3939
import { AdminRestrictedFunctionalityError, PaywalledFunctionalityError } from "./common/Errors";
4040
import { registerRadonAI } from "./ai/mcp/RadonMcpController";
41-
import { MaestroCodeLensProvider } from "./providers/MaestroCodeLensProvider";
4241
import { removeLicense } from "./utilities/license";
4342

4443
const CHAT_ONBOARDING_COMPLETED = "chat_onboarding_completed";
@@ -208,25 +207,6 @@ export async function activate(context: ExtensionContext) {
208207
}
209208
}
210209

211-
async function startMaestroTest(fileNames: string[]) {
212-
const ide = IDE.getInstanceIfExists();
213-
if (ide) {
214-
ide.project.startMaestroTest(fileNames);
215-
} else {
216-
window.showWarningMessage(
217-
"Wait for the app to load before running Maestro tests.",
218-
"Dismiss"
219-
);
220-
}
221-
}
222-
223-
async function stopMaestroTest() {
224-
const ide = IDE.getInstanceIfExists();
225-
if (ide) {
226-
ide.project.stopMaestroTest();
227-
}
228-
}
229-
230210
function removeLicenseWithConfirmation() {
231211
window
232212
.showWarningMessage(
@@ -286,8 +266,6 @@ export async function activate(context: ExtensionContext) {
286266
context.subscriptions.push(
287267
commands.registerCommand("RNIDE.showInlinePreview", showInlinePreview)
288268
);
289-
context.subscriptions.push(commands.registerCommand("RNIDE.startMaestroTest", startMaestroTest));
290-
context.subscriptions.push(commands.registerCommand("RNIDE.stopMaestroTest", stopMaestroTest));
291269

292270
context.subscriptions.push(commands.registerCommand("RNIDE.captureReplay", captureReplay));
293271
context.subscriptions.push(commands.registerCommand("RNIDE.toggleRecording", toggleRecording));
@@ -392,13 +370,6 @@ export async function activate(context: ExtensionContext) {
392370
)
393371
);
394372

395-
context.subscriptions.push(
396-
languages.registerCodeLensProvider(
397-
[{ scheme: "file", language: "yaml" }],
398-
new MaestroCodeLensProvider()
399-
)
400-
);
401-
402373
context.subscriptions.push(
403374
workspace.onDidChangeConfiguration((event: ConfigurationChangeEvent) => {
404375
if (event.affectsConfiguration("RadonIDE.userInterface.panelLocation")) {

packages/vscode-extension/src/webview/components/ToolsDropdown.tsx

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import { ProjectInterface } from "../../common/Project";
1616
import Tooltip from "./shared/Tooltip";
1717
import { useSelectedDeviceSessionState } from "../hooks/selectedSession";
1818
import { ToolsState, ToolState } from "../../common/State";
19-
import { useStore } from "../providers/storeProvider";
2019

2120
interface DevToolCheckboxProps {
2221
label: string;
@@ -95,12 +94,7 @@ function ToolsDropdown({ children, disabled }: { children: React.ReactNode; disa
9594
const selectedDeviceSessionStatus = use$(selectedDeviceSessionState.status);
9695

9796
const { project } = useProject();
98-
const store$ = useStore();
99-
const applicationDependencies = use$(
100-
store$.projectState.applicationContext.applicationDependencies
101-
);
10297

103-
const isMaestroInstalled = applicationDependencies.maestro?.status === "installed";
10498
const isRunning = selectedDeviceSessionStatus === "running";
10599

106100
const profilingCPUState = use$(selectedDeviceSessionState?.applicationSession.profilingCPUState);
@@ -132,26 +126,6 @@ function ToolsDropdown({ children, disabled }: { children: React.ReactNode; disa
132126
data-testid="radon-tools-dropdown-menu"
133127
onCloseAutoFocus={(e) => e.preventDefault()}>
134128
<h4 className="device-settings-heading">Tools</h4>
135-
{isMaestroInstalled && (
136-
<>
137-
<Label>Testing</Label>
138-
<DropdownMenu.Item
139-
className="dropdown-menu-item"
140-
data-testid="tools-dropdown-menu-maestro-test-button"
141-
onSelect={() => {
142-
const fileDialogPromise = project.openSelectMaestroFileDialog();
143-
fileDialogPromise.then((fileNames) => {
144-
if (fileNames) {
145-
project.startMaestroTest(fileNames);
146-
}
147-
});
148-
}}>
149-
<span className="codicon codicon-github-action" />
150-
Start Maestro test(s)...
151-
</DropdownMenu.Item>
152-
</>
153-
)}
154-
155129
<Label>Utilities</Label>
156130
<DropdownMenu.Item
157131
className="dropdown-menu-item"

packages/vscode-extension/src/webview/views/DiagnosticView.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ function DiagnosticView() {
7070
<Label>Other</Label>
7171
<DiagnosticItem label="Expo Router" name="expoRouter" info={dependencies.expoRouter} />
7272
<DiagnosticItem label="Storybook" name="storybook" info={dependencies.storybook} />
73-
<DiagnosticItem label="Maestro" name="maestro" info={dependencies.maestro} />
7473
<DiagnosticItem label="eas-cli" name="easCli" info={dependencies.easCli} />
7574
<div className="diagnostic-section-margin" />
7675

0 commit comments

Comments
 (0)