Skip to content

Commit ffbda8e

Browse files
authored
chore: unblock debug console button in radon connect (#1796)
This PR very slightly improves the experience in radon connect mode. By unblocking the button that focuses debug console if the remote metro is connected. Things to consider improving in future work: - migrate the radon connect state to the new state management - support for js and react profiling in radon connect - rethink what the `applicationSession` means so we are able to read the "log count" menage debugger state and triger profiles with an uniform api. ### How Has This Been Tested: - use radon connect ### How Has This Change Been Documented: none
1 parent f2f6363 commit ffbda8e

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

packages/vscode-extension/src/webview/views/PreviewView.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,10 @@ function PreviewView() {
188188
navBarButtonsActive &&
189189
isRunning &&
190190
inspectorAvailabilityStatus === InspectorAvailabilityStatus.Available;
191-
const debuggerToolsButtonsActive = navBarButtonsActive; // this stays in sync with navBarButtonsActive, but we will enable it for radon connect later
191+
// this stays in sync with navBarButtonsActive, but we will enable it for radon connect later,
192+
// once we support js and react profiling in radon connect.
193+
const debuggerToolsButtonsActive = navBarButtonsActive;
194+
const debugConsoleButtonActive = navBarButtonsActive || radonConnectConnected;
192195

193196
const deviceProperties = iOSSupportedDevices.concat(AndroidSupportedDevices).find((sd) => {
194197
return sd.modelId === modelId;
@@ -441,7 +444,7 @@ function PreviewView() {
441444
tooltip={{
442445
label: "Open logs panel",
443446
}}
444-
disabled={!debuggerToolsButtonsActive}>
447+
disabled={!debugConsoleButtonActive}>
445448
<span slot="start" className="codicon codicon-debug-console" />
446449
</IconButton>
447450
<SettingsDropdown project={project} isDeviceRunning={isRunning || radonConnectConnected}>

0 commit comments

Comments
 (0)