Skip to content

Commit 011d01c

Browse files
fix: setting strokeMiterLimit prop
1 parent 042131e commit 011d01c

38 files changed

+46
-42
lines changed

android/src/main/java/com/horcrux/svg/RenderableView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ boolean setupStrokePaint(Paint paint, float opacity) {
604604
paint.setStyle(Paint.Style.STROKE);
605605
paint.setStrokeCap(strokeLinecap);
606606
paint.setStrokeJoin(strokeLinejoin);
607-
paint.setStrokeMiter(strokeMiterlimit * mScale);
607+
paint.setStrokeMiter(strokeMiterlimit);
608608
paint.setStrokeWidth((float) strokeWidth);
609609
setupPaint(paint, opacity, stroke);
610610

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGCircleManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9595
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9696
break;
9797
case "strokeMiterlimit":
98-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
98+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
9999
break;
100100
case "vectorEffect":
101101
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGClipPathManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9595
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9696
break;
9797
case "strokeMiterlimit":
98-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
98+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
9999
break;
100100
case "vectorEffect":
101101
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGEllipseManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9595
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9696
break;
9797
case "strokeMiterlimit":
98-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
98+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
9999
break;
100100
case "vectorEffect":
101101
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGForeignObjectManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9595
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9696
break;
9797
case "strokeMiterlimit":
98-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
98+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
9999
break;
100100
case "vectorEffect":
101101
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGGroupManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9595
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9696
break;
9797
case "strokeMiterlimit":
98-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
98+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
9999
break;
100100
case "vectorEffect":
101101
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGImageManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9696
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9797
break;
9898
case "strokeMiterlimit":
99-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
99+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
100100
break;
101101
case "vectorEffect":
102102
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGLineManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9595
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9696
break;
9797
case "strokeMiterlimit":
98-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
98+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
9999
break;
100100
case "vectorEffect":
101101
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGMarkerManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9595
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9696
break;
9797
case "strokeMiterlimit":
98-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
98+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
9999
break;
100100
case "vectorEffect":
101101
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

android/src/paper/java/com/facebook/react/viewmanagers/RNSVGMaskManagerDelegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public void setProperty(T view, String propName, @Nullable Object value) {
9595
mViewManager.setStrokeDashoffset(view, value == null ? 0f : ((Double) value).floatValue());
9696
break;
9797
case "strokeMiterlimit":
98-
mViewManager.setStrokeMiterlimit(view, value == null ? 0f : ((Double) value).floatValue());
98+
mViewManager.setStrokeMiterlimit(view, value == null ? 4f : ((Double) value).floatValue());
9999
break;
100100
case "vectorEffect":
101101
mViewManager.setVectorEffect(view, value == null ? 0 : ((Double) value).intValue());

0 commit comments

Comments
 (0)