Skip to content

Commit e79a6c1

Browse files
authored
fix: FeDropShadow results and import react (#2625)
# Summary * Add results alias in `FeDropShadow` * Import React in every tsx filter file to satisfy typescript/eslint * Replace `<>` with `<React.Fragment>` in `FeDropShadow`
1 parent 04d0e89 commit e79a6c1

12 files changed

+22
-11
lines changed

src/elements/filters/FeBlend.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import React from 'react';
12
import { NativeMethods } from 'react-native';
23
import {
34
extractFeBlend,

src/elements/filters/FeColorMatrix.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as React from 'react';
1+
import React from 'react';
22
import { NativeMethods } from 'react-native';
33
import RNSVGFeColorMatrix from '../../fabric/FeColorMatrixNativeComponent';
44
import {

src/elements/filters/FeComponentTransfer.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as React from 'react';
1+
import React from 'react';
22
import FilterPrimitive from './FilterPrimitive';
33
import { warnUnimplementedFilter } from '../../lib/util';
44

src/elements/filters/FeComponentTransferFunction.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import React from 'react';
12
import { NumberArray, NumberProp } from '../../lib/extract/types';
23
import { warnUnimplementedFilter } from '../../lib/util';
34
import FilterPrimitive from './FilterPrimitive';

src/elements/filters/FeComposite.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import React from 'react';
12
import { NativeMethods } from 'react-native';
23
import RNSVGFeComposite from '../../fabric/FeCompositeNativeComponent';
34
import {

src/elements/filters/FeDropShadow.tsx

+11-4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import React from 'react';
12
import { ColorValue } from 'react-native';
23
import { NumberArray, NumberProp } from '../../lib/extract/types';
34
import FeFlood from './FeFlood';
@@ -25,21 +26,27 @@ export default class FeDropShadow extends FilterPrimitive<FeDropShadowProps> {
2526
};
2627

2728
render() {
28-
const { stdDeviation, in: in1 = 'SourceGraphic', dx, dy } = this.props;
29+
const {
30+
stdDeviation,
31+
in: in1 = 'SourceGraphic',
32+
dx,
33+
dy,
34+
result,
35+
} = this.props;
2936
return (
30-
<>
37+
<React.Fragment>
3138
<FeGaussianBlur in={in1} stdDeviation={stdDeviation} />
3239
<FeOffset dx={dx} dy={dy} result="offsetblur" />
3340
<FeFlood
3441
floodColor={this.props.floodColor}
3542
floodOpacity={this.props.floodOpacity}
3643
/>
3744
<FeComposite in2="offsetblur" operator="in" />
38-
<FeMerge>
45+
<FeMerge result={result}>
3946
<FeMergeNode />
4047
<FeMergeNode in={in1} />
4148
</FeMerge>
42-
</>
49+
</React.Fragment>
4350
);
4451
}
4552
}

src/elements/filters/FeFlood.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import React from 'react';
12
import { ColorValue, NativeMethods } from 'react-native';
23
import RNSVGFeFlood from '../../fabric/FeFloodNativeComponent';
34
import extractFeFlood, { extractFilter } from '../../lib/extract/extractFilter';

src/elements/filters/FeGaussianBlur.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as React from 'react';
1+
import React from 'react';
22
import { NativeMethods } from 'react-native';
33
import RNSVGFeGaussianBlur from '../../fabric/FeGaussianBlurNativeComponent';
44
import {

src/elements/filters/FeMerge.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as React from 'react';
1+
import React from 'react';
22
import { NativeMethods } from 'react-native';
33
import RNSVGFeMerge from '../../fabric/FeMergeNativeComponent';
44
import { extractFeMerge, extractFilter } from '../../lib/extract/extractFilter';

src/elements/filters/FeMergeNode.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as React from 'react';
1+
import React from 'react';
22
import FilterPrimitive from './FilterPrimitive';
33

44
export interface FeMergeNodeProps {

src/elements/filters/FeOffset.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as React from 'react';
1+
import React from 'react';
22
import { NativeMethods } from 'react-native';
33
import RNSVGFeOffset from '../../fabric/FeOffsetNativeComponent';
44
import { extractFilter, extractIn } from '../../lib/extract/extractFilter';

src/elements/filters/Filter.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as React from 'react';
1+
import React from 'react';
22
import { NativeMethods } from 'react-native';
33
import RNSVGFilter from '../../fabric/FilterNativeComponent';
44
import { NumberProp, Units } from '../../lib/extract/types';

0 commit comments

Comments
 (0)