feat: calculate width from height #2399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohdanprog
changed the title
jakex7
reviewed
Aug 12, 2024
| if (!isNaN(viewBoxWidth) && !isNaN(viewBoxHeight)) { | ||
| if (width !== undefined && height === undefined) { | ||
| height = isWidthPercentage | ||
| ? `${(parseFloat(width) * viewBoxHeight) / viewBoxWidth}%` |
There was a problem hiding this comment.
I don't think the % value is being calculated correctly. For instance, if the screen width is 200 and the height is 600, and we have an SVG with a viewBox proportion of 1 (such as 100/100) and a width set to 50%, the height should match the width. However, in this implementation, the height ends up being 50% of the screen height, which is 300, rather than the expected 100.
…nto @bohdanprog/calculate-width-and-height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2138
We want to calculate width and height based on the aspect ratio defined by the
viewBox.Test Plan
We can easily test my solution when we run the
Test2138Compatibility