Support for dominantBaseline property

[SaeedZhiany]

In react svg, we have dominantBaseline property for Text component. is there any plan in future to add support of this property?

[msand]

We already have support for alignment-baseline and baseline-shift, I'm not completely sure I understand all of what implementing support for dominant-baseline entails. Do you have any example content?
https://www.w3.org/TR/SVG11/text.html#BaselineAlignmentProperties
https://www.w3.org/TR/SVG11/text.html#DominantBaselineProperty
https://www.w3.org/TR/SVG11/text.html#AlignmentBaselineProperty
https://www.w3.org/TR/SVG11/text.html#BaselineShiftProperty

https://svgwg.org/svg2-draft/text.html#DominantBaselineProperty
https://svgwg.org/svg2-draft/text.html#AlignmentBaselineProperty
https://svgwg.org/svg2-draft/text.html#BaselineShiftProperty

https://www.w3.org/TR/css-inline-3/#line-height
https://www.w3.org/TR/css-inline-3/#propdef-dominant-baseline
https://www.w3.org/TR/css-inline-3/#propdef-alignment-baseline
https://www.w3.org/TR/css-inline-3/#propdef-baseline-shift

https://www.w3.org/TR/CSS2/visudet.html#line-height
https://www.w3.org/TR/CSS2/visudet.html#vertical-align

https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#baseline
https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#AlignmentBaselineType
https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#BaselineAlignmentOverview
https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#dominant-baseline
https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#alignment-baseline
https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#alignment-adjust
https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#baseline-shift
https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#vertical-align

https://www.w3.org/TR/2002/WD-css3-linebox-20020515/#BaselineUsage

w3c/csswg-drafts#859

The time I'm currently able to put into working on this library is relatively limited for the time being. I'm focusing more on fixing bugs and implementing features which otherwise aren't possible. Seems the use case for dominant-baseline can be achieved by setting alignment-baseline and baseline-shift per tspan element which needs it, and should mostly be an issue when combining several fonts and font-sizes. Or have I misunderstood the use of the attribute? (fully possible, haven't seen it in use yet)

If you're interested in having support for this, the relevant parts of the logic is in (iOS)
https://github.com/react-native-community/react-native-svg/blob/6df918356b5df6cde98b78560b3e889199bd67a4/ios/Text/RNSVGTSpan.m#L479-L671
and (Android)
https://github.com/react-native-community/react-native-svg/blob/6df918356b5df6cde98b78560b3e889199bd67a4/android/src/main/java/com/horcrux/svg/TSpanView.java#L479-L674

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and I will leave this open.

[SaeedZhiany]

@msand

any progress on this?

[msand]

I haven't looked into text rendering for quite some time, there's certainly several useful things to do, e.g. making it a two pass measure / layout and add support for shape-inside, which would be quite useful to have as well, both of those and also this issue would have use for the svg 2.0 text layout algorithm

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and I will leave this open.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and I will leave this open.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and I will leave this open.