Initialiser for `StarknetTypedData` ignores the `message` parameter

[mluisbrown]

In the following initialiser for StarknetTypedData the message parameter is ignored:

starknet.swift/Sources/Starknet/Data/TypedData/StarknetTypedData.swift

Line 117 in aee6cec

guard let domainData = domain.data(using: .utf8), let messageData = domain.data(using: .utf8) else {

    public init(types: [String: [any TypeDeclaration]], primaryType: String, domain: String, message _: String) throws {
        guard let domainData = domain.data(using: .utf8), let messageData = domain.data(using: .utf8) else {
            throw StarknetTypedDataError.decodingError
        }

        guard let domain = try? JSONDecoder().decode(Domain.self, from: domainData),
              let message = try? JSONDecoder().decode([String: Element].self, from: messageData)
        else {
            throw StarknetTypedDataError.decodingError
        }

        try self.init(types: types, primaryType: primaryType, domain: domain, message: message)
    }

messageData is created from domain instead of from message so this initialiser will never work.

[franciszekjob]

Hey @mluisbrown, thanks for report - how urgent for you is the fix?

[mluisbrown]

Hey @franciszekjob ,
It's not urgent for us, as a workaround we are creating a StarknetTypedData from a JSON string.