chore: Fix clippy warnings

Author: swaroop-osec

cli/src/lib.rs

@@ -1051,7 +1051,7 @@ fn init(
             .stdout(Stdio::inherit())
             .stderr(Stdio::inherit())
             .output()
-            .map_err(|e| anyhow::format_err!("git init failed: {}", e.to_string()))?;
+            .map_err(|e| anyhow::format_err!("git init failed: {}", e))?;
         if !git_result.status.success() {
             eprintln!("Failed to automatically initialize a new git repository");
         }
@@ -1069,14 +1069,14 @@ fn install_node_modules(cmd: &str) -> Result<std::process::Output> {
             .stdout(Stdio::inherit())
             .stderr(Stdio::inherit())
             .output()
-            .map_err(|e| anyhow::format_err!("{} install failed: {}", cmd, e.to_string()))
+            .map_err(|e| anyhow::format_err!("{} install failed: {}", cmd, e))
     } else {
         std::process::Command::new(cmd)
             .arg("install")
             .stdout(Stdio::inherit())
             .stderr(Stdio::inherit())
             .output()
-            .map_err(|e| anyhow::format_err!("{} install failed: {}", cmd, e.to_string()))
+            .map_err(|e| anyhow::format_err!("{} install failed: {}", cmd, e))
     }
 }
 
@@ -1262,7 +1262,7 @@ fn expand_program(
         .args(cargo_args)
         .stderr(Stdio::inherit())
         .output()
-        .map_err(|e| anyhow::format_err!("{}", e.to_string()))?;
+        .map_err(|e| anyhow::format_err!("{}", e))?;
     if !exit.status.success() {
         eprintln!("'anchor expand' failed. Perhaps you have not installed 'cargo-expand'? https://github.com/dtolnay/cargo-expand#installation");
         std::process::exit(exit.status.code().unwrap_or(1));
@@ -1271,7 +1271,7 @@ fn expand_program(
     let version = cargo.version();
     let time = chrono::Utc::now().to_string().replace(' ', "_");
     let file_path = program_expansions_path.join(format!("{package_name}-{version}-{time}.rs"));
-    fs::write(&file_path, &exit.stdout).map_err(|e| anyhow::format_err!("{}", e.to_string()))?;
+    fs::write(&file_path, &exit.stdout).map_err(|e| anyhow::format_err!("{}", e))?;
 
     println!(
         "Expanded {} into file {}\n",
@@ -1612,7 +1612,7 @@ fn docker_build(
         .stdout(Stdio::inherit())
         .stderr(Stdio::inherit())
         .output()
-        .map_err(|e| anyhow::format_err!("Docker build failed: {}", e.to_string()))?;
+        .map_err(|e| anyhow::format_err!("Docker build failed: {}", e))?;
     if !exit.status.success() {
         return Err(anyhow!("Failed to build program"));
     }
@@ -1736,7 +1736,7 @@ fn docker_build_bpf(
             Some(f) => f.into(),
         })
         .output()
-        .map_err(|e| anyhow::format_err!("Docker build failed: {}", e.to_string()))?;
+        .map_err(|e| anyhow::format_err!("Docker build failed: {}", e))?;
     if !exit.status.success() {
         return Err(anyhow!("Failed to build program"));
     }
@@ -1768,7 +1768,7 @@ fn docker_build_bpf(
         .stdout(Stdio::inherit())
         .stderr(Stdio::inherit())
         .output()
-        .map_err(|e| anyhow::format_err!("{}", e.to_string()))?;
+        .map_err(|e| anyhow::format_err!("{}", e))?;
     if !exit.status.success() {
         Err(anyhow!(
             "Failed to copy binary out of docker. Is the target directory set correctly?"
@@ -1790,7 +1790,7 @@ fn docker_cleanup(container_name: &str, target_dir: &Path) -> Result<()> {
         .stdout(Stdio::inherit())
         .stderr(Stdio::inherit())
         .output()
-        .map_err(|e| anyhow::format_err!("{}", e.to_string()))?;
+        .map_err(|e| anyhow::format_err!("{}", e))?;
     if !exit.status.success() {
         println!("Unable to remove the docker container");
         std::process::exit(exit.status.code().unwrap_or(1));
@@ -1829,7 +1829,7 @@ fn _build_rust_cwd(
         .stdout(Stdio::inherit())
         .stderr(Stdio::inherit())
         .output()
-        .map_err(|e| anyhow::format_err!("{}", e.to_string()))?;
+        .map_err(|e| anyhow::format_err!("{}", e))?;
     if !exit.status.success() {
         std::process::exit(exit.status.code().unwrap_or(1));
     }
@@ -4094,7 +4094,7 @@ fn shell(cfg_override: &ConfigOverride) -> Result<()> {
             .stdout(Stdio::inherit())
             .stderr(Stdio::inherit())
             .spawn()
-            .map_err(|e| anyhow::format_err!("{}", e.to_string()))?;
+            .map_err(|e| anyhow::format_err!("{}", e))?;
 
         if !child.wait()?.success() {
             println!("Error running node shell");
@@ -4340,7 +4340,7 @@ fn get_node_version() -> Result<Version> {
         .arg("--version")
         .stderr(Stdio::inherit())
         .output()
-        .map_err(|e| anyhow::format_err!("node failed: {}", e.to_string()))?;
+        .map_err(|e| anyhow::format_err!("node failed: {}", e))?;
     let output = std::str::from_utf8(&node_version.stdout)?
         .strip_prefix('v')
         .unwrap()

cli/src/rust_template.rs

@@ -705,7 +705,7 @@ impl TestTemplate {
                     .arg("tests")
                     .stderr(Stdio::inherit())
                     .output()
-                    .map_err(|e| anyhow::format_err!("{}", e.to_string()))?;
+                    .map_err(|e| anyhow::format_err!("{}", e))?;
                 if !exit.status.success() {
                     eprintln!("'cargo new --lib tests' failed");
                     std::process::exit(exit.status.code().unwrap_or(1));

lang/syn/src/parser/context.rs

@@ -77,7 +77,7 @@ impl CrateContext {
                         ctx.file.canonicalize().unwrap().display(),
                         span.start().line,
                         span.start().column,
-                        ident.to_string()
+                        ident
                     ));
                 };
             }