fix: missing solana-signer extration from solana-sdk (#3995)

* refactor: extract solana-signer from solana-sdk in anchor-client and anchor-cli

* Revert "Revert "feat: tests""

This reverts commit c8cf603.

* requested changes

* fix: docs

* fix: cargo.toml

* fix: ci tests

* fix: ci tests

* add dependency

* add dependency

* add dependency

* fix: remove from workspace

---------

Co-authored-by: 0xPratik <sariapratik@gmail.com>
Co-authored-by: Akash Thota <your.email@example.com>
Co-authored-by: Akash Thota <0x4ka5h@gmail.com>

Author: 4 people

Cargo.lock

@@ -16,5 +16,8 @@ resolver = "2"
 [profile.release]
 lto = true
 
+[workspace.dependencies]
+solana-signer = "2"
+
 [profile.release.package.anchor-cli]
 codegen-units = 1

Cargo.toml

@@ -40,6 +40,7 @@ solana-cli-config = "2"
 solana-faucet = "2"
 solana-rpc-client = "2"
 solana-sdk = "2"
+solana-signer.workspace = true
 syn = { version = "1.0.60", features = ["full", "extra-traits"] }
 tar = "0.4.35"
 toml = "0.7.6"

cli/Cargo.toml

@@ -12,7 +12,8 @@ use serde::{Deserialize, Deserializer, Serialize, Serializer};
 use solana_cli_config::{Config as SolanaConfig, CONFIG_FILE};
 use solana_sdk::clock::Slot;
 use solana_sdk::pubkey::Pubkey;
-use solana_sdk::signature::{Keypair, Signer};
+use solana_sdk::signature::Keypair;
+use solana_signer::Signer;
 use std::collections::{BTreeMap, HashMap};
 use std::convert::TryFrom;
 use std::fs::{self, File};

cli/src/config.rs

@@ -28,9 +28,8 @@ use solana_sdk::compute_budget::ComputeBudgetInstruction;
 use solana_sdk::instruction::{AccountMeta, Instruction};
 use solana_sdk::pubkey::Pubkey;
 use solana_sdk::signature::Keypair;
-use solana_sdk::signature::Signer;
-use solana_sdk::signer::EncodableKey;
 use solana_sdk::transaction::Transaction;
+use solana_signer::{EncodableKey, Signer};
 use std::collections::BTreeMap;
 use std::collections::HashMap;
 use std::collections::HashSet;

cli/src/lib.rs

@@ -8,8 +8,8 @@ use heck::{ToLowerCamelCase, ToPascalCase, ToSnakeCase};
 use solana_sdk::{
     pubkey::Pubkey,
     signature::{read_keypair_file, write_keypair_file, Keypair},
-    signer::Signer,
 };
+use solana_signer::Signer;
 use std::{
     fmt::Write as _,
     fs::{self, File},

cli/src/rust_template.rs

@@ -27,6 +27,7 @@ solana-pubsub-client = "2"
 solana-rpc-client = "2"
 solana-rpc-client-api = "2"
 solana-sdk = "2"
+solana-signer.workspace = true
 thiserror = "1"
 tokio = { version = "1", features = ["rt", "sync"] }
 url = "2"

client/Cargo.toml

@@ -21,3 +21,4 @@ clap = { version = "4.2.4", features = ["derive"] }
 shellexpand = "2.1.0"
 solana-sdk = "2"
 tokio = { version = "1", features = ["full"] }
+solana-signer = "2"

client/example/Cargo.toml

@@ -1,12 +1,13 @@
 use anchor_client::solana_sdk::pubkey::Pubkey;
-use anchor_client::solana_sdk::signature::{Keypair, Signer};
+use anchor_client::solana_sdk::signature::Keypair;
 use anchor_client::solana_sdk::system_instruction;
 use anchor_client::{Client, Cluster};
 use anyhow::Result;
 use clap::Parser;
 use solana_sdk::commitment_config::CommitmentConfig;
 use solana_sdk::signature::read_keypair_file;
 use solana_sdk::system_program;
+use solana_signer::Signer;
 // The `accounts` and `instructions` modules are generated by the framework.
 use basic_2::accounts as basic_2_accounts;
 use basic_2::instruction as basic_2_instruction;

client/example/src/blocking.rs

@@ -1,12 +1,13 @@
 use anchor_client::solana_sdk::pubkey::Pubkey;
-use anchor_client::solana_sdk::signature::{Keypair, Signer};
+use anchor_client::solana_sdk::signature::Keypair;
 use anchor_client::solana_sdk::system_instruction;
 use anchor_client::{Client, Cluster};
 use anyhow::Result;
 use clap::Parser;
 use solana_sdk::commitment_config::CommitmentConfig;
 use solana_sdk::signature::read_keypair_file;
 use solana_sdk::system_program;
+use solana_signer::Signer;
 // The `accounts` and `instructions` modules are generated by the framework.
 use basic_2::accounts as basic_2_accounts;
 use basic_2::instruction as basic_2_instruction;