fix(sdk): allow signer freeze authorities without accounts (#62)

Author: GuiBibeau

packages/sdk/src/__tests__/test-utils.ts

@@ -22,7 +22,7 @@ export function createMockRpc(): Rpc<any> {
                     },
                 }),
         }),
-        getAccountInfo: (address: Address, opts: { encoding: 'jsonParsed' | 'base64' }) => ({
+        getAccountInfo: (address: Address, opts?: { encoding?: 'jsonParsed' | 'base64' }) => ({
             send: async () => {
                 const entry = accountInfoRegistry.get(address as string);
                 if (!entry) return { value: null };
@@ -35,7 +35,7 @@ export function createMockRpc(): Rpc<any> {
                 if (opts?.encoding === 'base64') {
                     return entry.base64 ? { value: { data: [entry.base64, 'base64'], owner } } : { value: null };
                 }
-                return { value: null };
+                return { value: { owner } };
             },
         }),
         getProgramAccounts: (programAddress: Address, _opts?: any) => ({
@@ -168,3 +168,11 @@ export function seedProgramAccountBase64(
     arr.push(entry);
     reg.programAccountsRegistry.set(programAddress as string, arr);
 }
+
+/**
+ * Seeds a plain account owner for getAccountInfo calls that only need owner metadata.
+ */
+export function seedAccountOwner(rpc: Rpc<any>, account: Address, owner: Address): void {
+    const reg = (rpc as any).__registry;
+    reg.accountInfoRegistry.set(account as string, { owner });
+}

packages/sdk/src/transaction-util.test.ts

@@ -0,0 +1,45 @@
+import type { Address, Rpc, SolanaRpcApi } from '@solana/kit';
+import { createMockRpc, resetMockRpc, seedAccountOwner, seedMintDetails, TEST_AUTHORITY } from './__tests__/test-utils';
+import { TOKEN_ACL_PROGRAM_ID } from './token-acl/utils';
+import { getMintDetails } from './transaction-util';
+
+describe('getMintDetails', () => {
+    let rpc: Rpc<SolanaRpcApi>;
+    const mint = 'Mint777777777777777777777777777777777777777' as Address;
+    const signerFreezeAuthority = TEST_AUTHORITY;
+
+    beforeEach(() => {
+        rpc = createMockRpc();
+        resetMockRpc(rpc);
+    });
+
+    test('does not throw when a signer freeze authority has no on-chain account', async () => {
+        seedMintDetails(rpc, {
+            address: mint,
+            decimals: 6,
+            freezeAuthority: signerFreezeAuthority,
+            mintAuthority: signerFreezeAuthority,
+        });
+
+        await expect(getMintDetails(rpc, mint)).resolves.toMatchObject({
+            decimals: 6,
+            freezeAuthority: signerFreezeAuthority,
+            mintAuthority: signerFreezeAuthority,
+            usesTokenAcl: false,
+        });
+    });
+
+    test('marks usesTokenAcl when the freeze authority account is owned by the Token ACL program', async () => {
+        seedMintDetails(rpc, {
+            address: mint,
+            decimals: 6,
+            freezeAuthority: signerFreezeAuthority,
+        });
+        seedAccountOwner(rpc, signerFreezeAuthority, TOKEN_ACL_PROGRAM_ID);
+
+        await expect(getMintDetails(rpc, mint)).resolves.toMatchObject({
+            freezeAuthority: signerFreezeAuthority,
+            usesTokenAcl: true,
+        });
+    });
+});

packages/sdk/src/transaction-util.ts

@@ -216,9 +216,6 @@ export async function getMintDetails(rpc: Rpc<SolanaRpcApi>, mint: Address, comm
         const freezeAuthorityAccountInfo = await rpc
             .getAccountInfo(address(mintInfo.freezeAuthority), { commitment })
             .send();
-        if (!freezeAuthorityAccountInfo.value) {
-            throw new Error(`Freeze authority account ${mintInfo.freezeAuthority} not found`);
-        }
         usesTokenAcl = freezeAuthorityAccountInfo.value?.owner === TOKEN_ACL_PROGRAM_ID;
     }