Skip to content

Commit c9ef31e

Browse files
authored
temp: Disable GCP integration tests until have the proper secrets in the CI (#36)
Co-authored-by: Jo D <dev-jodee@users.noreply.github.com>
1 parent 961994f commit c9ef31e

File tree

2 files changed

+31
-19
lines changed

2 files changed

+31
-19
lines changed

.github/workflows/ci.yml

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@ jobs:
1515
strategy:
1616
matrix:
1717
sdk_version: [v2, v3]
18-
backend: [memory, vault, privy, turnkey, aws_kms, fireblocks, gcp_kms, all]
18+
# TODO: Re-enable gcp_kms when we have GCP KMS access configured in CI
19+
# backend: [memory, vault, privy, turnkey, aws_kms, fireblocks, gcp_kms, all]
20+
backend: [memory, vault, privy, turnkey, aws_kms, fireblocks, all]
1921
steps:
2022
- uses: actions/checkout@v4
2123
- uses: dtolnay/rust-toolchain@stable
@@ -37,15 +39,18 @@ jobs:
3739
strategy:
3840
matrix:
3941
sdk_version: [v2, v3]
40-
test: [test_privy_integration, test_turnkey_integration, test_fireblocks_integration, test_gcp_kms_integration]
42+
# TODO: Re-enable test_gcp_kms_integration when we have GCP KMS access configured in CI
43+
# test: [test_privy_integration, test_turnkey_integration, test_fireblocks_integration, test_gcp_kms_integration]
44+
test: [test_privy_integration, test_turnkey_integration, test_fireblocks_integration]
4145
steps:
4246
- uses: actions/checkout@v4
4347
- uses: dtolnay/rust-toolchain@stable
44-
- name: Setup GCP credentials
45-
if: matrix.test == 'test_gcp_kms_integration'
46-
uses: google-github-actions/auth@v2
47-
with:
48-
credentials_json: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY }}
48+
# TODO: Re-enable when we have GCP KMS access configured in CI
49+
# - name: Setup GCP credentials
50+
# if: matrix.test == 'test_gcp_kms_integration'
51+
# uses: google-github-actions/auth@v2
52+
# with:
53+
# credentials_json: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY }}
4954
- name: Run ${{ matrix.test }} with SDK ${{ matrix.sdk_version }}
5055
env:
5156
PRIVY_APP_ID: ${{ secrets.PRIVY_APP_ID }}
@@ -59,8 +64,9 @@ jobs:
5964
FIREBLOCKS_API_KEY: ${{ secrets.FIREBLOCKS_API_KEY }}
6065
FIREBLOCKS_PRIVATE_KEY_PEM: ${{ secrets.FIREBLOCKS_PRIVATE_KEY_PEM }}
6166
FIREBLOCKS_VAULT_ACCOUNT_ID: ${{ secrets.FIREBLOCKS_VAULT_ACCOUNT_ID }}
62-
GCP_KMS_KEY_NAME: ${{ secrets.GCP_KMS_KEY_NAME }}
63-
GCP_KMS_SIGNER_PUBKEY: ${{ secrets.GCP_KMS_SIGNER_PUBKEY }}
67+
# TODO: Re-enable when we have GCP KMS access configured in CI
68+
# GCP_KMS_KEY_NAME: ${{ secrets.GCP_KMS_KEY_NAME }}
69+
# GCP_KMS_SIGNER_PUBKEY: ${{ secrets.GCP_KMS_SIGNER_PUBKEY }}
6470
SOLANA_RPC_URL: https://api.devnet.solana.com
6571
run: |
6672
if [ "${{ matrix.sdk_version }}" = "v2" ]; then

.github/workflows/typescript-ci.yml

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ jobs:
1414
working-directory: typescript
1515
strategy:
1616
matrix:
17-
package: [vault, privy, turnkey, fireblocks, gcp-kms]
17+
# TODO: Re-enable gcp-kms when we have GCP KMS access configured in CI
18+
# package: [vault, privy, turnkey, fireblocks, gcp-kms]
19+
package: [vault, privy, turnkey, fireblocks]
1820
steps:
1921
- uses: actions/checkout@v4
2022
- uses: actions/setup-node@v4
@@ -37,7 +39,9 @@ jobs:
3739
working-directory: typescript
3840
strategy:
3941
matrix:
40-
package: [privy, turnkey, fireblocks, gcp-kms]
42+
# TODO: Re-enable gcp-kms when we have GCP KMS access configured in CI
43+
# package: [privy, turnkey, fireblocks, gcp-kms]
44+
package: [privy, turnkey, fireblocks]
4145
steps:
4246
- uses: actions/checkout@v4
4347
- uses: actions/setup-node@v4
@@ -48,11 +52,12 @@ jobs:
4852
version: 10.14.0
4953
- name: Install dependencies
5054
run: pnpm install
51-
- name: Setup GCP credentials
52-
if: matrix.package == 'gcp-kms'
53-
uses: google-github-actions/auth@v2
54-
with:
55-
credentials_json: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY }}
55+
# TODO: Re-enable when we have GCP KMS access configured in CI
56+
# - name: Setup GCP credentials
57+
# if: matrix.package == 'gcp-kms'
58+
# uses: google-github-actions/auth@v2
59+
# with:
60+
# credentials_json: ${{ secrets.GCP_SERVICE_ACCOUNT_KEY }}
5661
- name: Build packages
5762
run: pnpm build
5863
- name: Run integration tests for @solana/keychain-${{ matrix.package }}
@@ -71,9 +76,10 @@ jobs:
7176
FIREBLOCKS_API_KEY: ${{ secrets.FIREBLOCKS_API_KEY }}
7277
FIREBLOCKS_PRIVATE_KEY_PEM: ${{ secrets.FIREBLOCKS_PRIVATE_KEY_PEM }}
7378
FIREBLOCKS_VAULT_ACCOUNT_ID: ${{ secrets.FIREBLOCKS_VAULT_ACCOUNT_ID }}
74-
# GCP KMS
75-
GCP_KMS_KEY_NAME: ${{ secrets.GCP_KMS_KEY_NAME }}
76-
GCP_KMS_SIGNER_PUBKEY: ${{ secrets.GCP_KMS_SIGNER_PUBKEY }}
79+
# TODO: Re-enable when we have GCP KMS access configured in CI
80+
# # GCP KMS
81+
# GCP_KMS_KEY_NAME: ${{ secrets.GCP_KMS_KEY_NAME }}
82+
# GCP_KMS_SIGNER_PUBKEY: ${{ secrets.GCP_KMS_SIGNER_PUBKEY }}
7783
run: pnpm -F @solana/keychain-${{ matrix.package }} run test:integration
7884

7985
typescript-lint:

0 commit comments

Comments
 (0)