v1.18: Deprecate RpcRequest::GetStakeActivation (backport of #2005) (#2012)

Deprecate RpcRequest::GetStakeActivation (#2005)

* Correct deprecation note

* Deprecate rpc-client-api request

(cherry picked from commit 0deb6fb)

Co-authored-by: Tyera <[email protected]>

Author: 2 people

rpc-client-api/src/request.rs

@@ -94,6 +94,10 @@ pub enum RpcRequest {
     GetStorageTurn,
     GetStorageTurnRate,
     GetSlotsPerSegment,
+    #[deprecated(
+        since = "1.18.18",
+        note = "Do not use; getStakeActivation is not supported by the JSON-RPC server."
+    )]
     GetStakeActivation,
     GetStakeMinimumDelegation,
     GetStoragePubkeysForSlot,

rpc-client/src/nonblocking/rpc_client.rs

@@ -2152,10 +2152,11 @@ impl RpcClient {
     /// ```
     #[deprecated(
         since = "1.18.18",
-        note = "Do not use; getStakeActivation is deprecated on the JSON-RPC server. Please use \
-                the stake account and StakeHistory sysvar to call \
+        note = "Do not use; getStakeActivation is not supported by the JSON-RPC server. Please \
+                use the stake account and StakeHistory sysvar to call \
                 `Delegation::stake_activating_and_deactivating()` instead"
     )]
+    #[allow(deprecated)]
     pub async fn get_stake_activation(
         &self,
         stake_account: Pubkey,

rpc-client/src/rpc_client.rs

@@ -1790,8 +1790,8 @@ impl RpcClient {
     /// ```
     #[deprecated(
         since = "1.18.18",
-        note = "Do not use; getStakeActivation is deprecated on the JSON-RPC server. Please use \
-                the stake account and StakeHistory sysvar to call \
+        note = "Do not use; getStakeActivation is not supported by the JSON-RPC server. Please \
+                use the stake account and StakeHistory sysvar to call \
                 `Delegation::stake_activating_and_deactivating()` instead"
     )]
     #[allow(deprecated)]