Use Codama v1.0.0 #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
approved these changes
Oct 10, 2024
| TProgramAddress extends Address = typeof SOLANA_CONFIG_PROGRAM_ADDRESS, | ||
| >( | ||
| input: StoreInput<TAccountConfigAccount>, | ||
| config?: { programAddress?: TProgramAddress } |
Contributor
There was a problem hiding this comment.
Interesting, so one could use the config program client against a different config program (configurable program ID)?
Member
Author
There was a problem hiding this comment.
Yes! This is a late addition from @mcintyre94 (See PR). For instance, this allows someone to use the SPL Token JS client for the Token 2022 program (if someone was taking bloody ages to release a Token 2022 client for example 👀).
| "standard": "kinobi", | ||
| "version": "0.19.0" | ||
| "standard": "codama", | ||
| "version": "1.0.0" |
Member
Author
There was a problem hiding this comment.
Major version indeed! It's showtime. 🌟
Comment on lines
+98
to
+101
| "definedTypes": [ | ||
| { | ||
| "kind": "definedTypeNode", | ||
| "name": "configKeys", |
Contributor
There was a problem hiding this comment.
Nice. I like how this is an IDL-defined type now, instead of in-lined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See codama-idl/codama#234