Skip to content

Conversation

@buffalojoec
Copy link
Contributor

Problem

We have publish scripts for the clients, but no such script for the program.

Summary of Changes

Add publish scripts for the program! Taken directly from the Rust client publishing pipeline.

@buffalojoec buffalojoec marked this pull request as ready for review November 13, 2024 04:03
@buffalojoec
Copy link
Contributor Author

Note I'll have to revert #22 and use the new pipeline to publish the release. The crate was never published.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I think having multiple copies of the same scripts (mostly) is pretty error-prone -- can we parametrize the inputs and just reuse the same script?

The SPL version of the publish script takes a path to the package to publish so we don't need a script for every package in the repo: https://github.com/solana-labs/solana-program-library/blob/master/.github/workflows/publish-rust.yml

@buffalojoec
Copy link
Contributor Author

@joncinque Agreed, let's move to shared scripts. @lorisleiva said he and @febo are working on this over in System Interface land, so whenever that's all done we can export those changes here and get a shared script for all of these operations for Rust crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants