implement mollusk conformance testing #42
Merged
+34
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
mollusk-conformance
branch
from
5ff41c0 to
ee0dce7
Compare
Contributor
Author
|
This PR is ready for review. It only fails because it needs the next Mollusk CLI version after anza-xyz/mollusk#93 lands. |
buffalojoec
force-pushed
the
mollusk-conformance
branch
from
ee0dce7 to
689e1c9
Compare
joncinque
approved these changes
Mar 13, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Wow, this looks much better and simpler!
joncinque
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply replaces FD's conformance testing with a similar mechanism using Mollusk.
Firedancer drops support for a program's test-vectors after that program has been migrated to BPF. As a result, this introduces a self-contained conformance test against the program version running on mainnet-beta with the fixtures generated from the program's test suite.
Optionally, we can grab their latest collection of program test-vectors and include them in here, but since they are specifically for the builtin program, I felt like it wasn't the most relevant thing to do. Let me know if anyone else feels different.