program: implement stricter instruction processors

Author: 2501babe

interface/src/instruction.rs

@@ -29,6 +29,10 @@ const RENT_ID: Pubkey = Pubkey::from_str_const("SysvarRent1111111111111111111111
 const STAKE_HISTORY_ID: Pubkey =
     Pubkey::from_str_const("SysvarStakeHistory1111111111111111111111111");
 
+// NOTE the stake program is in the process of removing dependence on all sysvars
+// once this version of the program is live on all clusters, we can remove them here
+// namely, from all doc comments in `StakeInstruction` and in all instruction builders
+// we may also remove all use of and reference to the stake config account
 #[cfg_attr(
     feature = "serde",
     derive(serde_derive::Deserialize, serde_derive::Serialize)

program/Cargo.toml

@@ -21,6 +21,7 @@ solana-pubkey = "3.0.0"
 solana-rent = "3.0.0"
 solana-stake-interface = { version = "2", features = ["bincode", "borsh", "sysvar"] }
 solana-sysvar = "3.0.0"
+solana-sysvar-id = "3.0.0"
 solana-vote-interface = { version = "4.0.4", features = ["bincode"] }
 
 [dev-dependencies]
@@ -43,7 +44,6 @@ solana-signature = "3.0.0"
 solana-signer = "3.0.0"
 solana-svm-log-collector = "3.0.0"
 solana-system-interface = { version = "2.0.0", features = ["bincode"] }
-solana-sysvar-id = "3.0.0"
 solana-transaction = "3.0.0"
 test-case = "3.3.1"