Convert warmup/cooldown rates to integers #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
commented
Oct 31, 2025
Comment on lines
-102
to
-106
| #[test] | ||
| fn assert_warmup_cooldown_rate() { | ||
| assert_eq!(warmup_cooldown_rate(0, Some(0)), NEW_WARMUP_COOLDOWN_RATE); | ||
| } |
Member
Author
There was a problem hiding this comment.
Coverage in interface/src/warmup_cooldown_allowance.rs
grod220
commented
Oct 31, 2025
joncinque
reviewed
Nov 3, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good overall! Mostly nits and a few suggestions
| /// | ||
| /// This function allocates a share of the cluster's per-epoch deactivation allowance | ||
| /// proportional to the account's share of the previous epoch's total deactivating stake. | ||
| pub fn calculate_cooldown_allowance( |
Contributor
There was a problem hiding this comment.
nit: just from a naming convention, this should be called calculate_deactivation_allowance to go with calculate_activation_allowance, ie let's be consistent with activation / deactivation or warmup / cooldown
grod220
force-pushed
the
float-to-fixed-point
branch
from
009dc87 to
9c0ba5c
Compare
grod220
commented
Nov 18, 2025
Comment on lines
+701
to
+702
|
|
||
| pub fn stake_activating_and_deactivating<T: StakeHistoryGetEntry>( |
Member
Author
There was a problem hiding this comment.
Functions below are copy/pasting of the legacy versions with changes related to:
- Usage of new
calculate_*_allowance()helpers - Additional code comments for context
- Variable name changes for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements SIMD-0391, replacing all floating-point (
f64) arithmetic in the Stake Program's warmup and cooldown logic with a fixed-point implementation using integer arithmetic. See SIMD for background rationale.What's new?
warmup_cooldown_allowancemoduleDelegationstruct has been updated to maintain backward compatibility with on-chain data. Thewarmup_cooldown_rate: f64field is replaced with_reserved: [u8; 8](preserves memory layout)