tests: Mollusk InstructionConfig, Initialize tests (1/9) #161
+587
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustopian
force-pushed
the
mollusk-1-initialize
branch
from
2ab4655 to
c2acd67
Compare
rustopian
commented
Nov 4, 2025
Comment on lines
+28
to
+33
| pub struct StakeTestContext { | ||
| pub mollusk: Mollusk, | ||
| pub rent_exempt_reserve: u64, | ||
| pub staker: Pubkey, | ||
| pub withdrawer: Pubkey, | ||
| } |
Author
There was a problem hiding this comment.
This is extended in next PR, when the instructions being tested require it
rustopian
commented
Nov 4, 2025
Comment on lines
+20
to
+28
| pub fn create_uninitialized_account(self) -> AccountSharedData { | ||
| AccountSharedData::new_data_with_space( | ||
| STAKE_RENT_EXEMPTION, | ||
| &StakeStateV2::Uninitialized, | ||
| StakeStateV2::size_of(), | ||
| &id(), | ||
| ) | ||
| .unwrap() | ||
| } |
Author
There was a problem hiding this comment.
Full lifecycle management is in next PR (Initialize tests don't need it)
rustopian
commented
Nov 4, 2025
| _ => &default_checks, | ||
| }; | ||
|
|
||
| let test_missing_signers = self.test_missing_signers.unwrap_or(true); |
Author
There was a problem hiding this comment.
Assumed true, so tests must explicitly opt out with .test_missing_signers(false)
Meant to prevent a test from forgetting to test missing signers.
rustopian
commented
Nov 4, 2025
| @@ -0,0 +1,7 @@ | |||
| #![allow(clippy::arithmetic_side_effects)] | |||
| #![allow(dead_code)] | |||
Author
There was a problem hiding this comment.
Since test banks compile individually, we'll soon otherwise get dead_code warnings for any helpers which are not used in every single one.
Author
|
Taking back to draft pending a few small updates based on discussions in Rome |
rustopian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of https://github.com/orgs/solana-program/projects/8.
Problem
solana-program-testis on its slow way out.Solution
Convert these tests to Mollusk, including simple but perfectly equivalent stake tracking.
This part migrates
InitializeandInitializeCheckedtests, and only includes helper utilities relevant to these tests. (Some lifecycle management and all stake history management is not yet required and is saved for later PRs.)Included:
StakeTestContextandInstructionConfigbuilder patternInitializetests to mollusk, out of program_test.rs to initialize.rsStakeLifecyclemanagement to a helper filetest_caseis used to run allInitializetests againstInitializeCheckedas welltest_missing_signersunless this is explicitly set tofalseThis does NOT migrate tests from the newer stake_instruction.rs, which already uses Mollusk.