From 5c09c765b58312b0b02f7b3bb8ae3601ecbaa63c Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 09:47:56 +0000 Subject: [PATCH 01/10] InstructionConfig, migrate Initialize tests --- program/tests/helpers/context.rs | 112 ++++++++ program/tests/helpers/instruction_builders.rs | 105 +++++++ program/tests/helpers/lifecycle.rs | 29 ++ program/tests/helpers/mod.rs | 7 + program/tests/helpers/utils.rs | 65 +++++ program/tests/initialize.rs | 261 ++++++++++++++++++ program/tests/program_test.rs | 121 -------- 7 files changed, 579 insertions(+), 121 deletions(-) create mode 100644 program/tests/helpers/context.rs create mode 100644 program/tests/helpers/instruction_builders.rs create mode 100644 program/tests/helpers/lifecycle.rs create mode 100644 program/tests/helpers/mod.rs create mode 100644 program/tests/helpers/utils.rs create mode 100644 program/tests/initialize.rs diff --git a/program/tests/helpers/context.rs b/program/tests/helpers/context.rs new file mode 100644 index 00000000..03713b4d --- /dev/null +++ b/program/tests/helpers/context.rs @@ -0,0 +1,112 @@ +use { + super::{ + instruction_builders::{InstructionConfig, InstructionExecution}, + lifecycle::StakeLifecycle, + utils::{add_sysvars, STAKE_RENT_EXEMPTION}, + }, + mollusk_svm::{result::Check, Mollusk}, + solana_account::AccountSharedData, + solana_instruction::Instruction, + solana_pubkey::Pubkey, + solana_stake_program::id, +}; + +/// Builder for creating stake accounts with customizable parameters +pub struct StakeAccountBuilder { + lifecycle: StakeLifecycle, +} + +impl StakeAccountBuilder { + pub fn build(self) -> (Pubkey, AccountSharedData) { + let stake_pubkey = Pubkey::new_unique(); + let account = self.lifecycle.create_uninitialized_account(); + (stake_pubkey, account) + } +} + +/// Consolidated test context for stake account tests +pub struct StakeTestContext { + pub mollusk: Mollusk, + pub rent_exempt_reserve: u64, + pub staker: Pubkey, + pub withdrawer: Pubkey, +} + +impl StakeTestContext { + /// Create a new test context with all standard setup + pub fn new() -> Self { + let mollusk = Mollusk::new(&id(), "solana_stake_program"); + + Self { + mollusk, + rent_exempt_reserve: STAKE_RENT_EXEMPTION, + staker: Pubkey::new_unique(), + withdrawer: Pubkey::new_unique(), + } + } + + /// Create a stake account builder for the specified lifecycle stage + /// + /// Example: + /// ``` + /// let (stake, account) = ctx + /// .stake_account(StakeLifecycle::Uninitialized) + /// .build(); + /// ``` + pub fn stake_account(&mut self, lifecycle: StakeLifecycle) -> StakeAccountBuilder { + StakeAccountBuilder { lifecycle } + } + + /// Process an instruction + pub fn process_with<'b, C: InstructionConfig>( + &self, + config: C, + ) -> InstructionExecution<'_, 'b> { + InstructionExecution::new( + config.build_instruction(self), + config.build_accounts(), + self, + ) + } + + /// Process an instruction with optional missing signer testing + pub(crate) fn process_instruction_maybe_test_signers( + &self, + instruction: &Instruction, + accounts: Vec<(Pubkey, AccountSharedData)>, + checks: &[Check], + test_missing_signers: bool, + ) -> mollusk_svm::result::InstructionResult { + if test_missing_signers { + use solana_program_error::ProgramError; + + // Test that removing each signer causes failure + for i in 0..instruction.accounts.len() { + if instruction.accounts[i].is_signer { + let mut modified_instruction = instruction.clone(); + modified_instruction.accounts[i].is_signer = false; + + let accounts_with_sysvars = + add_sysvars(&self.mollusk, &modified_instruction, accounts.clone()); + + self.mollusk.process_and_validate_instruction( + &modified_instruction, + &accounts_with_sysvars, + &[Check::err(ProgramError::MissingRequiredSignature)], + ); + } + } + } + + // Process with all signers present + let accounts_with_sysvars = add_sysvars(&self.mollusk, instruction, accounts); + self.mollusk + .process_and_validate_instruction(instruction, &accounts_with_sysvars, checks) + } +} + +impl Default for StakeTestContext { + fn default() -> Self { + Self::new() + } +} diff --git a/program/tests/helpers/instruction_builders.rs b/program/tests/helpers/instruction_builders.rs new file mode 100644 index 00000000..515a72a0 --- /dev/null +++ b/program/tests/helpers/instruction_builders.rs @@ -0,0 +1,105 @@ +use { + super::context::StakeTestContext, + mollusk_svm::result::Check, + solana_account::AccountSharedData, + solana_instruction::Instruction, + solana_pubkey::Pubkey, + solana_stake_interface::{ + instruction as ixn, + state::{Authorized, Lockup}, + }, +}; + +// Trait for instruction configuration that builds instruction and accounts +pub trait InstructionConfig { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction; + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)>; +} + +/// Execution builder with validation and signer testing +pub struct InstructionExecution<'a, 'b> { + instruction: Instruction, + accounts: Vec<(Pubkey, AccountSharedData)>, + ctx: &'a StakeTestContext, + checks: Option<&'b [Check<'b>]>, + test_missing_signers: Option, // `None` runs if `Check::success` +} + +impl<'b> InstructionExecution<'_, 'b> { + pub fn checks(mut self, checks: &'b [Check<'b>]) -> Self { + self.checks = Some(checks); + self + } + + pub fn test_missing_signers(mut self, test: bool) -> Self { + self.test_missing_signers = Some(test); + self + } + + /// Executes the instruction. If `checks` is `None` or empty, uses `Check::success()`. + /// Fail-safe default: when `test_missing_signers` is `None`, runs the missing-signers + /// test (`true`). Callers must explicitly opt out with `.test_missing_signers(false)`. + pub fn execute(self) -> mollusk_svm::result::InstructionResult { + let default_checks = [Check::success()]; + let checks = match self.checks { + Some(c) if !c.is_empty() => c, + _ => &default_checks, + }; + + let test_missing_signers = self.test_missing_signers.unwrap_or(true); + + self.ctx.process_instruction_maybe_test_signers( + &self.instruction, + self.accounts, + checks, + test_missing_signers, + ) + } +} + +impl<'a> InstructionExecution<'a, '_> { + pub(crate) fn new( + instruction: Instruction, + accounts: Vec<(Pubkey, AccountSharedData)>, + ctx: &'a StakeTestContext, + ) -> Self { + Self { + instruction, + accounts, + ctx, + checks: None, + test_missing_signers: None, + } + } +} + +pub struct InitializeConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + pub authorized: &'a Authorized, + pub lockup: &'a Lockup, +} + +impl InstructionConfig for InitializeConfig<'_> { + fn build_instruction(&self, _ctx: &StakeTestContext) -> Instruction { + ixn::initialize(self.stake.0, self.authorized, self.lockup) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![(*self.stake.0, self.stake.1.clone())] + } +} + +pub struct InitializeCheckedConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + pub authorized: &'a Authorized, +} + +impl InstructionConfig for InitializeCheckedConfig<'_> { + fn build_instruction(&self, _ctx: &StakeTestContext) -> Instruction { + ixn::initialize_checked(self.stake.0, self.authorized) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![(*self.stake.0, self.stake.1.clone())] + } +} diff --git a/program/tests/helpers/lifecycle.rs b/program/tests/helpers/lifecycle.rs new file mode 100644 index 00000000..74e55285 --- /dev/null +++ b/program/tests/helpers/lifecycle.rs @@ -0,0 +1,29 @@ +use { + super::utils::STAKE_RENT_EXEMPTION, solana_account::AccountSharedData, + solana_stake_interface::state::StakeStateV2, solana_stake_program::id, +}; + +/// Lifecycle states for stake accounts in tests +#[derive(Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord)] +pub enum StakeLifecycle { + Uninitialized = 0, + Initialized, + Activating, + Active, + Deactivating, + Deactive, + Closed, +} + +impl StakeLifecycle { + /// Create an uninitialized stake account + pub fn create_uninitialized_account(self) -> AccountSharedData { + AccountSharedData::new_data_with_space( + STAKE_RENT_EXEMPTION, + &StakeStateV2::Uninitialized, + StakeStateV2::size_of(), + &id(), + ) + .unwrap() + } +} diff --git a/program/tests/helpers/mod.rs b/program/tests/helpers/mod.rs new file mode 100644 index 00000000..ff09b000 --- /dev/null +++ b/program/tests/helpers/mod.rs @@ -0,0 +1,7 @@ +#![allow(clippy::arithmetic_side_effects)] +#![allow(dead_code)] + +pub mod context; +pub mod instruction_builders; +pub mod lifecycle; +pub mod utils; diff --git a/program/tests/helpers/utils.rs b/program/tests/helpers/utils.rs new file mode 100644 index 00000000..3bc0659b --- /dev/null +++ b/program/tests/helpers/utils.rs @@ -0,0 +1,65 @@ +use { + mollusk_svm::Mollusk, + solana_account::{Account, AccountSharedData}, + solana_instruction::Instruction, + solana_pubkey::Pubkey, + solana_rent::Rent, + solana_stake_interface::{stake_history::StakeHistory, state::StakeStateV2}, + solana_sysvar_id::SysvarId, + std::collections::HashMap, +}; + +// hardcoded for convenience +pub const STAKE_RENT_EXEMPTION: u64 = 2_282_880; + +#[test] +fn assert_stake_rent_exemption() { + assert_eq!( + Rent::default().minimum_balance(StakeStateV2::size_of()), + STAKE_RENT_EXEMPTION + ); +} + +/// Resolve all accounts for an instruction, including sysvars and instruction accounts +/// +/// This function re-serializes the stake history sysvar from mollusk.sysvars.stake_history +/// every time it's called, ensuring that any updates to the stake history are reflected in the accounts. +pub fn add_sysvars( + mollusk: &Mollusk, + instruction: &Instruction, + accounts: Vec<(Pubkey, AccountSharedData)>, +) -> Vec<(Pubkey, Account)> { + // Build a map of provided accounts + let mut account_map: HashMap = accounts + .into_iter() + .map(|(pk, acc)| (pk, acc.into())) + .collect(); + + // Now resolve all accounts from the instruction + let mut result = Vec::new(); + for account_meta in &instruction.accounts { + let key = account_meta.pubkey; + let account = if let Some(acc) = account_map.remove(&key) { + // Use the provided account + acc + } else if Rent::check_id(&key) { + mollusk.sysvars.keyed_account_for_rent_sysvar().1 + } else if solana_clock::Clock::check_id(&key) { + mollusk.sysvars.keyed_account_for_clock_sysvar().1 + } else if solana_epoch_schedule::EpochSchedule::check_id(&key) { + mollusk.sysvars.keyed_account_for_epoch_schedule_sysvar().1 + } else if solana_epoch_rewards::EpochRewards::check_id(&key) { + mollusk.sysvars.keyed_account_for_epoch_rewards_sysvar().1 + } else if StakeHistory::check_id(&key) { + // Re-serialize stake history from mollusk.sysvars.stake_history + mollusk.sysvars.keyed_account_for_stake_history_sysvar().1 + } else { + // Default empty account + Account::default() + }; + + result.push((key, account)); + } + + result +} diff --git a/program/tests/initialize.rs b/program/tests/initialize.rs new file mode 100644 index 00000000..28e189f9 --- /dev/null +++ b/program/tests/initialize.rs @@ -0,0 +1,261 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, + instruction_builders::{InitializeCheckedConfig, InitializeConfig}, + lifecycle::StakeLifecycle, + }, + mollusk_svm::result::Check, + solana_account::{AccountSharedData, ReadableAccount}, + solana_program_error::ProgramError, + solana_pubkey::Pubkey, + solana_rent::Rent, + solana_stake_interface::state::{Authorized, Lockup, StakeStateV2}, + solana_stake_program::id, + test_case::test_case, +}; + +#[derive(Debug, Clone, Copy)] +enum InitializeVariant { + Initialize, + InitializeChecked, +} + +#[test_case(InitializeVariant::Initialize; "initialize")] +#[test_case(InitializeVariant::InitializeChecked; "initialize_checked")] +fn test_initialize(variant: InitializeVariant) { + let mut ctx = StakeTestContext::new(); + + let custodian = Pubkey::new_unique(); + + let authorized = Authorized { + staker: ctx.staker, + withdrawer: ctx.withdrawer, + }; + + // InitializeChecked always uses default lockup + let lockup = match variant { + InitializeVariant::Initialize => Lockup { + epoch: 1, + unix_timestamp: 0, + custodian, + }, + InitializeVariant::InitializeChecked => Lockup::default(), + }; + + // Create an uninitialized stake account + let (stake, stake_account) = ctx.stake_account(StakeLifecycle::Uninitialized).build(); + + // Process the Initialize instruction, including testing missing signers + let result = { + let program_id = id(); + let checks = [ + Check::success(), + Check::all_rent_exempt(), + Check::account(&stake) + .lamports(ctx.rent_exempt_reserve) + .owner(&program_id) + .space(StakeStateV2::size_of()) + .build(), + ]; + + let processor = match variant { + InitializeVariant::Initialize => ctx.process_with(InitializeConfig { + stake: (&stake, &stake_account), + authorized: &authorized, + lockup: &lockup, + }), + InitializeVariant::InitializeChecked => ctx.process_with(InitializeCheckedConfig { + stake: (&stake, &stake_account), + authorized: &authorized, + }), + }; + + processor + .checks(&checks) + .test_missing_signers(true) + .execute() + }; + + // Check that we see what we expect + let resulting_account: AccountSharedData = result.resulting_accounts[0].1.clone().into(); + let stake_state: StakeStateV2 = bincode::deserialize(resulting_account.data()).unwrap(); + assert_eq!( + stake_state, + StakeStateV2::Initialized(solana_stake_interface::state::Meta { + authorized, + rent_exempt_reserve: ctx.rent_exempt_reserve, + lockup, + }), + ); + + // Attempting to initialize an already initialized stake account should fail + let processor = match variant { + InitializeVariant::Initialize => ctx.process_with(InitializeConfig { + stake: (&stake, &resulting_account), + authorized: &authorized, + lockup: &lockup, + }), + InitializeVariant::InitializeChecked => ctx.process_with(InitializeCheckedConfig { + stake: (&stake, &resulting_account), + authorized: &authorized, + }), + }; + + processor + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); +} + +#[test_case(InitializeVariant::Initialize; "initialize")] +#[test_case(InitializeVariant::InitializeChecked; "initialize_checked")] +fn test_initialize_insufficient_funds(variant: InitializeVariant) { + let ctx = StakeTestContext::new(); + + let custodian = Pubkey::new_unique(); + let authorized = Authorized { + staker: ctx.staker, + withdrawer: ctx.withdrawer, + }; + let lockup = match variant { + InitializeVariant::Initialize => Lockup { + epoch: 1, + unix_timestamp: 0, + custodian, + }, + InitializeVariant::InitializeChecked => Lockup::default(), + }; + + // Create account with insufficient lamports (need to manually create since builder adds rent automatically) + let stake = Pubkey::new_unique(); + let stake_account = AccountSharedData::new_data_with_space( + ctx.rent_exempt_reserve / 2, // Not enough lamports + &StakeStateV2::Uninitialized, + StakeStateV2::size_of(), + &id(), + ) + .unwrap(); + + let processor = match variant { + InitializeVariant::Initialize => ctx.process_with(InitializeConfig { + stake: (&stake, &stake_account), + authorized: &authorized, + lockup: &lockup, + }), + InitializeVariant::InitializeChecked => ctx.process_with(InitializeCheckedConfig { + stake: (&stake, &stake_account), + authorized: &authorized, + }), + }; + + processor + .checks(&[Check::err(ProgramError::InsufficientFunds)]) + .test_missing_signers(false) + .execute(); +} + +#[test_case(InitializeVariant::Initialize; "initialize")] +#[test_case(InitializeVariant::InitializeChecked; "initialize_checked")] +fn test_initialize_incorrect_size_larger(variant: InitializeVariant) { + let ctx = StakeTestContext::new(); + + // Original program_test.rs uses double rent instead of just + // increasing the size by 1. This behavior remains (makes no difference here). + let rent_exempt_reserve = Rent::default().minimum_balance(StakeStateV2::size_of() * 2); + + let custodian = Pubkey::new_unique(); + let authorized = Authorized { + staker: ctx.staker, + withdrawer: ctx.withdrawer, + }; + let lockup = match variant { + InitializeVariant::Initialize => Lockup { + epoch: 1, + unix_timestamp: 0, + custodian, + }, + InitializeVariant::InitializeChecked => Lockup::default(), + }; + + // Create account with wrong size (need to manually create since builder enforces correct size) + let stake = Pubkey::new_unique(); + let stake_account = AccountSharedData::new_data_with_space( + rent_exempt_reserve, + &StakeStateV2::Uninitialized, + StakeStateV2::size_of() + 1, // Too large + &id(), + ) + .unwrap(); + + let processor = match variant { + InitializeVariant::Initialize => ctx.process_with(InitializeConfig { + stake: (&stake, &stake_account), + authorized: &authorized, + lockup: &lockup, + }), + InitializeVariant::InitializeChecked => ctx.process_with(InitializeCheckedConfig { + stake: (&stake, &stake_account), + authorized: &authorized, + }), + }; + + processor + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); +} + +#[test_case(InitializeVariant::Initialize; "initialize")] +#[test_case(InitializeVariant::InitializeChecked; "initialize_checked")] +fn test_initialize_incorrect_size_smaller(variant: InitializeVariant) { + let ctx = StakeTestContext::new(); + + // Original program_test.rs uses rent for size instead of + // rent for size - 1. This behavior remains (makes no difference here). + let rent_exempt_reserve = Rent::default().minimum_balance(StakeStateV2::size_of()); + + let custodian = Pubkey::new_unique(); + let authorized = Authorized { + staker: ctx.staker, + withdrawer: ctx.withdrawer, + }; + let lockup = match variant { + InitializeVariant::Initialize => Lockup { + epoch: 1, + unix_timestamp: 0, + custodian, + }, + InitializeVariant::InitializeChecked => Lockup::default(), + }; + + // Create account with wrong size (need to manually create since builder enforces correct size) + let stake = Pubkey::new_unique(); + let stake_account = AccountSharedData::new_data_with_space( + rent_exempt_reserve, + &StakeStateV2::Uninitialized, + StakeStateV2::size_of() - 1, // Too small + &id(), + ) + .unwrap(); + + let processor = match variant { + InitializeVariant::Initialize => ctx.process_with(InitializeConfig { + stake: (&stake, &stake_account), + authorized: &authorized, + lockup: &lockup, + }), + InitializeVariant::InitializeChecked => ctx.process_with(InitializeCheckedConfig { + stake: (&stake, &stake_account), + authorized: &authorized, + }), + }; + + processor + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); +} diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs index e1988c7a..4f146806 100644 --- a/program/tests/program_test.rs +++ b/program/tests/program_test.rs @@ -396,17 +396,6 @@ async fn program_test_stake_checked_instructions() { let seed = "test seed"; let seeded_address = Pubkey::create_with_seed(&seed_base, seed, &system_program::id()).unwrap(); - // Test InitializeChecked with non-signing withdrawer - let stake = create_blank_stake_account(&mut context).await; - let instruction = ixn::initialize_checked(&stake, &Authorized { staker, withdrawer }); - - process_instruction_test_missing_signers( - &mut context, - &instruction, - &vec![&withdrawer_keypair], - ) - .await; - // Test AuthorizeChecked with non-signing staker let stake = create_independent_stake_account(&mut context, &Authorized { staker, withdrawer }, 0).await; @@ -482,116 +471,6 @@ async fn program_test_stake_checked_instructions() { .await; } -#[tokio::test] -async fn program_test_stake_initialize() { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let rent_exempt_reserve = get_stake_account_rent(&mut context.banks_client).await; - - let staker_keypair = Keypair::new(); - let withdrawer_keypair = Keypair::new(); - let custodian_keypair = Keypair::new(); - - let staker = staker_keypair.pubkey(); - let withdrawer = withdrawer_keypair.pubkey(); - let custodian = custodian_keypair.pubkey(); - - let authorized = Authorized { staker, withdrawer }; - - let lockup = Lockup { - epoch: 1, - unix_timestamp: 0, - custodian, - }; - - let stake = create_blank_stake_account(&mut context).await; - let instruction = ixn::initialize(&stake, &authorized, &lockup); - - // should pass - process_instruction(&mut context, &instruction, NO_SIGNERS) - .await - .unwrap(); - - // check that we see what we expect - let account = get_account(&mut context.banks_client, &stake).await; - let stake_state: StakeStateV2 = bincode::deserialize(&account.data).unwrap(); - assert_eq!( - stake_state, - StakeStateV2::Initialized(Meta { - authorized, - rent_exempt_reserve, - lockup, - }), - ); - - // 2nd time fails, can't move it from anything other than uninit->init - refresh_blockhash(&mut context).await; - let e = process_instruction(&mut context, &instruction, NO_SIGNERS) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountData); - - // not enough balance for rent - let stake = Pubkey::new_unique(); - let account = SolanaAccount { - lamports: rent_exempt_reserve / 2, - data: vec![0; StakeStateV2::size_of()], - owner: id(), - executable: false, - rent_epoch: 1000, - }; - context.set_account(&stake, &account.into()); - - let instruction = ixn::initialize(&stake, &authorized, &lockup); - let e = process_instruction(&mut context, &instruction, NO_SIGNERS) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InsufficientFunds); - - // incorrect account sizes - let stake_keypair = Keypair::new(); - let stake = stake_keypair.pubkey(); - - let instruction = system_instruction::create_account( - &context.payer.pubkey(), - &stake, - rent_exempt_reserve * 2, - StakeStateV2::size_of() as u64 + 1, - &id(), - ); - process_instruction(&mut context, &instruction, &vec![&stake_keypair]) - .await - .unwrap(); - - let instruction = ixn::initialize(&stake, &authorized, &lockup); - let e = process_instruction(&mut context, &instruction, NO_SIGNERS) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountData); - - let stake_keypair = Keypair::new(); - let stake = stake_keypair.pubkey(); - - let instruction = system_instruction::create_account( - &context.payer.pubkey(), - &stake, - rent_exempt_reserve, - StakeStateV2::size_of() as u64 - 1, - &id(), - ); - process_instruction(&mut context, &instruction, &vec![&stake_keypair]) - .await - .unwrap(); - - let instruction = ixn::initialize(&stake, &authorized, &lockup); - let e = process_instruction(&mut context, &instruction, NO_SIGNERS) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountData); -} - #[tokio::test] async fn program_test_authorize() { let mut context = program_test().start_with_context().await; From c2acd676d76c84d4be5b9bdbfbb6b85543197ac8 Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 11:41:55 +0000 Subject: [PATCH 02/10] tweaks --- program/tests/initialize.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/program/tests/initialize.rs b/program/tests/initialize.rs index 28e189f9..75187774 100644 --- a/program/tests/initialize.rs +++ b/program/tests/initialize.rs @@ -46,7 +46,6 @@ fn test_initialize(variant: InitializeVariant) { InitializeVariant::InitializeChecked => Lockup::default(), }; - // Create an uninitialized stake account let (stake, stake_account) = ctx.stake_account(StakeLifecycle::Uninitialized).build(); // Process the Initialize instruction, including testing missing signers @@ -130,7 +129,7 @@ fn test_initialize_insufficient_funds(variant: InitializeVariant) { InitializeVariant::InitializeChecked => Lockup::default(), }; - // Create account with insufficient lamports (need to manually create since builder adds rent automatically) + // Create account with insufficient lamports (manually since builder adds rent automatically) let stake = Pubkey::new_unique(); let stake_account = AccountSharedData::new_data_with_space( ctx.rent_exempt_reserve / 2, // Not enough lamports @@ -163,8 +162,6 @@ fn test_initialize_insufficient_funds(variant: InitializeVariant) { fn test_initialize_incorrect_size_larger(variant: InitializeVariant) { let ctx = StakeTestContext::new(); - // Original program_test.rs uses double rent instead of just - // increasing the size by 1. This behavior remains (makes no difference here). let rent_exempt_reserve = Rent::default().minimum_balance(StakeStateV2::size_of() * 2); let custodian = Pubkey::new_unique(); @@ -214,8 +211,6 @@ fn test_initialize_incorrect_size_larger(variant: InitializeVariant) { fn test_initialize_incorrect_size_smaller(variant: InitializeVariant) { let ctx = StakeTestContext::new(); - // Original program_test.rs uses rent for size instead of - // rent for size - 1. This behavior remains (makes no difference here). let rent_exempt_reserve = Rent::default().minimum_balance(StakeStateV2::size_of()); let custodian = Pubkey::new_unique(); From 14294e284e33c56c6714a1b4d7f2b1ddb342bc96 Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 11:43:26 +0000 Subject: [PATCH 03/10] migrate Deactivate tests --- Cargo.lock | 1 + program/Cargo.toml | 1 + program/tests/deactivate.rs | 115 ++++++++++++++ program/tests/helpers/context.rs | 132 ++++++++++++++-- program/tests/helpers/instruction_builders.rs | 39 ++++- program/tests/helpers/lifecycle.rs | 147 ++++++++++++++++-- program/tests/helpers/utils.rs | 31 +++- program/tests/program_test.rs | 75 --------- 8 files changed, 442 insertions(+), 99 deletions(-) create mode 100644 program/tests/deactivate.rs diff --git a/Cargo.lock b/Cargo.lock index 2876dd23..eed57071 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -7214,6 +7214,7 @@ dependencies = [ "solana-transaction", "solana-vote-interface 4.0.4", "test-case", + "tokio", ] [[package]] diff --git a/program/Cargo.toml b/program/Cargo.toml index e47d083b..96c4346c 100644 --- a/program/Cargo.toml +++ b/program/Cargo.toml @@ -45,6 +45,7 @@ solana-system-interface = { version = "2.0.0", features = ["bincode"] } solana-sysvar-id = "3.0.0" solana-transaction = "3.0.0" test-case = "3.3.1" +tokio = "1" [lib] crate-type = ["cdylib", "lib"] diff --git a/program/tests/deactivate.rs b/program/tests/deactivate.rs new file mode 100644 index 00000000..980edaab --- /dev/null +++ b/program/tests/deactivate.rs @@ -0,0 +1,115 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, + instruction_builders::{DeactivateConfig, DelegateConfig}, + lifecycle::StakeLifecycle, + utils::parse_stake_account, + }, + mollusk_svm::result::Check, + solana_program_error::ProgramError, + solana_stake_interface::{error::StakeError, state::StakeStateV2}, + solana_stake_program::id, + test_case::test_case, +}; + +#[test_case(false; "activating")] +#[test_case(true; "active")] +fn test_deactivate(activate: bool) { + let mut ctx = StakeTestContext::with_delegation(); + let min_delegation = ctx.minimum_delegation.unwrap(); + + let (stake, mut stake_account) = ctx + .stake_account(StakeLifecycle::Initialized) + .staked_amount(min_delegation) + .build(); + + // Deactivating an undelegated account fails + ctx.process_with(DeactivateConfig { + stake: (&stake, &stake_account), + override_signer: None, + }) + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); + + // Delegate + let result = ctx + .process_with(DelegateConfig { + stake: (&stake, &stake_account), + vote: ( + ctx.vote_account.as_ref().unwrap(), + ctx.vote_account_data.as_ref().unwrap(), + ), + }) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + if activate { + // Advance epoch to activate + let current_slot = ctx.mollusk.sysvars.clock.slot; + let slots_per_epoch = ctx.mollusk.sysvars.epoch_schedule.slots_per_epoch; + ctx.mollusk.warp_to_slot(current_slot + slots_per_epoch); + } + + // Deactivate with withdrawer fails + ctx.process_with(DeactivateConfig { + stake: (&stake, &stake_account), + override_signer: Some(&ctx.withdrawer), + }) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Deactivate succeeds + let result = ctx + .process_with(DeactivateConfig { + stake: (&stake, &stake_account), + override_signer: None, + }) + .checks(&[ + Check::success(), + Check::all_rent_exempt(), + Check::account(&stake) + .lamports(ctx.rent_exempt_reserve + min_delegation) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + ]) + .test_missing_signers(true) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + let clock = ctx.mollusk.sysvars.clock.clone(); + let (_, stake_data, _) = parse_stake_account(&stake_account); + assert_eq!( + stake_data.unwrap().delegation.deactivation_epoch, + clock.epoch + ); + + // Deactivate again fails + ctx.process_with(DeactivateConfig { + stake: (&stake, &stake_account), + override_signer: None, + }) + .checks(&[Check::err(StakeError::AlreadyDeactivated.into())]) + .test_missing_signers(false) + .execute(); + + // Advance epoch + let current_slot = ctx.mollusk.sysvars.clock.slot; + let slots_per_epoch = ctx.mollusk.sysvars.epoch_schedule.slots_per_epoch; + ctx.mollusk.warp_to_slot(current_slot + slots_per_epoch); + + // Deactivate again still fails + ctx.process_with(DeactivateConfig { + stake: (&stake, &stake_account), + override_signer: None, + }) + .checks(&[Check::err(StakeError::AlreadyDeactivated.into())]) + .test_missing_signers(false) + .execute(); +} diff --git a/program/tests/helpers/context.rs b/program/tests/helpers/context.rs index 03713b4d..d0c44350 100644 --- a/program/tests/helpers/context.rs +++ b/program/tests/helpers/context.rs @@ -2,62 +2,172 @@ use { super::{ instruction_builders::{InstructionConfig, InstructionExecution}, lifecycle::StakeLifecycle, - utils::{add_sysvars, STAKE_RENT_EXEMPTION}, + utils::{add_sysvars, create_vote_account, STAKE_RENT_EXEMPTION}, }, mollusk_svm::{result::Check, Mollusk}, solana_account::AccountSharedData, solana_instruction::Instruction, solana_pubkey::Pubkey, + solana_stake_interface::state::Lockup, solana_stake_program::id, }; /// Builder for creating stake accounts with customizable parameters -pub struct StakeAccountBuilder { +pub struct StakeAccountBuilder<'a> { + ctx: &'a mut StakeTestContext, lifecycle: StakeLifecycle, + staked_amount: u64, + stake_authority: Option, + withdraw_authority: Option, + lockup: Option, + vote_account: Option, + stake_pubkey: Option, } -impl StakeAccountBuilder { +impl StakeAccountBuilder<'_> { + /// Set the staked amount (lamports delegated to validator) + pub fn staked_amount(mut self, amount: u64) -> Self { + self.staked_amount = amount; + self + } + + /// Set a custom stake authority (defaults to ctx.staker) + pub fn stake_authority(mut self, authority: &Pubkey) -> Self { + self.stake_authority = Some(*authority); + self + } + + /// Set a custom withdraw authority (defaults to ctx.withdrawer) + pub fn withdraw_authority(mut self, authority: &Pubkey) -> Self { + self.withdraw_authority = Some(*authority); + self + } + + /// Set a custom lockup (defaults to Lockup::default()) + pub fn lockup(mut self, lockup: &Lockup) -> Self { + self.lockup = Some(*lockup); + self + } + + /// Set a custom vote account (defaults to ctx.vote_account) + pub fn vote_account(mut self, vote_account: &Pubkey) -> Self { + self.vote_account = Some(*vote_account); + self + } + + /// Set a specific stake account pubkey (defaults to Pubkey::new_unique()) + pub fn stake_pubkey(mut self, pubkey: &Pubkey) -> Self { + self.stake_pubkey = Some(*pubkey); + self + } + + /// Build the stake account and return (pubkey, account_data) pub fn build(self) -> (Pubkey, AccountSharedData) { - let stake_pubkey = Pubkey::new_unique(); - let account = self.lifecycle.create_uninitialized_account(); + let stake_pubkey = self.stake_pubkey.unwrap_or_else(Pubkey::new_unique); + let account = self.lifecycle.create_stake_account_fully_specified( + &mut self.ctx.mollusk, + &stake_pubkey, + self.vote_account.as_ref().unwrap_or( + self.ctx + .vote_account + .as_ref() + .expect("vote_account required for this lifecycle"), + ), + self.staked_amount, + self.stake_authority.as_ref().unwrap_or(&self.ctx.staker), + self.withdraw_authority + .as_ref() + .unwrap_or(&self.ctx.withdrawer), + self.lockup.as_ref().unwrap_or(&Lockup::default()), + ); (stake_pubkey, account) } } -/// Consolidated test context for stake account tests pub struct StakeTestContext { pub mollusk: Mollusk, pub rent_exempt_reserve: u64, pub staker: Pubkey, pub withdrawer: Pubkey, + pub minimum_delegation: Option, + pub vote_account: Option, + pub vote_account_data: Option, } impl StakeTestContext { - /// Create a new test context with all standard setup - pub fn new() -> Self { + pub fn minimal() -> Self { let mollusk = Mollusk::new(&id(), "solana_stake_program"); + Self { + mollusk, + rent_exempt_reserve: STAKE_RENT_EXEMPTION, + staker: Pubkey::new_unique(), + withdrawer: Pubkey::new_unique(), + minimum_delegation: None, + vote_account: None, + vote_account_data: None, + } + } + pub fn with_delegation() -> Self { + let mollusk = Mollusk::new(&id(), "solana_stake_program"); + let minimum_delegation = solana_stake_program::get_minimum_delegation(); Self { mollusk, rent_exempt_reserve: STAKE_RENT_EXEMPTION, staker: Pubkey::new_unique(), withdrawer: Pubkey::new_unique(), + minimum_delegation: Some(minimum_delegation), + vote_account: Some(Pubkey::new_unique()), + vote_account_data: Some(create_vote_account()), } } + pub fn new() -> Self { + Self::with_delegation() + } + /// Create a stake account builder for the specified lifecycle stage /// /// Example: /// ``` /// let (stake, account) = ctx - /// .stake_account(StakeLifecycle::Uninitialized) + /// .stake_account(StakeLifecycle::Active) + /// .staked_amount(1_000_000) /// .build(); /// ``` pub fn stake_account(&mut self, lifecycle: StakeLifecycle) -> StakeAccountBuilder { - StakeAccountBuilder { lifecycle } + StakeAccountBuilder { + ctx: self, + lifecycle, + staked_amount: 0, + stake_authority: None, + withdraw_authority: None, + lockup: None, + vote_account: None, + stake_pubkey: None, + } + } + + /// Create a lockup that expires in the future + pub fn create_future_lockup(&self, epochs_ahead: u64) -> Lockup { + Lockup { + unix_timestamp: 0, + epoch: self.mollusk.sysvars.clock.epoch + epochs_ahead, + custodian: Pubkey::new_unique(), + } + } + + /// Create a lockup that's currently in force (far future) + pub fn create_in_force_lockup(&self) -> Lockup { + self.create_future_lockup(1_000_000) + } + + /// Create a second vote account (for testing different vote accounts) + pub fn create_second_vote_account(&self) -> (Pubkey, AccountSharedData) { + (Pubkey::new_unique(), create_vote_account()) } - /// Process an instruction + /// Process an instruction with a config-based approach pub fn process_with<'b, C: InstructionConfig>( &self, config: C, diff --git a/program/tests/helpers/instruction_builders.rs b/program/tests/helpers/instruction_builders.rs index 515a72a0..cc700115 100644 --- a/program/tests/helpers/instruction_builders.rs +++ b/program/tests/helpers/instruction_builders.rs @@ -37,8 +37,8 @@ impl<'b> InstructionExecution<'_, 'b> { } /// Executes the instruction. If `checks` is `None` or empty, uses `Check::success()`. - /// Fail-safe default: when `test_missing_signers` is `None`, runs the missing-signers - /// test (`true`). Callers must explicitly opt out with `.test_missing_signers(false)`. + /// When `test_missing_signers` is `None`, runs the missing-signers tests. + /// Callers must explicitly opt out with `.test_missing_signers(false)`. pub fn execute(self) -> mollusk_svm::result::InstructionResult { let default_checks = [Check::success()]; let checks = match self.checks { @@ -103,3 +103,38 @@ impl InstructionConfig for InitializeCheckedConfig<'_> { vec![(*self.stake.0, self.stake.1.clone())] } } + +pub struct DeactivateConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + /// Override signer for testing wrong signer scenarios (defaults to ctx.staker) + pub override_signer: Option<&'a Pubkey>, +} + +impl InstructionConfig for DeactivateConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + let signer = self.override_signer.unwrap_or(&ctx.staker); + ixn::deactivate_stake(self.stake.0, signer) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![(*self.stake.0, self.stake.1.clone())] + } +} + +pub struct DelegateConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + pub vote: (&'a Pubkey, &'a AccountSharedData), +} + +impl InstructionConfig for DelegateConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + ixn::delegate_stake(self.stake.0, &ctx.staker, self.vote.0) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![ + (*self.stake.0, self.stake.1.clone()), + (*self.vote.0, self.vote.1.clone()), + ] + } +} diff --git a/program/tests/helpers/lifecycle.rs b/program/tests/helpers/lifecycle.rs index 74e55285..e094c96f 100644 --- a/program/tests/helpers/lifecycle.rs +++ b/program/tests/helpers/lifecycle.rs @@ -1,6 +1,13 @@ use { - super::utils::STAKE_RENT_EXEMPTION, solana_account::AccountSharedData, - solana_stake_interface::state::StakeStateV2, solana_stake_program::id, + super::utils::{add_sysvars, create_vote_account, STAKE_RENT_EXEMPTION}, + mollusk_svm::Mollusk, + solana_account::{Account, AccountSharedData, WritableAccount}, + solana_pubkey::Pubkey, + solana_stake_interface::{ + instruction as ixn, + state::{Authorized, Lockup, StakeStateV2}, + }, + solana_stake_program::id, }; /// Lifecycle states for stake accounts in tests @@ -16,14 +23,134 @@ pub enum StakeLifecycle { } impl StakeLifecycle { - /// Create an uninitialized stake account - pub fn create_uninitialized_account(self) -> AccountSharedData { - AccountSharedData::new_data_with_space( - STAKE_RENT_EXEMPTION, - &StakeStateV2::Uninitialized, - StakeStateV2::size_of(), - &id(), + /// Create a stake account with full specification of authorities and lockup + #[allow(clippy::too_many_arguments)] + pub fn create_stake_account_fully_specified( + self, + mollusk: &mut Mollusk, + // tracker: &mut StakeTracker, // added in subsequent PR + stake_pubkey: &Pubkey, + vote_account: &Pubkey, + staked_amount: u64, + staker: &Pubkey, + withdrawer: &Pubkey, + lockup: &Lockup, + ) -> AccountSharedData { + let is_closed = self == StakeLifecycle::Closed; + + // Create base account + let mut stake_account = if is_closed { + let mut account = Account::create(STAKE_RENT_EXEMPTION, vec![], id(), false, u64::MAX); + // Add staked_amount even for closed accounts (matches program-test behavior) + if staked_amount > 0 { + account.lamports += staked_amount; + } + account.into() + } else { + Account::create( + STAKE_RENT_EXEMPTION + staked_amount, + vec![0; StakeStateV2::size_of()], + id(), + false, + u64::MAX, + ) + .into() + }; + + if is_closed { + return stake_account; + } + + let authorized = Authorized { + staker: *staker, + withdrawer: *withdrawer, + }; + + // Initialize if needed + if self >= StakeLifecycle::Initialized { + let stake_state = StakeStateV2::Initialized(solana_stake_interface::state::Meta { + rent_exempt_reserve: STAKE_RENT_EXEMPTION, + authorized, + lockup: *lockup, + }); + bincode::serialize_into(stake_account.data_as_mut_slice(), &stake_state).unwrap(); + } + + // Delegate if needed + if self >= StakeLifecycle::Activating { + let instruction = ixn::delegate_stake(stake_pubkey, staker, vote_account); + + let accounts = vec![ + (*stake_pubkey, stake_account.clone()), + (*vote_account, create_vote_account()), + ]; + + // Use add_sysvars to provide clock, stake history, and config accounts + let accounts_with_sysvars = add_sysvars(mollusk, &instruction, accounts); + let result = mollusk.process_instruction(&instruction, &accounts_with_sysvars); + stake_account = result.resulting_accounts[0].1.clone().into(); + + // Track delegation in the tracker + // let activation_epoch = mollusk.sysvars.clock.epoch; + // TODO: uncomment in subsequent PR (add `tracker.track_delegation` here) + // tracker.track_delegation(stake_pubkey, staked_amount, activation_epoch, vote_account); + } + + // Advance epoch to activate if needed (Active and beyond) + if self >= StakeLifecycle::Active { + // With background stake in tracker, just warp 1 epoch + // The background stake provides baseline for instant partial activation + let slots_per_epoch = mollusk.sysvars.epoch_schedule.slots_per_epoch; + let current_slot = mollusk.sysvars.clock.slot; + let target_slot = current_slot + slots_per_epoch; + + // TODO: use `warp_to_slot_with_stake_tracking` here (in subsequent PR) + mollusk.warp_to_slot(target_slot); + } + + // Deactivate if needed + if self >= StakeLifecycle::Deactivating { + let instruction = ixn::deactivate_stake(stake_pubkey, staker); + + let accounts = vec![(*stake_pubkey, stake_account.clone())]; + + // Use add_sysvars to provide clock account + let accounts_with_sysvars = add_sysvars(mollusk, &instruction, accounts); + let result = mollusk.process_instruction(&instruction, &accounts_with_sysvars); + stake_account = result.resulting_accounts[0].1.clone().into(); + + // Track deactivation in the tracker + // let deactivation_epoch = mollusk.sysvars.clock.epoch; + // TODO: uncomment in subsequent PR + // tracker.track_deactivation(stake_pubkey, deactivation_epoch); + } + + // Advance epoch to fully deactivate if needed (Deactive lifecycle) + // Matches program_test.rs line 978-983: advance_epoch once to fully deactivate + if self == StakeLifecycle::Deactive { + // With background stake, advance 1 epoch for deactivation + // Background provides the baseline for instant partial deactivation + let slots_per_epoch = mollusk.sysvars.epoch_schedule.slots_per_epoch; + let current_slot = mollusk.sysvars.clock.slot; + let target_slot = current_slot + slots_per_epoch; + + // TODO: use `warp_to_slot_with_stake_tracking` here (in subsequent PR) + mollusk.warp_to_slot(target_slot); + } + + stake_account + } + + /// Whether this lifecycle stage enforces minimum delegation for split + pub fn split_minimum_enforced(&self) -> bool { + matches!( + self, + Self::Activating | Self::Active | Self::Deactivating | Self::Deactive ) - .unwrap() + } + + /// Whether this lifecycle stage enforces minimum delegation for withdraw + pub fn withdraw_minimum_enforced(&self) -> bool { + matches!(self, Self::Activating | Self::Active | Self::Deactivating) } } diff --git a/program/tests/helpers/utils.rs b/program/tests/helpers/utils.rs index 3bc0659b..3113d245 100644 --- a/program/tests/helpers/utils.rs +++ b/program/tests/helpers/utils.rs @@ -1,11 +1,12 @@ use { mollusk_svm::Mollusk, - solana_account::{Account, AccountSharedData}, + solana_account::{Account, AccountSharedData, ReadableAccount, WritableAccount}, solana_instruction::Instruction, solana_pubkey::Pubkey, solana_rent::Rent, solana_stake_interface::{stake_history::StakeHistory, state::StakeStateV2}, solana_sysvar_id::SysvarId, + solana_vote_interface::state::{VoteStateV4, VoteStateVersions}, std::collections::HashMap, }; @@ -63,3 +64,31 @@ pub fn add_sysvars( result } + +/// Create a vote account with VoteStateV4 +pub fn create_vote_account() -> AccountSharedData { + let space = VoteStateV4::size_of(); + let lamports = Rent::default().minimum_balance(space); + let vote_state = VoteStateVersions::new_v4(VoteStateV4::default()); + let data = bincode::serialize(&vote_state).unwrap(); + + Account::create(lamports, data, solana_sdk_ids::vote::id(), false, u64::MAX).into() +} + +/// Parse a stake account into (Meta, Option, lamports) +pub fn parse_stake_account( + stake_account: &AccountSharedData, +) -> ( + solana_stake_interface::state::Meta, + Option, + u64, +) { + let lamports = stake_account.lamports(); + let stake_state: StakeStateV2 = bincode::deserialize(stake_account.data()).unwrap(); + + match stake_state { + StakeStateV2::Initialized(meta) => (meta, None, lamports), + StakeStateV2::Stake(meta, stake, _) => (meta, Some(stake), lamports), + _ => panic!("Expected initialized or staked account"), + } +} diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs index 4f146806..7c6dc660 100644 --- a/program/tests/program_test.rs +++ b/program/tests/program_test.rs @@ -1206,81 +1206,6 @@ async fn program_test_withdraw_stake(withdraw_source_type: StakeLifecycle) { assert_eq!(e, ProgramError::InvalidAccountData); } -#[test_case(false; "activating")] -#[test_case(true; "active")] -#[tokio::test] -async fn program_test_deactivate(activate: bool) { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let minimum_delegation = get_minimum_delegation(&mut context).await; - - let staker_keypair = Keypair::new(); - let withdrawer_keypair = Keypair::new(); - - let staker = staker_keypair.pubkey(); - let withdrawer = withdrawer_keypair.pubkey(); - - let authorized = Authorized { staker, withdrawer }; - - let stake = - create_independent_stake_account(&mut context, &authorized, minimum_delegation).await; - - // deactivating an undelegated account fails - let instruction = ixn::deactivate_stake(&stake, &staker); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountData); - - // delegate - let instruction = ixn::delegate_stake(&stake, &staker, &accounts.vote_account.pubkey()); - process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap(); - - if activate { - advance_epoch(&mut context).await; - } else { - refresh_blockhash(&mut context).await; - } - - // deactivate with withdrawer fails - let instruction = ixn::deactivate_stake(&stake, &withdrawer); - let e = process_instruction(&mut context, &instruction, &vec![&withdrawer_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::MissingRequiredSignature); - - // deactivate succeeds - let instruction = ixn::deactivate_stake(&stake, &staker); - process_instruction_test_missing_signers(&mut context, &instruction, &vec![&staker_keypair]) - .await; - - let clock = context.banks_client.get_sysvar::().await.unwrap(); - let (_, stake_data, _) = get_stake_account(&mut context.banks_client, &stake).await; - assert_eq!( - stake_data.unwrap().delegation.deactivation_epoch, - clock.epoch - ); - - // deactivate again fails - refresh_blockhash(&mut context).await; - - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::AlreadyDeactivated.into()); - - advance_epoch(&mut context).await; - - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::AlreadyDeactivated.into()); -} - // XXX the original test_merge is a stupid test // the real thing is test_merge_active_stake which actively controls clock and // stake_history but im just trying to smoke test rn so lets do something From 7d34dd5f2ee3271ba9086e038b91b393efa11b26 Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 11:45:41 +0000 Subject: [PATCH 04/10] StakeTracker, migrate Delegate tests --- program/tests/delegate.rs | 214 ++++ program/tests/helpers/context.rs | 13 +- program/tests/helpers/lifecycle.rs | 34 +- program/tests/helpers/mod.rs | 1 + program/tests/helpers/stake_tracker.rs | 168 +++ program/tests/helpers/utils.rs | 16 + program/tests/program_test.rs | 144 +-- program/tests/stake_tracker_equivalence.rs | 1266 ++++++++++++++++++++ 8 files changed, 1700 insertions(+), 156 deletions(-) create mode 100644 program/tests/delegate.rs create mode 100644 program/tests/helpers/stake_tracker.rs create mode 100644 program/tests/stake_tracker_equivalence.rs diff --git a/program/tests/delegate.rs b/program/tests/delegate.rs new file mode 100644 index 00000000..eb65b5dd --- /dev/null +++ b/program/tests/delegate.rs @@ -0,0 +1,214 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, + instruction_builders::{DeactivateConfig, DelegateConfig}, + lifecycle::StakeLifecycle, + stake_tracker::MolluskStakeExt, + utils::{create_vote_account, increment_vote_account_credits, parse_stake_account}, + }, + mollusk_svm::result::Check, + solana_account::{AccountSharedData, WritableAccount}, + solana_program_error::ProgramError, + solana_pubkey::Pubkey, + solana_stake_interface::{ + error::StakeError, + state::{Delegation, Stake, StakeStateV2}, + }, + solana_stake_program::id, +}; + +#[test] +fn test_delegate() { + let mut ctx = StakeTestContext::with_delegation(); + let vote_account = *ctx.vote_account.as_ref().unwrap(); + let mut vote_account_data = ctx.vote_account_data.as_ref().unwrap().clone(); + let min_delegation = ctx.minimum_delegation.unwrap(); + + let vote_state_credits = 100u64; + increment_vote_account_credits(&mut vote_account_data, 0, vote_state_credits); + + let (stake, mut stake_account) = ctx + .stake_account(StakeLifecycle::Initialized) + .staked_amount(min_delegation) + .build(); + + // Delegate stake + let result = ctx + .process_with(DelegateConfig { + stake: (&stake, &stake_account), + vote: (&vote_account, &vote_account_data), + }) + .checks(&[ + Check::success(), + Check::all_rent_exempt(), + Check::account(&stake) + .lamports(ctx.rent_exempt_reserve + min_delegation) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + ]) + .test_missing_signers(true) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + // Verify that delegate() looks right + let clock = ctx.mollusk.sysvars.clock.clone(); + let (_, stake_data, _) = parse_stake_account(&stake_account); + assert_eq!( + stake_data.unwrap(), + Stake { + delegation: Delegation { + voter_pubkey: vote_account, + stake: min_delegation, + activation_epoch: clock.epoch, + deactivation_epoch: u64::MAX, + ..Delegation::default() + }, + credits_observed: vote_state_credits, + } + ); + + // Advance epoch to activate the stake + let activation_epoch = ctx.mollusk.sysvars.clock.epoch; + ctx.tracker.as_mut().unwrap().track_delegation( + &stake, + min_delegation, + activation_epoch, + &vote_account, + ); + + let slots_per_epoch = ctx.mollusk.sysvars.epoch_schedule.slots_per_epoch; + let current_slot = ctx.mollusk.sysvars.clock.slot; + ctx.mollusk.warp_to_slot_with_stake_tracking( + ctx.tracker.as_ref().unwrap(), + current_slot + slots_per_epoch, + Some(0), + ); + + // Verify that delegate fails as stake is active and not deactivating + ctx.process_with(DelegateConfig { + stake: (&stake, &stake_account), + vote: (&vote_account, ctx.vote_account_data.as_ref().unwrap()), + }) + .checks(&[Check::err(StakeError::TooSoonToRedelegate.into())]) + .test_missing_signers(false) + .execute(); + + // Deactivate + let result = ctx + .process_with(DeactivateConfig { + stake: (&stake, &stake_account), + override_signer: None, + }) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + // Create second vote account + let (vote_account2, vote_account2_data) = ctx.create_second_vote_account(); + + // Verify that delegate to a different vote account fails during deactivation + ctx.process_with(DelegateConfig { + stake: (&stake, &stake_account), + vote: (&vote_account2, &vote_account2_data), + }) + .checks(&[Check::err(StakeError::TooSoonToRedelegate.into())]) + .test_missing_signers(false) + .execute(); + + // Verify that delegate succeeds to same vote account when stake is deactivating + let result = ctx + .process_with(DelegateConfig { + stake: (&stake, &stake_account), + vote: (&vote_account, ctx.vote_account_data.as_ref().unwrap()), + }) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + // Verify that deactivation has been cleared + let (_, stake_data, _) = parse_stake_account(&stake_account); + assert_eq!(stake_data.unwrap().delegation.deactivation_epoch, u64::MAX); + + // Verify that delegate to a different vote account fails if stake is still active + ctx.process_with(DelegateConfig { + stake: (&stake, &stake_account), + vote: (&vote_account2, &vote_account2_data), + }) + .checks(&[Check::err(StakeError::TooSoonToRedelegate.into())]) + .test_missing_signers(false) + .execute(); + + // Advance epoch again using tracker + let current_slot = ctx.mollusk.sysvars.clock.slot; + let slots_per_epoch = ctx.mollusk.sysvars.epoch_schedule.slots_per_epoch; + ctx.mollusk.warp_to_slot_with_stake_tracking( + ctx.tracker.as_ref().unwrap(), + current_slot + slots_per_epoch, + Some(0), + ); + + // Delegate still fails after stake is fully activated; redelegate is not supported + let (vote_account2, vote_account2_data) = ctx.create_second_vote_account(); + + ctx.process_with(DelegateConfig { + stake: (&stake, &stake_account), + vote: (&vote_account2, &vote_account2_data), + }) + .checks(&[Check::err(StakeError::TooSoonToRedelegate.into())]) + .test_missing_signers(false) + .execute(); +} + +#[test] +fn test_delegate_fake_vote_account() { + let mut ctx = StakeTestContext::with_delegation(); + + // Create fake vote account (not owned by vote program) + let fake_vote_account = Pubkey::new_unique(); + let mut fake_vote_data = create_vote_account(); + fake_vote_data.set_owner(Pubkey::new_unique()); // Wrong owner + + let min_delegation = ctx.minimum_delegation.unwrap(); + let (stake, stake_account) = ctx + .stake_account(StakeLifecycle::Initialized) + .staked_amount(min_delegation) + .build(); + + // Try to delegate to fake vote account + ctx.process_with(DelegateConfig { + stake: (&stake, &stake_account), + vote: (&fake_vote_account, &fake_vote_data), + }) + .checks(&[Check::err(ProgramError::IncorrectProgramId)]) + .test_missing_signers(false) + .execute(); +} + +#[test] +fn test_delegate_non_stake_account() { + let ctx = StakeTestContext::with_delegation(); + + // Create a rewards pool account (program-owned but not a stake account) + let rewards_pool = Pubkey::new_unique(); + let rewards_pool_data = AccountSharedData::new_data_with_space( + ctx.rent_exempt_reserve, + &StakeStateV2::RewardsPool, + StakeStateV2::size_of(), + &id(), + ) + .unwrap(); + + ctx.process_with(DelegateConfig { + stake: (&rewards_pool, &rewards_pool_data), + vote: ( + ctx.vote_account.as_ref().unwrap(), + ctx.vote_account_data.as_ref().unwrap(), + ), + }) + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); +} diff --git a/program/tests/helpers/context.rs b/program/tests/helpers/context.rs index d0c44350..4507a7cf 100644 --- a/program/tests/helpers/context.rs +++ b/program/tests/helpers/context.rs @@ -2,6 +2,7 @@ use { super::{ instruction_builders::{InstructionConfig, InstructionExecution}, lifecycle::StakeLifecycle, + stake_tracker::StakeTracker, utils::{add_sysvars, create_vote_account, STAKE_RENT_EXEMPTION}, }, mollusk_svm::{result::Check, Mollusk}, @@ -66,6 +67,10 @@ impl StakeAccountBuilder<'_> { let stake_pubkey = self.stake_pubkey.unwrap_or_else(Pubkey::new_unique); let account = self.lifecycle.create_stake_account_fully_specified( &mut self.ctx.mollusk, + self.ctx + .tracker + .as_mut() + .expect("tracker required for stake account builder"), &stake_pubkey, self.vote_account.as_ref().unwrap_or( self.ctx @@ -84,6 +89,7 @@ impl StakeAccountBuilder<'_> { } } +#[allow(dead_code)] // can be removed once later tests are in pub struct StakeTestContext { pub mollusk: Mollusk, pub rent_exempt_reserve: u64, @@ -92,8 +98,10 @@ pub struct StakeTestContext { pub minimum_delegation: Option, pub vote_account: Option, pub vote_account_data: Option, + pub tracker: Option, } +#[allow(dead_code)] // can be removed once later tests are in impl StakeTestContext { pub fn minimal() -> Self { let mollusk = Mollusk::new(&id(), "solana_stake_program"); @@ -105,12 +113,14 @@ impl StakeTestContext { minimum_delegation: None, vote_account: None, vote_account_data: None, + tracker: None, } } pub fn with_delegation() -> Self { let mollusk = Mollusk::new(&id(), "solana_stake_program"); let minimum_delegation = solana_stake_program::get_minimum_delegation(); + let tracker: StakeTracker = StakeLifecycle::create_tracker_for_test(minimum_delegation); Self { mollusk, rent_exempt_reserve: STAKE_RENT_EXEMPTION, @@ -119,6 +129,7 @@ impl StakeTestContext { minimum_delegation: Some(minimum_delegation), vote_account: Some(Pubkey::new_unique()), vote_account_data: Some(create_vote_account()), + tracker: Some(tracker), } } @@ -127,6 +138,7 @@ impl StakeTestContext { } /// Create a stake account builder for the specified lifecycle stage + /// This is the primary method for creating stake accounts in tests. /// /// Example: /// ``` @@ -214,7 +226,6 @@ impl StakeTestContext { .process_and_validate_instruction(instruction, &accounts_with_sysvars, checks) } } - impl Default for StakeTestContext { fn default() -> Self { Self::new() diff --git a/program/tests/helpers/lifecycle.rs b/program/tests/helpers/lifecycle.rs index e094c96f..67aed6a9 100644 --- a/program/tests/helpers/lifecycle.rs +++ b/program/tests/helpers/lifecycle.rs @@ -1,5 +1,9 @@ use { - super::utils::{add_sysvars, create_vote_account, STAKE_RENT_EXEMPTION}, + super::{ + stake_tracker::MolluskStakeExt, + utils::{add_sysvars, create_vote_account, STAKE_RENT_EXEMPTION}, + }, + crate::helpers::stake_tracker::StakeTracker, mollusk_svm::Mollusk, solana_account::{Account, AccountSharedData, WritableAccount}, solana_pubkey::Pubkey, @@ -23,12 +27,22 @@ pub enum StakeLifecycle { } impl StakeLifecycle { + /// Helper to create tracker with appropriate background stake for tests + /// Returns a tracker seeded with background cluster stake + pub fn create_tracker_for_test(minimum_delegation: u64) -> StakeTracker { + // Use a moderate background stake amount + // This mimics Banks' cluster-wide effective stake from all validators + // Calculation: needs to be >> test stakes to provide stable warmup base + let background_stake = minimum_delegation.saturating_mul(100); + StakeTracker::with_background_stake(background_stake) + } + /// Create a stake account with full specification of authorities and lockup #[allow(clippy::too_many_arguments)] pub fn create_stake_account_fully_specified( self, mollusk: &mut Mollusk, - // tracker: &mut StakeTracker, // added in subsequent PR + tracker: &mut StakeTracker, stake_pubkey: &Pubkey, vote_account: &Pubkey, staked_amount: u64, @@ -91,9 +105,8 @@ impl StakeLifecycle { stake_account = result.resulting_accounts[0].1.clone().into(); // Track delegation in the tracker - // let activation_epoch = mollusk.sysvars.clock.epoch; - // TODO: uncomment in subsequent PR (add `tracker.track_delegation` here) - // tracker.track_delegation(stake_pubkey, staked_amount, activation_epoch, vote_account); + let activation_epoch = mollusk.sysvars.clock.epoch; + tracker.track_delegation(stake_pubkey, staked_amount, activation_epoch, vote_account); } // Advance epoch to activate if needed (Active and beyond) @@ -104,8 +117,7 @@ impl StakeLifecycle { let current_slot = mollusk.sysvars.clock.slot; let target_slot = current_slot + slots_per_epoch; - // TODO: use `warp_to_slot_with_stake_tracking` here (in subsequent PR) - mollusk.warp_to_slot(target_slot); + mollusk.warp_to_slot_with_stake_tracking(tracker, target_slot, Some(0)); } // Deactivate if needed @@ -120,9 +132,8 @@ impl StakeLifecycle { stake_account = result.resulting_accounts[0].1.clone().into(); // Track deactivation in the tracker - // let deactivation_epoch = mollusk.sysvars.clock.epoch; - // TODO: uncomment in subsequent PR - // tracker.track_deactivation(stake_pubkey, deactivation_epoch); + let deactivation_epoch = mollusk.sysvars.clock.epoch; + tracker.track_deactivation(stake_pubkey, deactivation_epoch); } // Advance epoch to fully deactivate if needed (Deactive lifecycle) @@ -134,8 +145,7 @@ impl StakeLifecycle { let current_slot = mollusk.sysvars.clock.slot; let target_slot = current_slot + slots_per_epoch; - // TODO: use `warp_to_slot_with_stake_tracking` here (in subsequent PR) - mollusk.warp_to_slot(target_slot); + mollusk.warp_to_slot_with_stake_tracking(tracker, target_slot, Some(0)); } stake_account diff --git a/program/tests/helpers/mod.rs b/program/tests/helpers/mod.rs index ff09b000..7b85f51d 100644 --- a/program/tests/helpers/mod.rs +++ b/program/tests/helpers/mod.rs @@ -4,4 +4,5 @@ pub mod context; pub mod instruction_builders; pub mod lifecycle; +pub mod stake_tracker; pub mod utils; diff --git a/program/tests/helpers/stake_tracker.rs b/program/tests/helpers/stake_tracker.rs new file mode 100644 index 00000000..6885ef51 --- /dev/null +++ b/program/tests/helpers/stake_tracker.rs @@ -0,0 +1,168 @@ +use { + mollusk_svm::Mollusk, + solana_clock::Epoch, + solana_pubkey::Pubkey, + solana_stake_interface::{ + stake_history::{StakeHistory, StakeHistoryEntry}, + state::Delegation, + }, + std::collections::HashMap, +}; + +// This replicates solana-runtime's Banks behavior where stake history is automatically +// updated at epoch boundaries by aggregating all stake delegations. + +/// Tracks stake delegations for automatic stake history management +#[derive(Default, Clone)] +pub struct StakeTracker { + /// Map of stake account pubkey to its delegation info + pub(crate) delegations: HashMap, +} + +#[derive(Clone)] +pub(crate) struct TrackedDelegation { + pub(crate) stake: u64, + pub(crate) activation_epoch: Epoch, + pub(crate) deactivation_epoch: Epoch, + pub(crate) voter_pubkey: Pubkey, +} + +impl StakeTracker { + pub fn new() -> Self { + Self::default() + } + + /// Create a tracker with background cluster stake (like Banks has) + /// This provides the baseline effective stake that enables instant activation/deactivation + pub fn with_background_stake(background_stake: u64) -> Self { + let mut tracker = Self::new(); + + // Add a synthetic background stake that's been active forever (bootstrap stake) + // This mimics Banks' cluster-wide effective stake + tracker.delegations.insert( + Pubkey::new_unique(), // Synthetic background stake pubkey + TrackedDelegation { + stake: background_stake, + activation_epoch: u64::MAX, // Bootstrap = instantly effective + deactivation_epoch: u64::MAX, + voter_pubkey: Pubkey::new_unique(), + }, + ); + + tracker + } + + /// Track a new stake delegation (called after delegate instruction) + pub fn track_delegation( + &mut self, + stake_pubkey: &Pubkey, + stake_amount: u64, + activation_epoch: Epoch, + voter_pubkey: &Pubkey, + ) { + self.delegations.insert( + *stake_pubkey, + TrackedDelegation { + stake: stake_amount, + activation_epoch, + deactivation_epoch: u64::MAX, + voter_pubkey: *voter_pubkey, + }, + ); + } + + /// Mark a stake as deactivating (called after deactivate instruction) + pub fn track_deactivation(&mut self, stake_pubkey: &Pubkey, deactivation_epoch: Epoch) { + if let Some(delegation) = self.delegations.get_mut(stake_pubkey) { + delegation.deactivation_epoch = deactivation_epoch; + } + } + + /// Calculate aggregate stake history for an epoch (replicates Stakes::activate_epoch) + fn calculate_epoch_entry( + &self, + epoch: Epoch, + stake_history: &StakeHistory, + new_rate_activation_epoch: Option, + ) -> StakeHistoryEntry { + self.delegations + .values() + .map(|tracked| { + let delegation = Delegation { + voter_pubkey: tracked.voter_pubkey, + stake: tracked.stake, + activation_epoch: tracked.activation_epoch, + deactivation_epoch: tracked.deactivation_epoch, + ..Delegation::default() + }; + + delegation.stake_activating_and_deactivating( + epoch, + stake_history, + new_rate_activation_epoch, + ) + }) + .fold(StakeHistoryEntry::default(), |acc, status| { + StakeHistoryEntry { + effective: acc.effective + status.effective, + activating: acc.activating + status.activating, + deactivating: acc.deactivating + status.deactivating, + } + }) + } +} + +/// Extension trait that adds stake-aware warping to Mollusk +pub trait MolluskStakeExt { + /// Warp to a slot and automatically update stake history at epoch boundaries + /// + /// This replicates Banks' behavior from solana-runtime: + /// - Bank::warp_from_parent() advances slot + /// - Stakes::activate_epoch() aggregates delegations + /// - Bank::update_stake_history() writes sysvar + fn warp_to_slot_with_stake_tracking( + &mut self, + tracker: &StakeTracker, + target_slot: u64, + new_rate_activation_epoch: Option, + ); +} + +impl MolluskStakeExt for Mollusk { + fn warp_to_slot_with_stake_tracking( + &mut self, + tracker: &StakeTracker, + target_slot: u64, + new_rate_activation_epoch: Option, + ) { + let current_epoch = self.sysvars.clock.epoch; + let current_slot = self.sysvars.clock.slot; + + if target_slot <= current_slot { + panic!( + "Cannot warp backwards: current_slot={}, target_slot={}", + current_slot, target_slot + ); + } + + // Advance the clock (Mollusk's warp_to_slot only updates Clock sysvar) + self.warp_to_slot(target_slot); + + let new_epoch = self.sysvars.clock.epoch; + + // If we crossed epoch boundaries, update stake history for EACH epoch + // StakeHistorySysvar requires contiguous history with no gaps + // This replicates Bank::update_stake_history() + Stakes::activate_epoch() + if new_epoch != current_epoch { + for epoch in current_epoch..new_epoch { + let entry = tracker.calculate_epoch_entry( + epoch, + &self.sysvars.stake_history, + new_rate_activation_epoch, + ); + + self.sysvars.stake_history.add(epoch, entry); + } + } + } +} diff --git a/program/tests/helpers/utils.rs b/program/tests/helpers/utils.rs index 3113d245..c83886cf 100644 --- a/program/tests/helpers/utils.rs +++ b/program/tests/helpers/utils.rs @@ -1,6 +1,7 @@ use { mollusk_svm::Mollusk, solana_account::{Account, AccountSharedData, ReadableAccount, WritableAccount}, + solana_clock::Epoch, solana_instruction::Instruction, solana_pubkey::Pubkey, solana_rent::Rent, @@ -92,3 +93,18 @@ pub fn parse_stake_account( _ => panic!("Expected initialized or staked account"), } } + +/// Increment vote account credits +pub fn increment_vote_account_credits( + vote_account: &mut AccountSharedData, + epoch: Epoch, + credits: u64, +) { + let mut vote_state: VoteStateVersions = bincode::deserialize(vote_account.data()).unwrap(); + + if let VoteStateVersions::V4(ref mut v4) = vote_state { + v4.epoch_credits.push((epoch, credits, 0)); + } + + vote_account.set_data(bincode::serialize(&vote_state).unwrap()); +} diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs index 7c6dc660..09c826ca 100644 --- a/program/tests/program_test.rs +++ b/program/tests/program_test.rs @@ -17,7 +17,7 @@ use { instruction::{self as ixn, LockupArgs}, program::id, stake_history::StakeHistory, - state::{Authorized, Delegation, Lockup, Meta, Stake, StakeAuthorize, StakeStateV2}, + state::{Authorized, Lockup, Meta, Stake, StakeAuthorize, StakeStateV2}, }, solana_system_interface::instruction as system_instruction, solana_transaction::{Signers, Transaction, TransactionError}, @@ -619,148 +619,6 @@ async fn program_test_authorize() { } } -#[tokio::test] -async fn program_test_stake_delegate() { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let vote_account2 = Keypair::new(); - create_vote( - &mut context, - &Keypair::new(), - &Pubkey::new_unique(), - &Pubkey::new_unique(), - &vote_account2, - ) - .await; - - let staker_keypair = Keypair::new(); - let withdrawer_keypair = Keypair::new(); - - let staker = staker_keypair.pubkey(); - let withdrawer = withdrawer_keypair.pubkey(); - - let authorized = Authorized { staker, withdrawer }; - - let vote_state_credits = 100; - context.increment_vote_account_credits(&accounts.vote_account.pubkey(), vote_state_credits); - let minimum_delegation = get_minimum_delegation(&mut context).await; - - let stake = - create_independent_stake_account(&mut context, &authorized, minimum_delegation).await; - let instruction = ixn::delegate_stake(&stake, &staker, &accounts.vote_account.pubkey()); - - process_instruction_test_missing_signers(&mut context, &instruction, &vec![&staker_keypair]) - .await; - - // verify that delegate() looks right - let clock = context.banks_client.get_sysvar::().await.unwrap(); - let (_, stake_data, _) = get_stake_account(&mut context.banks_client, &stake).await; - assert_eq!( - stake_data.unwrap(), - Stake { - delegation: Delegation { - voter_pubkey: accounts.vote_account.pubkey(), - stake: minimum_delegation, - activation_epoch: clock.epoch, - deactivation_epoch: u64::MAX, - ..Delegation::default() - }, - credits_observed: vote_state_credits, - } - ); - - // verify that delegate fails as stake is active and not deactivating - advance_epoch(&mut context).await; - let instruction = ixn::delegate_stake(&stake, &staker, &accounts.vote_account.pubkey()); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::TooSoonToRedelegate.into()); - - // deactivate - let instruction = ixn::deactivate_stake(&stake, &staker); - process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap(); - - // verify that delegate to a different vote account fails during deactivation - let instruction = ixn::delegate_stake(&stake, &staker, &vote_account2.pubkey()); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::TooSoonToRedelegate.into()); - - // verify that delegate succeeds to same vote account when stake is deactivating - refresh_blockhash(&mut context).await; - let instruction = ixn::delegate_stake(&stake, &staker, &accounts.vote_account.pubkey()); - process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap(); - - // verify that deactivation has been cleared - let (_, stake_data, _) = get_stake_account(&mut context.banks_client, &stake).await; - assert_eq!(stake_data.unwrap().delegation.deactivation_epoch, u64::MAX); - - // verify that delegate to a different vote account fails if stake is still - // active - let instruction = ixn::delegate_stake(&stake, &staker, &vote_account2.pubkey()); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::TooSoonToRedelegate.into()); - - // delegate still fails after stake is fully activated; redelegate is not - // supported - advance_epoch(&mut context).await; - let instruction = ixn::delegate_stake(&stake, &staker, &vote_account2.pubkey()); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::TooSoonToRedelegate.into()); - - // delegate to spoofed vote account fails (not owned by vote program) - let mut fake_vote_account = - get_account(&mut context.banks_client, &accounts.vote_account.pubkey()).await; - fake_vote_account.owner = Pubkey::new_unique(); - let fake_vote_address = Pubkey::new_unique(); - context.set_account(&fake_vote_address, &fake_vote_account.into()); - - let stake = - create_independent_stake_account(&mut context, &authorized, minimum_delegation).await; - let instruction = ixn::delegate_stake(&stake, &staker, &fake_vote_address); - - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::IncorrectProgramId); - - // delegate stake program-owned non-stake account fails - let rewards_pool_address = Pubkey::new_unique(); - let rewards_pool = SolanaAccount { - lamports: get_stake_account_rent(&mut context.banks_client).await, - data: bincode::serialize(&StakeStateV2::RewardsPool) - .unwrap() - .to_vec(), - owner: id(), - executable: false, - rent_epoch: u64::MAX, - }; - context.set_account(&rewards_pool_address, &rewards_pool.into()); - - let instruction = ixn::delegate_stake( - &rewards_pool_address, - &staker, - &accounts.vote_account.pubkey(), - ); - - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountData); -} - #[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] pub enum StakeLifecycle { Uninitialized = 0, diff --git a/program/tests/stake_tracker_equivalence.rs b/program/tests/stake_tracker_equivalence.rs new file mode 100644 index 00000000..15af084e --- /dev/null +++ b/program/tests/stake_tracker_equivalence.rs @@ -0,0 +1,1266 @@ +#![allow(clippy::arithmetic_side_effects)] + +//! Equivalence tests proving StakeTracker (Mollusk) matches BanksClient (solana-program-test) +//! +//! These tests run identical stake operations through both implementations and compare results +//! to ensure 1:1 behavioral equivalence in stake history tracking. +use { + mollusk_svm::Mollusk, + solana_account::{AccountSharedData, ReadableAccount, WritableAccount}, + solana_clock::Clock, + solana_keypair::Keypair, + solana_program_test::{ProgramTest, ProgramTestContext}, + solana_pubkey::Pubkey, + solana_signer::Signer, + solana_stake_interface::{ + instruction as ixn, + stake_history::StakeHistory, + state::{Authorized, Lockup, StakeStateV2}, + }, + solana_stake_program::id, + solana_system_interface::instruction as system_instruction, + solana_transaction::Transaction, + test_case::test_case, +}; + +mod helpers; +use helpers::{ + stake_tracker::{MolluskStakeExt, StakeTracker}, + utils::{add_sysvars, create_vote_account, STAKE_RENT_EXEMPTION}, +}; + +// Constants for testing +const MINIMUM_DELEGATION: u64 = 1; + +/// Dual context holding both BanksClient and Mollusk paths +struct DualContext { + // BanksClient path + program_test_ctx: ProgramTestContext, + + // Mollusk path + mollusk: Mollusk, + tracker: StakeTracker, + + // Shared test data + vote_account: Pubkey, + vote_account_data: AccountSharedData, + background_stake: u64, +} + +impl DualContext { + /// Create both contexts with matching initial state + async fn new() -> Self { + // Initialize program test (BanksClient path) + let mut program_test = ProgramTest::default(); + program_test.prefer_bpf(true); + program_test.add_upgradeable_program_to_genesis("solana_stake_program", &id()); + let mut program_test_ctx = program_test.start_with_context().await; + + // Warp to first normal slot on Banks + let slot = program_test_ctx + .genesis_config() + .epoch_schedule + .first_normal_slot + + 1; + program_test_ctx.warp_to_slot(slot).unwrap(); + + // Initialize Mollusk and sync to the same epoch as Banks + let mut mollusk = Mollusk::new(&id(), "solana_stake_program"); + // Banks and Mollusk have different epoch schedules, so we need to get to same epoch + let banks_clock = program_test_ctx + .banks_client + .get_sysvar::() + .await + .unwrap(); + let banks_epoch = banks_clock.epoch; + + // Warp Mollusk to the same epoch by calculating the corresponding slot + let mollusk_slot_for_epoch = mollusk + .sysvars + .epoch_schedule + .get_first_slot_in_epoch(banks_epoch); + mollusk.warp_to_slot(mollusk_slot_for_epoch); + + // Extract BanksClient's actual background stake from its genesis stake history + // This ensures Mollusk uses the same background stake for identical history + let banks_stake_history = program_test_ctx + .banks_client + .get_sysvar::() + .await + .unwrap(); + + let epoch_0_entry = banks_stake_history.get(0).cloned().unwrap_or_default(); + let background_stake = epoch_0_entry.effective; + + let tracker = StakeTracker::with_background_stake(background_stake); + + // Initialize Mollusk's stake history to match BanksClient + // Banks may not have history for all intermediate epochs when warped directly, + // so we'll generate them using the tracker (which only has background stake initially) + for epoch in 0..banks_epoch { + if let Some(entry) = banks_stake_history.get(epoch).cloned() { + // Use Banks' actual entry if it exists + mollusk.sysvars.stake_history.add(epoch, entry); + } else { + // Generate entry with just background stake for missing epochs + // This matches what would happen if we had advanced through these epochs naturally + mollusk + .sysvars + .stake_history + .add(epoch, epoch_0_entry.clone()); + } + } + + // Create shared vote account + let vote_account = Pubkey::new_unique(); + let vote_account_data = create_vote_account(); + + // Add vote account to BanksClient (clone to keep original) + program_test_ctx.set_account(&vote_account, &vote_account_data.clone()); + + Self { + program_test_ctx, + mollusk, + tracker, + vote_account, + vote_account_data, + background_stake, + } + } + + /// Create a blank stake account on both paths + async fn create_blank_stake_account(&mut self) -> Pubkey { + let stake_keypair = Keypair::new(); + let stake = stake_keypair.pubkey(); + + // BanksClient path + let transaction = Transaction::new_signed_with_payer( + &[system_instruction::create_account( + &self.program_test_ctx.payer.pubkey(), + &stake, + STAKE_RENT_EXEMPTION, + StakeStateV2::size_of() as u64, + &id(), + )], + Some(&self.program_test_ctx.payer.pubkey()), + &[&self.program_test_ctx.payer, &stake_keypair], + self.program_test_ctx.last_blockhash, + ); + self.program_test_ctx + .banks_client + .process_transaction(transaction) + .await + .unwrap(); + + // Mollusk path - just track that we'll add it when needed + // (Mollusk accounts are passed per-instruction, not stored globally) + + stake + } + + /// Initialize a stake account on both paths + async fn initialize_stake_account( + &mut self, + stake: &Pubkey, + authorized: &Authorized, + lockup: &Lockup, + ) -> AccountSharedData { + let instruction = ixn::initialize(stake, authorized, lockup); + + // BanksClient path + let transaction = Transaction::new_signed_with_payer( + &[instruction.clone()], + Some(&self.program_test_ctx.payer.pubkey()), + &[&self.program_test_ctx.payer], + self.program_test_ctx.last_blockhash, + ); + self.program_test_ctx + .banks_client + .process_transaction(transaction) + .await + .unwrap(); + + // Get account from BanksClient + let banks_account = self + .program_test_ctx + .banks_client + .get_account(*stake) + .await + .unwrap() + .unwrap(); + + // Mollusk path - create matching account + let mut mollusk_account = + AccountSharedData::new(STAKE_RENT_EXEMPTION, StakeStateV2::size_of(), &id()); + + let accounts = vec![(*stake, mollusk_account.clone())]; + let accounts_with_sysvars = add_sysvars(&self.mollusk, &instruction, accounts); + let result = self + .mollusk + .process_instruction(&instruction, &accounts_with_sysvars); + assert!(result.program_result.is_ok()); + mollusk_account = result.resulting_accounts[0].1.clone().into(); + + // Verify accounts match + assert_eq!(banks_account.data, mollusk_account.data()); + assert_eq!(banks_account.lamports, mollusk_account.lamports()); + + mollusk_account + } + + /// Delegate stake on both paths to a specific vote account + async fn delegate_stake_to( + &mut self, + stake: &Pubkey, + stake_account: &mut AccountSharedData, + staker_keypair: &Keypair, + vote_account: &Pubkey, + vote_account_data: &AccountSharedData, + ) { + let instruction = ixn::delegate_stake(stake, &staker_keypair.pubkey(), vote_account); + + // BanksClient path + let transaction = Transaction::new_signed_with_payer( + &[instruction.clone()], + Some(&self.program_test_ctx.payer.pubkey()), + &[&self.program_test_ctx.payer, staker_keypair], + self.program_test_ctx.last_blockhash, + ); + self.program_test_ctx + .banks_client + .process_transaction(transaction) + .await + .unwrap(); + + // Mollusk path + let accounts = vec![ + (*stake, stake_account.clone()), + (*vote_account, vote_account_data.clone()), + ]; + let accounts_with_sysvars = add_sysvars(&self.mollusk, &instruction, accounts); + let result = self + .mollusk + .process_instruction(&instruction, &accounts_with_sysvars); + assert!(result.program_result.is_ok()); + *stake_account = result.resulting_accounts[0].1.clone().into(); + + // Track delegation in Mollusk tracker + let stake_state: StakeStateV2 = bincode::deserialize(stake_account.data()).unwrap(); + if let StakeStateV2::Stake(_, stake_data, _) = stake_state { + self.tracker.track_delegation( + stake, + stake_data.delegation.stake, + stake_data.delegation.activation_epoch, + vote_account, + ); + } + } + + /// Delegate stake on both paths (uses default vote account) + async fn delegate_stake( + &mut self, + stake: &Pubkey, + stake_account: &mut AccountSharedData, + staker_keypair: &Keypair, + ) { + let vote_account = self.vote_account; + let vote_account_data = self.vote_account_data.clone(); + self.delegate_stake_to( + stake, + stake_account, + staker_keypair, + &vote_account, + &vote_account_data, + ) + .await; + } + + /// Deactivate stake on both paths + async fn deactivate_stake( + &mut self, + stake: &Pubkey, + stake_account: &mut AccountSharedData, + staker_keypair: &Keypair, + ) { + let instruction = ixn::deactivate_stake(stake, &staker_keypair.pubkey()); + + // BanksClient path + let transaction = Transaction::new_signed_with_payer( + &[instruction.clone()], + Some(&self.program_test_ctx.payer.pubkey()), + &[&self.program_test_ctx.payer, staker_keypair], + self.program_test_ctx.last_blockhash, + ); + self.program_test_ctx + .banks_client + .process_transaction(transaction) + .await + .unwrap(); + + // Mollusk path + let accounts = vec![(*stake, stake_account.clone())]; + let accounts_with_sysvars = add_sysvars(&self.mollusk, &instruction, accounts); + let result = self + .mollusk + .process_instruction(&instruction, &accounts_with_sysvars); + assert!(result.program_result.is_ok()); + *stake_account = result.resulting_accounts[0].1.clone().into(); + + // Track deactivation + let deactivation_epoch = self.mollusk.sysvars.clock.epoch; + self.tracker.track_deactivation(stake, deactivation_epoch); + } + + /// Advance epoch on both paths with default new_rate_activation_epoch (Some(0)) + async fn advance_epoch(&mut self) { + self.advance_epoch_with_rate(Some(0)).await; + } + + /// Advance epoch on both paths with custom new_rate_activation_epoch + /// Pass None to use old warmup rate behavior + async fn advance_epoch_with_rate(&mut self, new_rate_activation_epoch: Option) { + // Refresh blockhash for BanksClient by advancing slot slightly first + let current_slot = self + .program_test_ctx + .banks_client + .get_root_slot() + .await + .unwrap(); + self.program_test_ctx + .warp_to_slot(current_slot + 1) + .unwrap(); + self.program_test_ctx.last_blockhash = self + .program_test_ctx + .banks_client + .get_latest_blockhash() + .await + .unwrap(); + + // BanksClient path - advance epoch + let root_slot = self + .program_test_ctx + .banks_client + .get_root_slot() + .await + .unwrap(); + let slots_per_epoch = self + .program_test_ctx + .genesis_config() + .epoch_schedule + .slots_per_epoch; + self.program_test_ctx + .warp_to_slot(root_slot + slots_per_epoch) + .unwrap(); + + // Mollusk path - advance epoch with stake tracking + let current_slot = self.mollusk.sysvars.clock.slot; + let mollusk_slots_per_epoch = self.mollusk.sysvars.epoch_schedule.slots_per_epoch; + let target_slot = current_slot + mollusk_slots_per_epoch; + self.mollusk.warp_to_slot_with_stake_tracking( + &self.tracker, + target_slot, + new_rate_activation_epoch, + ); + } + + /// Fast-forward multiple epochs without full validation (for performance) + /// This advances both paths in bulk to avoid excessive async operations + #[allow(dead_code)] + async fn advance_epochs_fast(&mut self, num_epochs: u64) { + if num_epochs == 0 { + return; + } + + // BanksClient: advance in one big jump + let root_slot = self + .program_test_ctx + .banks_client + .get_root_slot() + .await + .unwrap(); + let slots_per_epoch = self + .program_test_ctx + .genesis_config() + .epoch_schedule + .slots_per_epoch; + let target_slot = root_slot + (slots_per_epoch * num_epochs); + self.program_test_ctx.warp_to_slot(target_slot).unwrap(); + self.program_test_ctx.last_blockhash = self + .program_test_ctx + .banks_client + .get_latest_blockhash() + .await + .unwrap(); + + // Mollusk: advance in one big jump + for _ in 0..num_epochs { + let current_slot = self.mollusk.sysvars.clock.slot; + let mollusk_slots_per_epoch = self.mollusk.sysvars.epoch_schedule.slots_per_epoch; + let target_slot = current_slot + mollusk_slots_per_epoch; + self.mollusk + .warp_to_slot_with_stake_tracking(&self.tracker, target_slot, Some(0)); + } + } + + /// Get stake history from BanksClient + async fn get_banks_stake_history(&mut self) -> StakeHistory { + self.program_test_ctx + .banks_client + .get_sysvar::() + .await + .unwrap() + } + + /// Get stake history from Mollusk + fn get_mollusk_stake_history(&self) -> &StakeHistory { + &self.mollusk.sysvars.stake_history + } + + /// Get effective stake from BanksClient + async fn get_banks_effective_stake(&mut self, stake: &Pubkey) -> u64 { + let clock = self + .program_test_ctx + .banks_client + .get_sysvar::() + .await + .unwrap(); + let stake_history = self.get_banks_stake_history().await; + let account = self + .program_test_ctx + .banks_client + .get_account(*stake) + .await + .unwrap() + .unwrap(); + + match bincode::deserialize::(&account.data).unwrap() { + StakeStateV2::Stake(_, stake_data, _) => { + stake_data + .delegation + .stake_activating_and_deactivating(clock.epoch, &stake_history, Some(0)) + .effective + } + _ => 0, + } + } + + /// Get effective stake from Mollusk + fn get_mollusk_effective_stake(&self, stake_account: &AccountSharedData) -> u64 { + let clock = &self.mollusk.sysvars.clock; + let stake_history = &self.mollusk.sysvars.stake_history; + + match bincode::deserialize::(stake_account.data()).unwrap() { + StakeStateV2::Stake(_, stake_data, _) => { + stake_data + .delegation + .stake_activating_and_deactivating(clock.epoch, stake_history, Some(0)) + .effective + } + _ => 0, + } + } + + /// Compare stake history entries between both implementations + /// Verifies all components: effective, activating, and deactivating + async fn compare_stake_history(&mut self, epoch: u64) { + let banks_history = self + .program_test_ctx + .banks_client + .get_sysvar::() + .await + .unwrap(); + let mollusk_history = &self.mollusk.sysvars.stake_history; + + let banks_entry = banks_history.get(epoch); + let mollusk_entry = mollusk_history.get(epoch); + + assert_eq!( + banks_entry, mollusk_entry, + "Stake history mismatch at epoch {}: BanksClient={:?}, Mollusk={:?}", + epoch, banks_entry, mollusk_entry + ); + } + + /// Verify background stake is preserved in stake history across implementations + async fn verify_background_stake_preservation(&mut self, epoch: u64, expected_background: u64) { + let banks_history = self + .program_test_ctx + .banks_client + .get_sysvar::() + .await + .unwrap(); + let mollusk_history = &self.mollusk.sysvars.stake_history; + + if let Some(banks_entry) = banks_history.get(epoch) { + assert!( + banks_entry.effective >= expected_background, + "Epoch {}: Banks effective stake {} should include background {}", + epoch, + banks_entry.effective, + expected_background + ); + } + + if let Some(mollusk_entry) = mollusk_history.get(epoch) { + assert!( + mollusk_entry.effective >= expected_background, + "Epoch {}: Mollusk effective stake {} should include background {}", + epoch, + mollusk_entry.effective, + expected_background + ); + } + } + + /// Compare account state between both paths + async fn compare_account_state(&mut self, stake: &Pubkey, mollusk_account: &AccountSharedData) { + let banks_account = self + .program_test_ctx + .banks_client + .get_account(*stake) + .await + .unwrap() + .unwrap(); + + assert_eq!( + banks_account.lamports, + mollusk_account.lamports(), + "Lamports mismatch" + ); + + let banks_state: StakeStateV2 = bincode::deserialize(&banks_account.data).unwrap(); + let mollusk_state: StakeStateV2 = bincode::deserialize(mollusk_account.data()).unwrap(); + + match (banks_state, mollusk_state) { + (StakeStateV2::Stake(b_meta, b_stake, _), StakeStateV2::Stake(m_meta, m_stake, _)) => { + assert_eq!(b_meta.authorized, m_meta.authorized); + assert_eq!(b_meta.lockup, m_meta.lockup); + assert_eq!(b_stake.delegation.stake, m_stake.delegation.stake); + assert_eq!( + b_stake.delegation.activation_epoch, + m_stake.delegation.activation_epoch + ); + assert_eq!( + b_stake.delegation.deactivation_epoch, + m_stake.delegation.deactivation_epoch + ); + } + (StakeStateV2::Initialized(b_meta), StakeStateV2::Initialized(m_meta)) => { + assert_eq!(b_meta.authorized, m_meta.authorized); + assert_eq!(b_meta.lockup, m_meta.lockup); + } + _ => { + panic!( + "State type mismatch: banks={:?}, mollusk={:?}", + banks_state, mollusk_state + ); + } + } + } + + /// Advance one epoch and compare stake account state between implementations + async fn advance_and_compare_stake( + &mut self, + stake: &Pubkey, + stake_account: &AccountSharedData, + ) { + self.advance_and_compare_stake_with_rate(stake, stake_account, Some(0)) + .await; + } + + /// Advance one epoch with custom warmup rate and compare stake account state + async fn advance_and_compare_stake_with_rate( + &mut self, + stake: &Pubkey, + stake_account: &AccountSharedData, + new_rate_activation_epoch: Option, + ) { + self.advance_epoch_with_rate(new_rate_activation_epoch) + .await; + let epoch = self.mollusk.sysvars.clock.epoch; + self.compare_stake_history(epoch - 1).await; + + let banks_effective = self.get_banks_effective_stake(stake).await; + let mollusk_effective = self.get_mollusk_effective_stake(stake_account); + assert_eq!( + banks_effective, mollusk_effective, + "Epoch {}: effective stake mismatch", + epoch + ); + self.compare_account_state(stake, stake_account).await; + } + + /// Advance epochs until stake is fully activated (effective == delegated amount) + /// Returns number of epochs advanced. Panics if not activated within max_epochs. + async fn advance_until_fully_activated( + &mut self, + stake: &Pubkey, + stake_account: &AccountSharedData, + max_epochs: u64, + ) -> u64 { + let stake_state: StakeStateV2 = bincode::deserialize(stake_account.data()).unwrap(); + let target_amount = match stake_state { + StakeStateV2::Stake(_, stake_data, _) => stake_data.delegation.stake, + _ => panic!("Stake account not in delegated state"), + }; + + let mut epochs_advanced = 0; + loop { + self.advance_and_compare_stake(stake, stake_account).await; + epochs_advanced += 1; + + let banks_effective = self.get_banks_effective_stake(stake).await; + if banks_effective == target_amount { + return epochs_advanced; + } + + assert!( + epochs_advanced < max_epochs, + "Stake did not fully activate within {} epochs", + max_epochs + ); + } + } + + /// Advance epochs until stake is fully deactivated (effective == 0) + /// Returns number of epochs advanced. Panics if not deactivated within max_epochs. + async fn advance_until_fully_deactivated( + &mut self, + stake: &Pubkey, + stake_account: &AccountSharedData, + max_epochs: u64, + ) -> u64 { + let mut epochs_advanced = 0; + loop { + self.advance_and_compare_stake(stake, stake_account).await; + epochs_advanced += 1; + + let banks_effective = self.get_banks_effective_stake(stake).await; + if banks_effective == 0 { + return epochs_advanced; + } + + assert!( + epochs_advanced < max_epochs, + "Stake did not fully deactivate within {} epochs", + max_epochs + ); + } + } + + /// Advance one epoch and compare multiple stake accounts between implementations + async fn advance_and_compare_stakes(&mut self, stakes: &[(&Pubkey, &AccountSharedData)]) { + self.advance_and_compare_stakes_with_rate(stakes, Some(0)) + .await; + } + + /// Advance one epoch with custom warmup rate and compare multiple stake accounts + async fn advance_and_compare_stakes_with_rate( + &mut self, + stakes: &[(&Pubkey, &AccountSharedData)], + new_rate_activation_epoch: Option, + ) { + self.advance_epoch_with_rate(new_rate_activation_epoch) + .await; + let epoch = self.mollusk.sysvars.clock.epoch; + self.compare_stake_history(epoch - 1).await; + + for (stake, stake_account) in stakes { + let banks_effective = self.get_banks_effective_stake(stake).await; + let mollusk_effective = self.get_mollusk_effective_stake(stake_account); + assert_eq!( + banks_effective, mollusk_effective, + "Epoch {}: stake {} mismatch", + epoch, stake + ); + self.compare_account_state(stake, stake_account).await; + } + } + + /// Fund a stake account on BanksClient side + async fn fund_stake_account(&mut self, stake: &Pubkey, amount: u64) { + let fund_ix = + system_instruction::transfer(&self.program_test_ctx.payer.pubkey(), stake, amount); + let transaction = Transaction::new_signed_with_payer( + &[fund_ix], + Some(&self.program_test_ctx.payer.pubkey()), + &[&self.program_test_ctx.payer], + self.program_test_ctx.last_blockhash, + ); + self.program_test_ctx + .banks_client + .process_transaction(transaction) + .await + .unwrap(); + } + + /// Create, initialize, and fund a stake account + /// Returns (stake pubkey, stake account, staker keypair) + async fn create_and_fund_stake( + &mut self, + staked_amount: u64, + lockup: &Lockup, + ) -> (Pubkey, AccountSharedData, Keypair) { + let stake = self.create_blank_stake_account().await; + let staker = Keypair::new(); + let authorized = Authorized { + staker: staker.pubkey(), + withdrawer: Pubkey::new_unique(), + }; + + let mut stake_account = self + .initialize_stake_account(&stake, &authorized, lockup) + .await; + + stake_account.set_lamports(stake_account.lamports() + staked_amount); + self.fund_stake_account(&stake, staked_amount).await; + + (stake, stake_account, staker) + } + + /// Create and register a new vote account on BanksClient + /// Returns (vote account pubkey, vote account data) + fn create_vote_account(&mut self) -> (Pubkey, AccountSharedData) { + let vote_account = Pubkey::new_unique(); + let vote_account_data = create_vote_account(); + self.program_test_ctx + .set_account(&vote_account, &vote_account_data.clone()); + (vote_account, vote_account_data) + } + + /// Create multiple stakes with minimal funding (for testing multiple simultaneous operations) + /// Returns (stakes, stake_accounts, stakers) + async fn create_multiple_stakes( + &mut self, + count: usize, + staked_amount: u64, + ) -> (Vec, Vec, Vec) { + let mut stakes = Vec::new(); + let mut stake_accounts = Vec::new(); + let mut stakers = Vec::new(); + + for _ in 0..count { + let stake = self.create_blank_stake_account().await; + let staker = Keypair::new(); + let authorized = Authorized { + staker: staker.pubkey(), + withdrawer: Pubkey::new_unique(), + }; + + let mut stake_account = self + .initialize_stake_account(&stake, &authorized, &Lockup::default()) + .await; + + stake_account.set_lamports(stake_account.lamports() + staked_amount); + self.fund_stake_account(&stake, staked_amount).await; + + stakes.push(stake); + stake_accounts.push(stake_account); + stakers.push(staker); + } + + (stakes, stake_accounts, stakers) + } + + /// Verify background stake preservation across a range of epochs + async fn verify_background_stake_across_epochs( + &mut self, + num_epochs: u64, + expected_background: u64, + ) { + for epoch_offset in 0..num_epochs { + let epoch = self.mollusk.sysvars.clock.epoch - num_epochs + epoch_offset; + self.verify_background_stake_preservation(epoch, expected_background) + .await; + } + } +} + +// Test single delegation activation over various epoch counts +// +// Uses bulk fast-forward + sampling for large epoch counts to prove equivalence +// without excessive runtime. +#[test_case(5, 1 ; "five_epochs")] +#[test_case(10, 1 ; "ten_epochs")] +#[test_case(20, 1 ; "twenty_epochs")] +#[test_case(50, 1 ; "fifty_epochs")] +#[test_case(182, 2 ; "one_year")] +#[test_case(515, 5 ; "beyond_depth")] +#[test_case(1820, 50 ; "ten_years")] +#[tokio::test] +async fn test_single_delegation_activation(ending_epoch: u64, sample_rate: u64) { + let mut ctx = DualContext::new().await; + + // Create, initialize, and fund stake account + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + // Delegate stake + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + const BOUNDARY: u64 = 10; + + for i in 0..ending_epoch { + let is_warmup_boundary = i < BOUNDARY; + let is_end_boundary = i >= ending_epoch.saturating_sub(BOUNDARY); + let is_sample = i % sample_rate == 0; + + if is_warmup_boundary || is_end_boundary || is_sample { + // Full validation at boundaries and sample points + ctx.advance_and_compare_stake(&stake, &stake_account).await; + + // Periodic background stake checks + let check_frequency = if ending_epoch <= 50 { 10 } else { 50 }; + if i % check_frequency == 0 || i == ending_epoch - 1 { + let epoch = ctx.mollusk.sysvars.clock.epoch; + ctx.verify_background_stake_preservation(epoch - 1, ctx.background_stake) + .await; + } + } else { + ctx.advance_epoch().await; + } + } +} + +// Test deactivation at different points in lifecycle: immediately, during warmup, or after activation +#[test_case(0 ; "immediate_same_epoch")] +#[test_case(1 ; "early_warmup")] +#[test_case(2 ; "mid_warmup")] +#[test_case(3 ; "late_warmup")] +#[test_case(5 ; "after_activation")] +#[tokio::test] +async fn test_deactivation_timing(epochs_before_deactivate: u64) { + let mut ctx = DualContext::new().await; + + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + for _ in 0..epochs_before_deactivate { + ctx.advance_and_compare_stake(&stake, &stake_account).await; + } + + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + + ctx.advance_until_fully_deactivated(&stake, &stake_account, 20) + .await; +} + +// Test various stake amounts through full lifecycle: activation + deactivation +// Verifies warmup/cooldown rates work correctly for minimum, small, and large stakes +#[test_case(MINIMUM_DELEGATION ; "minimum_delegation")] +#[test_case(MINIMUM_DELEGATION * 100 ; "small_amount")] +#[test_case(250_000 * 1_000_000_000 ; "large_amount")] +#[tokio::test] +async fn test_stake_amounts_full_lifecycle(staked_amount: u64) { + let mut ctx = DualContext::new().await; + + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(staked_amount, &Lockup::default()) + .await; + + // Activate + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + ctx.advance_until_fully_activated(&stake, &stake_account, 50) + .await; + + // Deactivate + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + + ctx.advance_until_fully_deactivated(&stake, &stake_account, 50) + .await; +} + +// Test multiple stakes delegating simultaneously, optionally to multiple vote accounts +#[test_case(5, 1 ; "five_stakes_one_vote")] +#[test_case(10, 1 ; "ten_stakes_one_vote")] +#[test_case(20, 1 ; "twenty_stakes_one_vote")] +#[test_case(4, 2 ; "four_stakes_two_votes")] +#[tokio::test] +async fn test_multiple_simultaneous_delegations(num_stakes: usize, num_vote_accounts: usize) { + let mut ctx = DualContext::new().await; + + // Create additional vote accounts if needed + let mut vote_accounts = vec![(ctx.vote_account, ctx.vote_account_data.clone())]; + for _ in 1..num_vote_accounts { + vote_accounts.push(ctx.create_vote_account()); + } + + let (stakes, mut stake_accounts, stakers) = ctx + .create_multiple_stakes(num_stakes, MINIMUM_DELEGATION) + .await; + + // Delegate all stakes (alternating vote accounts if multiple) + for i in 0..num_stakes { + let (vote_account, vote_account_data) = &vote_accounts[i % num_vote_accounts]; + ctx.delegate_stake_to( + &stakes[i], + &mut stake_accounts[i], + &stakers[i], + vote_account, + vote_account_data, + ) + .await; + } + + for _ in 0..10 { + let stake_refs: Vec<_> = stakes.iter().zip(stake_accounts.iter()).collect(); + ctx.advance_and_compare_stakes(&stake_refs).await; + } +} + +#[tokio::test] +async fn test_concurrent_activation_and_deactivation() { + let mut ctx = DualContext::new().await; + + let (stake_a, mut stake_account_a, staker_a) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + let (stake_b, mut stake_account_b, staker_b) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + ctx.delegate_stake(&stake_b, &mut stake_account_b, &staker_b) + .await; + ctx.advance_epoch().await; + + ctx.deactivate_stake(&stake_b, &mut stake_account_b, &staker_b) + .await; + ctx.delegate_stake(&stake_a, &mut stake_account_a, &staker_a) + .await; + + let epoch = ctx.mollusk.sysvars.clock.epoch; + + for _ in 0..5 { + ctx.advance_epoch().await; + let current_epoch = ctx.mollusk.sysvars.clock.epoch; + ctx.compare_stake_history(current_epoch - 1).await; + + let banks_effective_a = ctx.get_banks_effective_stake(&stake_a).await; + let mollusk_effective_a = ctx.get_mollusk_effective_stake(&stake_account_a); + assert_eq!(banks_effective_a, mollusk_effective_a); + ctx.compare_account_state(&stake_a, &stake_account_a).await; + + let banks_effective_b = ctx.get_banks_effective_stake(&stake_b).await; + let mollusk_effective_b = ctx.get_mollusk_effective_stake(&stake_account_b); + assert_eq!(banks_effective_b, mollusk_effective_b); + ctx.compare_account_state(&stake_b, &stake_account_b).await; + } + + let banks_history = ctx.get_banks_stake_history().await; + let mollusk_history = ctx.get_mollusk_stake_history(); + + let banks_entry = banks_history.get(epoch).unwrap(); + let mollusk_entry = mollusk_history.get(epoch).unwrap(); + + assert_eq!(banks_entry.activating, mollusk_entry.activating); + assert_eq!(banks_entry.deactivating, mollusk_entry.deactivating); +} + +#[tokio::test] +async fn test_reactivation_after_deactivation() { + let mut ctx = DualContext::new().await; + + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + for _ in 0..2 { + ctx.advance_and_compare_stake(&stake, &stake_account).await; + } + + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + + ctx.advance_until_fully_deactivated(&stake, &stake_account, 20) + .await; + + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + ctx.advance_until_fully_activated(&stake, &stake_account, 20) + .await; +} + +#[tokio::test] +async fn test_staggered_delegations_over_epochs() { + let mut ctx = DualContext::new().await; + + let (stakes, mut stake_accounts, stakers) = + ctx.create_multiple_stakes(5, MINIMUM_DELEGATION).await; + + // Stagger delegations across epochs (0, 5, 10, 15, 20) + for (idx, target_epoch) in [0, 5, 10, 15, 20].iter().enumerate() { + // Advance to target epoch + while ctx.mollusk.sysvars.clock.epoch < *target_epoch { + ctx.advance_epoch().await; + } + + // Delegate at this epoch + ctx.delegate_stake(&stakes[idx], &mut stake_accounts[idx], &stakers[idx]) + .await; + } + + // Advance and compare until epoch 30 + while ctx.mollusk.sysvars.clock.epoch < 30 { + let stake_refs: Vec<_> = stakes.iter().zip(stake_accounts.iter()).collect(); + ctx.advance_and_compare_stakes(&stake_refs).await; + } +} + +#[tokio::test] +async fn test_mixed_lifecycle_stress() { + let mut ctx = DualContext::new().await; + + let (stakes, mut stake_accounts, stakers) = + ctx.create_multiple_stakes(20, MINIMUM_DELEGATION).await; + + // Create various lifecycle states: + // 5 activating (delegate in epoch 0) + for i in 0..5 { + ctx.delegate_stake(&stakes[i], &mut stake_accounts[i], &stakers[i]) + .await; + } + + ctx.advance_epoch().await; // Epoch 1 + + // 5 more activating (delegate in epoch 1) + for i in 5..10 { + ctx.delegate_stake(&stakes[i], &mut stake_accounts[i], &stakers[i]) + .await; + } + + ctx.advance_epoch().await; // Epoch 2 + + // 5 deactivating + for i in 0..5 { + ctx.deactivate_stake(&stakes[i], &mut stake_accounts[i], &stakers[i]) + .await; + } + + // Advance and observe mixed states + for _ in 0..10 { + let stake_refs: Vec<_> = stakes.iter().zip(stake_accounts.iter()).collect(); + ctx.advance_and_compare_stakes(&stake_refs).await; + } +} + +// Test repeated cycles of delegation and deactivation with full transitions +#[test_case(2 ; "two_cycles")] +#[test_case(3 ; "three_cycles")] +#[tokio::test] +async fn test_repeated_delegation_cycles(num_cycles: usize) { + let mut ctx = DualContext::new().await; + + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + for _ in 0..num_cycles { + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + ctx.advance_until_fully_activated(&stake, &stake_account, 20) + .await; + + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + ctx.advance_until_fully_deactivated(&stake, &stake_account, 20) + .await; + } +} + +// Test re-delegating to a different validator at various points during deactivation +// +// RedelegationTiming: +// - AfterFullActivation: Deactivate after full activation, then redelegate after full deactivation +// - DuringWarmup: Deactivate during warmup (after 2 epochs), then redelegate after full deactivation +// - DuringCooldown: Deactivate after full activation, then redelegate during cooldown (after 2 epochs) +#[test_case("AfterFullActivation" ; "after_full_deactivation")] +#[test_case("DuringWarmup" ; "after_deactivation_during_warmup")] +#[test_case("DuringCooldown" ; "during_deactivation_cooldown")] +#[tokio::test] +async fn test_redelegation_to_different_validator(timing: &str) { + let mut ctx = DualContext::new().await; + + let (vote_account_b, vote_account_b_data) = ctx.create_vote_account(); + + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + // Initial delegation + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + // Setup based on timing + match timing { + "AfterFullActivation" => { + ctx.advance_until_fully_activated(&stake, &stake_account, 20) + .await; + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + ctx.advance_until_fully_deactivated(&stake, &stake_account, 20) + .await; + } + "DuringWarmup" => { + ctx.advance_and_compare_stake(&stake, &stake_account).await; + ctx.advance_and_compare_stake(&stake, &stake_account).await; + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + ctx.advance_until_fully_deactivated(&stake, &stake_account, 20) + .await; + } + "DuringCooldown" => { + ctx.advance_until_fully_activated(&stake, &stake_account, 20) + .await; + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + ctx.advance_and_compare_stake(&stake, &stake_account).await; + ctx.advance_and_compare_stake(&stake, &stake_account).await; + } + _ => panic!("Invalid timing"), + } + + // Redelegate to different validator + ctx.delegate_stake_to( + &stake, + &mut stake_account, + &staker, + &vote_account_b, + &vote_account_b_data, + ) + .await; + + // Verify immediate state after redelegation + ctx.compare_account_state(&stake, &stake_account).await; + let banks_effective = ctx.get_banks_effective_stake(&stake).await; + let mollusk_effective = ctx.get_mollusk_effective_stake(&stake_account); + assert_eq!( + banks_effective, mollusk_effective, + "Effective stake mismatch immediately after redelegation" + ); + + // Complete activation with new validator + ctx.advance_until_fully_activated(&stake, &stake_account, 20) + .await; +} + +// Test old warmup rate behavior (pre-SIMD-0093) with full lifecycle +#[tokio::test] +async fn test_old_warmup_rate_full_lifecycle() { + let mut ctx = DualContext::new().await; + + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + // Activate with old warmup rate + for _ in 0..10 { + ctx.advance_and_compare_stake_with_rate(&stake, &stake_account, None) + .await; + } + + // Deactivate with old warmup rate + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + + for _ in 0..10 { + ctx.advance_and_compare_stake_with_rate(&stake, &stake_account, None) + .await; + } +} + +#[tokio::test] +async fn test_warmup_rate_transition() { + let mut ctx = DualContext::new().await; + + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(MINIMUM_DELEGATION, &Lockup::default()) + .await; + + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + for _ in 0..5 { + ctx.advance_and_compare_stake_with_rate(&stake, &stake_account, None) + .await; + } + + let transition_epoch = ctx.mollusk.sysvars.clock.epoch; + + for _ in 0..10 { + ctx.advance_and_compare_stake_with_rate(&stake, &stake_account, Some(transition_epoch)) + .await; + } +} + +// Test massive stake (50% of background) through full lifecycle +// This verifies that warmup/cooldown rates work correctly when new stake significantly +// impacts the existing effective stake, and ensures background stake is preserved +#[tokio::test] +async fn test_massive_stake_full_lifecycle() { + let mut ctx = DualContext::new().await; + + // Get the background stake - use epoch 0's effective stake as the baseline + let banks_stake_history = ctx.get_banks_stake_history().await; + let background_effective = banks_stake_history + .get(0) + .map(|entry| entry.effective) + .expect("Epoch 0 must have background stake"); + + // Stake 50% of background effective stake - this is MASSIVE and will significantly + // affect warmup rates (warmup is limited by new_stake relative to existing effective) + let staked_amount = background_effective / 2; + + if staked_amount < MINIMUM_DELEGATION { + panic!( + "Bad test: background stake {} too small (need at least {})", + background_effective, + MINIMUM_DELEGATION * 2 + ); + } + + let (stake, mut stake_account, staker) = ctx + .create_and_fund_stake(staked_amount, &Lockup::default()) + .await; + + // Activate + ctx.delegate_stake(&stake, &mut stake_account, &staker) + .await; + + let epochs_to_activate = ctx + .advance_until_fully_activated(&stake, &stake_account, 50) + .await; + + // Verify background stake preserved during activation + ctx.verify_background_stake_across_epochs(epochs_to_activate, background_effective) + .await; + + // Deactivate + ctx.deactivate_stake(&stake, &mut stake_account, &staker) + .await; + + let epochs_to_deactivate = ctx + .advance_until_fully_deactivated(&stake, &stake_account, 50) + .await; + + // Verify background stake preserved during deactivation + ctx.verify_background_stake_across_epochs(epochs_to_deactivate, background_effective) + .await; +} From 647046f1668168003b1575f6ddd5df975c71d72e Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 11:48:41 +0000 Subject: [PATCH 05/10] migrate Split tests --- program/tests/helpers/instruction_builders.rs | 21 ++ program/tests/helpers/utils.rs | 18 ++ program/tests/program_test.rs | 150 -------------- program/tests/split.rs | 190 ++++++++++++++++++ 4 files changed, 229 insertions(+), 150 deletions(-) create mode 100644 program/tests/split.rs diff --git a/program/tests/helpers/instruction_builders.rs b/program/tests/helpers/instruction_builders.rs index cc700115..192aacf0 100644 --- a/program/tests/helpers/instruction_builders.rs +++ b/program/tests/helpers/instruction_builders.rs @@ -138,3 +138,24 @@ impl InstructionConfig for DelegateConfig<'_> { ] } } + +pub struct SplitConfig<'a> { + pub source: (&'a Pubkey, &'a AccountSharedData), + pub destination: (&'a Pubkey, &'a AccountSharedData), + pub amount: u64, + pub signer: &'a Pubkey, +} + +impl InstructionConfig for SplitConfig<'_> { + fn build_instruction(&self, _ctx: &StakeTestContext) -> Instruction { + let instructions = ixn::split(self.source.0, self.signer, self.amount, self.destination.0); + instructions[2].clone() // The actual split instruction + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![ + (*self.source.0, self.source.1.clone()), + (*self.destination.0, self.destination.1.clone()), + ] + } +} diff --git a/program/tests/helpers/utils.rs b/program/tests/helpers/utils.rs index c83886cf..ee55f2ff 100644 --- a/program/tests/helpers/utils.rs +++ b/program/tests/helpers/utils.rs @@ -108,3 +108,21 @@ pub fn increment_vote_account_credits( vote_account.set_data(bincode::serialize(&vote_state).unwrap()); } + +/// Get the effective stake for an account +pub fn get_effective_stake(mollusk: &Mollusk, stake_account: &AccountSharedData) -> u64 { + let stake_state: StakeStateV2 = bincode::deserialize(stake_account.data()).unwrap(); + + if let StakeStateV2::Stake(_, stake, _) = stake_state { + stake + .delegation + .stake_activating_and_deactivating( + mollusk.sysvars.clock.epoch, + &mollusk.sysvars.stake_history, + Some(0), + ) + .effective + } else { + 0 + } +} diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs index 09c826ca..df127e56 100644 --- a/program/tests/program_test.rs +++ b/program/tests/program_test.rs @@ -740,156 +740,6 @@ impl StakeLifecycle { } } -#[test_case(StakeLifecycle::Uninitialized; "uninitialized")] -#[test_case(StakeLifecycle::Initialized; "initialized")] -#[test_case(StakeLifecycle::Activating; "activating")] -#[test_case(StakeLifecycle::Active; "active")] -#[test_case(StakeLifecycle::Deactivating; "deactivating")] -#[test_case(StakeLifecycle::Deactive; "deactive")] -#[tokio::test] -async fn program_test_split(split_source_type: StakeLifecycle) { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let rent_exempt_reserve = get_stake_account_rent(&mut context.banks_client).await; - let minimum_delegation = get_minimum_delegation(&mut context).await; - let staked_amount = minimum_delegation * 2; - - let (split_source_keypair, staker_keypair, _) = split_source_type - .new_stake_account(&mut context, &accounts.vote_account.pubkey(), staked_amount) - .await; - - let split_source = split_source_keypair.pubkey(); - let split_dest = create_blank_stake_account(&mut context).await; - - let signers = match split_source_type { - StakeLifecycle::Uninitialized => vec![&split_source_keypair], - _ => vec![&staker_keypair], - }; - - // fail, split more than available (even if not active, would kick source out of - // rent exemption) - let instruction = &ixn::split( - &split_source, - &signers[0].pubkey(), - staked_amount + 1, - &split_dest, - )[2]; - - let e = process_instruction(&mut context, instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InsufficientFunds); - - // an active or transitioning stake account cannot have less than the minimum - // delegation note this is NOT dependent on the minimum delegation feature. - // there was ALWAYS a minimum. it was one lamport! - if split_source_type.split_minimum_enforced() { - // zero split fails - let instruction = &ixn::split(&split_source, &signers[0].pubkey(), 0, &split_dest)[2]; - let e = process_instruction(&mut context, instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InsufficientFunds); - - // underfunded destination fails - let instruction = &ixn::split( - &split_source, - &signers[0].pubkey(), - minimum_delegation - 1, - &split_dest, - )[2]; - - let e = process_instruction(&mut context, instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InsufficientFunds); - - // underfunded source fails - let instruction = &ixn::split( - &split_source, - &signers[0].pubkey(), - minimum_delegation + 1, - &split_dest, - )[2]; - - let e = process_instruction(&mut context, instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InsufficientFunds); - } - - // split to non-owned account fails - let mut fake_split_dest_account = get_account(&mut context.banks_client, &split_dest).await; - fake_split_dest_account.owner = Pubkey::new_unique(); - let fake_split_dest = Pubkey::new_unique(); - context.set_account(&fake_split_dest, &fake_split_dest_account.into()); - - let instruction = &ixn::split( - &split_source, - &signers[0].pubkey(), - staked_amount / 2, - &fake_split_dest, - )[2]; - - let e = process_instruction(&mut context, instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountOwner); - - // success - let instruction = &ixn::split( - &split_source, - &signers[0].pubkey(), - staked_amount / 2, - &split_dest, - )[2]; - process_instruction_test_missing_signers(&mut context, instruction, &signers).await; - - // source lost split amount - let source_lamports = get_account(&mut context.banks_client, &split_source) - .await - .lamports; - assert_eq!(source_lamports, staked_amount / 2 + rent_exempt_reserve); - - // destination gained split amount - let dest_lamports = get_account(&mut context.banks_client, &split_dest) - .await - .lamports; - assert_eq!(dest_lamports, staked_amount / 2 + rent_exempt_reserve); - - // destination meta has been set properly if ever delegated - if split_source_type >= StakeLifecycle::Initialized { - let (source_meta, source_stake, _) = - get_stake_account(&mut context.banks_client, &split_source).await; - let (dest_meta, dest_stake, _) = - get_stake_account(&mut context.banks_client, &split_dest).await; - assert_eq!(dest_meta, source_meta); - - // delegations are set properly if activating or active - if split_source_type >= StakeLifecycle::Activating - && split_source_type < StakeLifecycle::Deactive - { - assert_eq!(source_stake.unwrap().delegation.stake, staked_amount / 2); - assert_eq!(dest_stake.unwrap().delegation.stake, staked_amount / 2); - } - } - - // nothing has been deactivated if active - if split_source_type >= StakeLifecycle::Active && split_source_type < StakeLifecycle::Deactive { - assert_eq!( - get_effective_stake(&mut context.banks_client, &split_source).await, - staked_amount / 2, - ); - - assert_eq!( - get_effective_stake(&mut context.banks_client, &split_dest).await, - staked_amount / 2, - ); - } -} - #[test_case(StakeLifecycle::Uninitialized; "uninitialized")] #[test_case(StakeLifecycle::Initialized; "initialized")] #[test_case(StakeLifecycle::Activating; "activating")] diff --git a/program/tests/split.rs b/program/tests/split.rs new file mode 100644 index 00000000..69db3435 --- /dev/null +++ b/program/tests/split.rs @@ -0,0 +1,190 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, + instruction_builders::SplitConfig, + lifecycle::StakeLifecycle, + utils::{get_effective_stake, parse_stake_account}, + }, + mollusk_svm::result::Check, + solana_account::{AccountSharedData, WritableAccount}, + solana_program_error::ProgramError, + solana_pubkey::Pubkey, + solana_stake_interface::state::StakeStateV2, + solana_stake_program::id, + test_case::test_case, +}; + +#[test_case(StakeLifecycle::Uninitialized; "uninitialized")] +#[test_case(StakeLifecycle::Initialized; "initialized")] +#[test_case(StakeLifecycle::Activating; "activating")] +#[test_case(StakeLifecycle::Active; "active")] +#[test_case(StakeLifecycle::Deactivating; "deactivating")] +#[test_case(StakeLifecycle::Deactive; "deactive")] +fn test_split(split_source_type: StakeLifecycle) { + let mut ctx = StakeTestContext::new(); + let staked_amount = ctx.minimum_delegation.unwrap() * 2; + + // Create source stake account at the specified lifecycle stage + let (split_source, mut split_source_account) = ctx + .stake_account(split_source_type) + .staked_amount(staked_amount) + .build(); + + // Create destination stake account matching what create_blank_stake_account does: + // rent-exempt lamports, correct size, stake program owner, uninitialized data + let split_dest = Pubkey::new_unique(); + let split_dest_account = + AccountSharedData::new(ctx.rent_exempt_reserve, StakeStateV2::size_of(), &id()); + + // Determine signer based on lifecycle stage + let signer = if split_source_type == StakeLifecycle::Uninitialized { + split_source + } else { + ctx.staker + }; + + // Fail: split more than available (would violate rent exemption) + // Note: Behavior differs between program-test and Mollusk: + // - program-test: Transaction-level rent check returns InsufficientFunds before program runs + // - Mollusk: Program succeeds for uninitialized (no program-level check), but violates rent + // For initialized+ accounts, the program itself checks and returns InsufficientFunds + if split_source_type == StakeLifecycle::Uninitialized { + // Mollusk: Program succeeds, but resulting accounts violate rent exemption + let result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| { + ctx.process_with(SplitConfig { + source: (&split_source, &split_source_account), + destination: (&split_dest, &split_dest_account), + signer: &signer, + amount: staked_amount + 1, + }) + .checks(&[Check::success(), Check::all_rent_exempt()]) + .execute() + })); + assert!( + result.is_err(), + "Expected rent exemption check to fail for uninitialized split" + ); + } else { + // Program-level check returns InsufficientFunds for initialized+ accounts + ctx.process_with(SplitConfig { + source: (&split_source, &split_source_account), + destination: (&split_dest, &split_dest_account), + signer: &signer, + amount: staked_amount + 1, + }) + .checks(&[Check::err(ProgramError::InsufficientFunds)]) + .test_missing_signers(false) + .execute(); + } + + // Test minimum delegation enforcement for active/transitioning stakes + if split_source_type.split_minimum_enforced() { + // Zero split fails + ctx.process_with(SplitConfig { + source: (&split_source, &split_source_account), + destination: (&split_dest, &split_dest_account), + signer: &signer, + amount: 0, + }) + .checks(&[Check::err(ProgramError::InsufficientFunds)]) + .test_missing_signers(false) + .execute(); + + // Underfunded destination fails + ctx.process_with(SplitConfig { + source: (&split_source, &split_source_account), + destination: (&split_dest, &split_dest_account), + signer: &signer, + amount: ctx.minimum_delegation.unwrap() - 1, + }) + .checks(&[Check::err(ProgramError::InsufficientFunds)]) + .test_missing_signers(false) + .execute(); + + // Underfunded source fails + ctx.process_with(SplitConfig { + source: (&split_source, &split_source_account), + destination: (&split_dest, &split_dest_account), + signer: &signer, + amount: ctx.minimum_delegation.unwrap() + 1, + }) + .checks(&[Check::err(ProgramError::InsufficientFunds)]) + .test_missing_signers(false) + .execute(); + } + + // Split to account with wrong owner fails + let fake_split_dest = Pubkey::new_unique(); + let mut fake_split_dest_account = split_dest_account.clone(); + fake_split_dest_account.set_owner(Pubkey::new_unique()); + + ctx.process_with(SplitConfig { + source: (&split_source, &split_source_account), + destination: (&fake_split_dest, &fake_split_dest_account), + signer: &signer, + amount: staked_amount / 2, + }) + .checks(&[Check::err(ProgramError::InvalidAccountOwner)]) + .test_missing_signers(false) + .execute(); + + // Success: split half + let result = ctx + .process_with(SplitConfig { + source: (&split_source, &split_source_account), + destination: (&split_dest, &split_dest_account), + signer: &signer, + amount: staked_amount / 2, + }) + .checks(&[ + Check::success(), + Check::all_rent_exempt(), + Check::account(&split_source) + .lamports(staked_amount / 2 + ctx.rent_exempt_reserve) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + Check::account(&split_dest) + .lamports(staked_amount / 2 + ctx.rent_exempt_reserve) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + ]) + .test_missing_signers(true) + .execute(); + + split_source_account = result.resulting_accounts[0].1.clone().into(); + let split_dest_account: AccountSharedData = result.resulting_accounts[1].1.clone().into(); + + // Verify metadata is copied for initialized and above + if split_source_type >= StakeLifecycle::Initialized { + let (source_meta, source_stake, _) = parse_stake_account(&split_source_account); + let (dest_meta, dest_stake, _) = parse_stake_account(&split_dest_account); + assert_eq!(dest_meta, source_meta); + + // Verify delegations are set properly for activating/active/deactivating + if split_source_type >= StakeLifecycle::Activating + && split_source_type < StakeLifecycle::Deactive + { + assert_eq!(source_stake.unwrap().delegation.stake, staked_amount / 2); + assert_eq!(dest_stake.unwrap().delegation.stake, staked_amount / 2); + } + } + + // Verify nothing has been deactivated for active stakes + if split_source_type >= StakeLifecycle::Active && split_source_type < StakeLifecycle::Deactive { + assert_eq!( + get_effective_stake(&ctx.mollusk, &split_source_account), + staked_amount / 2, + ); + + assert_eq!( + get_effective_stake(&ctx.mollusk, &split_dest_account), + staked_amount / 2, + ); + } +} From a8ca60405fa07152fd28b044b07bb0a9b5fc77f6 Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 11:59:20 +0000 Subject: [PATCH 06/10] migrate Withdraw tests --- program/tests/helpers/instruction_builders.rs | 22 ++ program/tests/program_test.rs | 177 +-------------- program/tests/withdraw.rs | 208 ++++++++++++++++++ 3 files changed, 231 insertions(+), 176 deletions(-) create mode 100644 program/tests/withdraw.rs diff --git a/program/tests/helpers/instruction_builders.rs b/program/tests/helpers/instruction_builders.rs index 192aacf0..1a85689e 100644 --- a/program/tests/helpers/instruction_builders.rs +++ b/program/tests/helpers/instruction_builders.rs @@ -159,3 +159,25 @@ impl InstructionConfig for SplitConfig<'_> { ] } } + +pub struct WithdrawConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + pub recipient: (&'a Pubkey, &'a AccountSharedData), + pub amount: u64, + /// Override signer for testing wrong signer scenarios (defaults to ctx.withdrawer) + pub override_signer: Option<&'a Pubkey>, +} + +impl InstructionConfig for WithdrawConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + let signer = self.override_signer.unwrap_or(&ctx.withdrawer); + ixn::withdraw(self.stake.0, signer, self.recipient.0, self.amount, None) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![ + (*self.stake.0, self.stake.1.clone()), + (*self.recipient.0, self.recipient.1.clone()), + ] + } +} diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs index df127e56..c0efd2fc 100644 --- a/program/tests/program_test.rs +++ b/program/tests/program_test.rs @@ -9,7 +9,6 @@ use { solana_program_error::ProgramError, solana_program_test::*, solana_pubkey::Pubkey, - solana_rent::Rent, solana_sdk_ids::system_program, solana_signer::Signer, solana_stake_interface::{ @@ -25,7 +24,7 @@ use { instruction as vote_instruction, state::{VoteInit, VoteStateV4}, }, - test_case::{test_case, test_matrix}, + test_case::test_matrix, }; pub const USER_STARTING_LAMPORTS: u64 = 10_000_000_000_000; // 10k sol @@ -740,180 +739,6 @@ impl StakeLifecycle { } } -#[test_case(StakeLifecycle::Uninitialized; "uninitialized")] -#[test_case(StakeLifecycle::Initialized; "initialized")] -#[test_case(StakeLifecycle::Activating; "activating")] -#[test_case(StakeLifecycle::Active; "active")] -#[test_case(StakeLifecycle::Deactivating; "deactivating")] -#[test_case(StakeLifecycle::Deactive; "deactive")] -#[test_case(StakeLifecycle::Closed; "closed")] -#[tokio::test] -async fn program_test_withdraw_stake(withdraw_source_type: StakeLifecycle) { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let stake_rent_exempt_reserve = get_stake_account_rent(&mut context.banks_client).await; - let minimum_delegation = get_minimum_delegation(&mut context).await; - let staked_amount = minimum_delegation; - - let wallet_rent_exempt_reserve = context - .banks_client - .get_rent() - .await - .unwrap() - .minimum_balance(0); - - let (withdraw_source_keypair, _, withdrawer_keypair) = withdraw_source_type - .new_stake_account(&mut context, &accounts.vote_account.pubkey(), staked_amount) - .await; - let withdraw_source = withdraw_source_keypair.pubkey(); - - let recipient = Pubkey::new_unique(); - transfer(&mut context, &recipient, wallet_rent_exempt_reserve).await; - - let signers = match withdraw_source_type { - StakeLifecycle::Uninitialized | StakeLifecycle::Closed => vec![&withdraw_source_keypair], - _ => vec![&withdrawer_keypair], - }; - - // withdraw that would end rent-exemption always fails - let rent_spillover = if withdraw_source_type == StakeLifecycle::Closed { - stake_rent_exempt_reserve - Rent::default().minimum_balance(0) + 1 - } else { - 1 - }; - - let instruction = ixn::withdraw( - &withdraw_source, - &signers[0].pubkey(), - &recipient, - staked_amount + rent_spillover, - None, - ); - let e = process_instruction(&mut context, &instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InsufficientFunds); - - if withdraw_source_type.withdraw_minimum_enforced() { - // withdraw active or activating stake fails - let instruction = ixn::withdraw( - &withdraw_source, - &signers[0].pubkey(), - &recipient, - staked_amount, - None, - ); - let e = process_instruction(&mut context, &instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InsufficientFunds); - - // grant rewards - let reward_amount = 10; - transfer(&mut context, &withdraw_source, reward_amount).await; - - // withdraw in excess of rewards is not allowed - let instruction = ixn::withdraw( - &withdraw_source, - &signers[0].pubkey(), - &recipient, - reward_amount + 1, - None, - ); - let e = process_instruction(&mut context, &instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InsufficientFunds); - - // withdraw rewards is allowed - let instruction = ixn::withdraw( - &withdraw_source, - &signers[0].pubkey(), - &recipient, - reward_amount, - None, - ); - process_instruction_test_missing_signers(&mut context, &instruction, &signers).await; - - let recipient_lamports = get_account(&mut context.banks_client, &recipient) - .await - .lamports; - assert_eq!( - recipient_lamports, - reward_amount + wallet_rent_exempt_reserve, - ); - } else { - // withdraw that leaves rent behind is allowed - let instruction = ixn::withdraw( - &withdraw_source, - &signers[0].pubkey(), - &recipient, - staked_amount, - None, - ); - process_instruction_test_missing_signers(&mut context, &instruction, &signers).await; - - let recipient_lamports = get_account(&mut context.banks_client, &recipient) - .await - .lamports; - assert_eq!( - recipient_lamports, - staked_amount + wallet_rent_exempt_reserve, - ); - - // full withdraw is allowed - refresh_blockhash(&mut context).await; - transfer(&mut context, &withdraw_source, staked_amount).await; - - let recipient = Pubkey::new_unique(); - transfer(&mut context, &recipient, wallet_rent_exempt_reserve).await; - - let instruction = ixn::withdraw( - &withdraw_source, - &signers[0].pubkey(), - &recipient, - staked_amount + stake_rent_exempt_reserve, - None, - ); - process_instruction_test_missing_signers(&mut context, &instruction, &signers).await; - - let recipient_lamports = get_account(&mut context.banks_client, &recipient) - .await - .lamports; - assert_eq!( - recipient_lamports, - staked_amount + stake_rent_exempt_reserve + wallet_rent_exempt_reserve, - ); - } - - // withdraw from program-owned non-stake not allowed - let rewards_pool_address = Pubkey::new_unique(); - let rewards_pool = SolanaAccount { - lamports: get_stake_account_rent(&mut context.banks_client).await + staked_amount, - data: bincode::serialize(&StakeStateV2::RewardsPool) - .unwrap() - .to_vec(), - owner: id(), - executable: false, - rent_epoch: u64::MAX, - }; - context.set_account(&rewards_pool_address, &rewards_pool.into()); - - let instruction = ixn::withdraw( - &rewards_pool_address, - &signers[0].pubkey(), - &recipient, - staked_amount, - None, - ); - let e = process_instruction(&mut context, &instruction, &signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountData); -} - // XXX the original test_merge is a stupid test // the real thing is test_merge_active_stake which actively controls clock and // stake_history but im just trying to smoke test rn so lets do something diff --git a/program/tests/withdraw.rs b/program/tests/withdraw.rs new file mode 100644 index 00000000..47b45b27 --- /dev/null +++ b/program/tests/withdraw.rs @@ -0,0 +1,208 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, instruction_builders::WithdrawConfig, lifecycle::StakeLifecycle, + }, + mollusk_svm::result::Check, + solana_account::{AccountSharedData, WritableAccount}, + solana_program_error::ProgramError, + solana_pubkey::Pubkey, + solana_rent::Rent, + solana_stake_interface::state::StakeStateV2, + solana_stake_program::id, + test_case::test_case, +}; + +#[test_case(StakeLifecycle::Uninitialized; "uninitialized")] +#[test_case(StakeLifecycle::Initialized; "initialized")] +#[test_case(StakeLifecycle::Activating; "activating")] +#[test_case(StakeLifecycle::Active; "active")] +#[test_case(StakeLifecycle::Deactivating; "deactivating")] +#[test_case(StakeLifecycle::Deactive; "deactive")] +#[test_case(StakeLifecycle::Closed; "closed")] +fn test_withdraw_stake(withdraw_source_type: StakeLifecycle) { + let mut ctx = StakeTestContext::new(); + let staked_amount = ctx.minimum_delegation; + let wallet_rent_exempt_reserve = Rent::default().minimum_balance(0); + + // Create source stake account at the specified lifecycle stage + let (withdraw_source, mut withdraw_source_account) = ctx + .stake_account(withdraw_source_type) + .staked_amount(staked_amount.unwrap()) + .build(); + + // Create recipient account + let recipient = Pubkey::new_unique(); + let mut recipient_account = AccountSharedData::default(); + recipient_account.set_lamports(wallet_rent_exempt_reserve); + + // Determine signer based on lifecycle stage + let signer = if withdraw_source_type == StakeLifecycle::Uninitialized + || withdraw_source_type == StakeLifecycle::Closed + { + withdraw_source // Self-signed for uninitialized/closed + } else { + ctx.withdrawer + }; + + // Withdraw that would end rent-exemption always fails + let rent_spillover = if withdraw_source_type == StakeLifecycle::Closed { + ctx.rent_exempt_reserve - Rent::default().minimum_balance(0) + 1 + } else { + 1 + }; + + // For initialized/delegated accounts, the program itself checks and fails with InsufficientFunds + // For uninitialized/closed accounts, the program succeeds but leaves accounts below rent exemption + if withdraw_source_type == StakeLifecycle::Uninitialized + || withdraw_source_type == StakeLifecycle::Closed + { + // Program success, but rent check should fail + let result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| { + ctx.process_with(WithdrawConfig { + stake: (&withdraw_source, &withdraw_source_account), + override_signer: Some(&signer), + recipient: (&recipient, &recipient_account), + amount: staked_amount.unwrap() + rent_spillover, + }) + .checks(&[Check::success(), Check::all_rent_exempt()]) + .execute() + })); + assert!( + result.is_err(), + "Expected rent exemption check to fail for uninitialized/closed withdraw" + ); + } else { + // Program fails with InsufficientFunds + ctx.process_with(WithdrawConfig { + stake: (&withdraw_source, &withdraw_source_account), + override_signer: Some(&signer), + recipient: (&recipient, &recipient_account), + amount: staked_amount.unwrap() + rent_spillover, + }) + .checks(&[Check::err(ProgramError::InsufficientFunds)]) + .execute(); + } + + if withdraw_source_type.withdraw_minimum_enforced() { + // Withdraw active or activating stake fails + ctx.process_with(WithdrawConfig { + stake: (&withdraw_source, &withdraw_source_account), + override_signer: Some(&signer), + recipient: (&recipient, &recipient_account), + amount: staked_amount.unwrap(), + }) + .checks(&[Check::err(ProgramError::InsufficientFunds)]) + .execute(); + + // Grant rewards + let reward_amount = 10; + withdraw_source_account + .checked_add_lamports(reward_amount) + .unwrap(); + + // Withdraw in excess of rewards is not allowed + ctx.process_with(WithdrawConfig { + stake: (&withdraw_source, &withdraw_source_account), + override_signer: Some(&signer), + recipient: (&recipient, &recipient_account), + amount: reward_amount + 1, + }) + .checks(&[Check::err(ProgramError::InsufficientFunds)]) + .execute(); + + // Withdraw rewards is allowed + ctx.process_with(WithdrawConfig { + stake: (&withdraw_source, &withdraw_source_account), + override_signer: Some(&signer), + recipient: (&recipient, &recipient_account), + amount: reward_amount, + }) + .checks(&[ + Check::success(), + Check::account(&recipient) + .lamports(reward_amount + wallet_rent_exempt_reserve) + .build(), + ]) + .test_missing_signers(true) + .execute(); + } else { + // Withdraw that leaves rent behind is allowed + let result = ctx + .process_with(WithdrawConfig { + stake: (&withdraw_source, &withdraw_source_account), + override_signer: Some(&signer), + recipient: (&recipient, &recipient_account), + amount: staked_amount.unwrap(), + }) + .checks(&[ + Check::success(), + Check::account(&recipient) + .lamports(staked_amount.unwrap() + wallet_rent_exempt_reserve) + .build(), + ]) + .test_missing_signers(true) + .execute(); + + withdraw_source_account = result.resulting_accounts[0].1.clone().into(); + + // Full withdraw is allowed (add back staked_amount) + withdraw_source_account + .checked_add_lamports(staked_amount.unwrap()) + .unwrap(); + + let recipient2 = Pubkey::new_unique(); + let mut recipient2_account = AccountSharedData::default(); + recipient2_account.set_lamports(wallet_rent_exempt_reserve); + + ctx.process_with(WithdrawConfig { + stake: (&withdraw_source, &withdraw_source_account), + override_signer: Some(&signer), + recipient: (&recipient2, &recipient2_account), + amount: staked_amount.unwrap() + ctx.rent_exempt_reserve, + }) + .checks(&[ + Check::success(), + Check::account(&recipient2) + .lamports( + staked_amount.unwrap() + ctx.rent_exempt_reserve + wallet_rent_exempt_reserve, + ) + .build(), + ]) + .test_missing_signers(true) + .execute(); + } +} + +#[test] +fn test_withdraw_from_rewards_pool() { + let ctx = StakeTestContext::new(); + let staked_amount = ctx.minimum_delegation; + + // Create a rewards pool account + let rewards_pool_address = Pubkey::new_unique(); + let rewards_pool_data = AccountSharedData::new_data_with_space( + ctx.rent_exempt_reserve + staked_amount.unwrap(), + &StakeStateV2::RewardsPool, + StakeStateV2::size_of(), + &id(), + ) + .unwrap(); + + let recipient = Pubkey::new_unique(); + let recipient_account = AccountSharedData::default(); + + // Withdraw from program-owned non-stake accounts is not allowed + ctx.process_with(WithdrawConfig { + stake: (&rewards_pool_address, &rewards_pool_data), + recipient: (&recipient, &recipient_account), + amount: staked_amount.unwrap(), + override_signer: None, + }) + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); +} From 1984966e8b8112816b9cbca9aa07dfb04535bbde Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 12:10:20 +0000 Subject: [PATCH 07/10] Merge tests, adjust test_missing_signers --- program/tests/helpers/instruction_builders.rs | 26 +++- program/tests/merge.rs | 109 ++++++++++++++++ program/tests/program_test.rs | 121 ------------------ 3 files changed, 132 insertions(+), 124 deletions(-) create mode 100644 program/tests/merge.rs diff --git a/program/tests/helpers/instruction_builders.rs b/program/tests/helpers/instruction_builders.rs index 1a85689e..8f4a8e92 100644 --- a/program/tests/helpers/instruction_builders.rs +++ b/program/tests/helpers/instruction_builders.rs @@ -36,14 +36,15 @@ impl<'b> InstructionExecution<'_, 'b> { self } - /// Executes the instruction. If `checks` is `None` or empty, uses `Check::success()`. + /// Executes the instruction. If `checks` is `None`, uses `Check::success()`. + /// If `checks` is `Some(&[])` (empty), runs without validation. /// When `test_missing_signers` is `None`, runs the missing-signers tests. /// Callers must explicitly opt out with `.test_missing_signers(false)`. pub fn execute(self) -> mollusk_svm::result::InstructionResult { let default_checks = [Check::success()]; let checks = match self.checks { - Some(c) if !c.is_empty() => c, - _ => &default_checks, + None => &default_checks, + Some(c) => c, }; let test_missing_signers = self.test_missing_signers.unwrap_or(true); @@ -139,6 +140,25 @@ impl InstructionConfig for DelegateConfig<'_> { } } +pub struct MergeConfig<'a> { + pub destination: (&'a Pubkey, &'a AccountSharedData), + pub source: (&'a Pubkey, &'a AccountSharedData), +} + +impl InstructionConfig for MergeConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + let instructions = ixn::merge(self.destination.0, self.source.0, &ctx.staker); + instructions[0].clone() // Merge returns a Vec, use first instruction + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![ + (*self.destination.0, self.destination.1.clone()), + (*self.source.0, self.source.1.clone()), + ] + } +} + pub struct SplitConfig<'a> { pub source: (&'a Pubkey, &'a AccountSharedData), pub destination: (&'a Pubkey, &'a AccountSharedData), diff --git a/program/tests/merge.rs b/program/tests/merge.rs new file mode 100644 index 00000000..625a34f6 --- /dev/null +++ b/program/tests/merge.rs @@ -0,0 +1,109 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, instruction_builders::MergeConfig, lifecycle::StakeLifecycle, + }, + mollusk_svm::result::Check, + solana_account::ReadableAccount, + solana_stake_interface::state::StakeStateV2, + solana_stake_program::id, + test_case::test_matrix, +}; + +#[test_matrix( + [StakeLifecycle::Uninitialized, StakeLifecycle::Initialized, StakeLifecycle::Activating, + StakeLifecycle::Active, StakeLifecycle::Deactivating, StakeLifecycle::Deactive], + [StakeLifecycle::Uninitialized, StakeLifecycle::Initialized, StakeLifecycle::Activating, + StakeLifecycle::Active, StakeLifecycle::Deactivating, StakeLifecycle::Deactive] +)] +fn test_merge(merge_source_type: StakeLifecycle, merge_dest_type: StakeLifecycle) { + let mut ctx = StakeTestContext::new(); + + let staked_amount = ctx.minimum_delegation; + + // Determine if merge should be allowed based on lifecycle types + let is_merge_allowed_by_type = match (merge_source_type, merge_dest_type) { + // Inactive and inactive + (StakeLifecycle::Initialized, StakeLifecycle::Initialized) + | (StakeLifecycle::Initialized, StakeLifecycle::Deactive) + | (StakeLifecycle::Deactive, StakeLifecycle::Initialized) + | (StakeLifecycle::Deactive, StakeLifecycle::Deactive) => true, + + // Activating into inactive is also allowed + (StakeLifecycle::Activating, StakeLifecycle::Initialized) + | (StakeLifecycle::Activating, StakeLifecycle::Deactive) => true, + + // Inactive into activating + (StakeLifecycle::Initialized, StakeLifecycle::Activating) + | (StakeLifecycle::Deactive, StakeLifecycle::Activating) => true, + + // Active and active + (StakeLifecycle::Active, StakeLifecycle::Active) => true, + + // Activating and activating + (StakeLifecycle::Activating, StakeLifecycle::Activating) => true, + + // Everything else fails + _ => false, + }; + + // Create source and dest accounts + let (merge_source, mut merge_source_account) = ctx + .stake_account(merge_source_type) + .staked_amount(staked_amount.unwrap()) + .build(); + let (merge_dest, merge_dest_account) = ctx + .stake_account(merge_dest_type) + .staked_amount(staked_amount.unwrap()) + .build(); + + // Retrieve source data and sync epochs if needed + let mut source_stake_state: StakeStateV2 = + bincode::deserialize(merge_source_account.data()).unwrap(); + + let clock = ctx.mollusk.sysvars.clock.clone(); + // Sync epochs for transient states + if let StakeStateV2::Stake(_, ref mut stake, _) = &mut source_stake_state { + match merge_source_type { + StakeLifecycle::Activating => stake.delegation.activation_epoch = clock.epoch, + StakeLifecycle::Deactivating => stake.delegation.deactivation_epoch = clock.epoch, + _ => (), + } + } + + // Store updated source + merge_source_account.set_data(bincode::serialize(&source_stake_state).unwrap()); + + // Attempt to merge + if is_merge_allowed_by_type { + ctx.process_with(MergeConfig { + destination: (&merge_dest, &merge_dest_account), + source: (&merge_source, &merge_source_account), + }) + .checks(&[ + Check::success(), + Check::account(&merge_dest) + .lamports(staked_amount.unwrap() * 2 + ctx.rent_exempt_reserve * 2) + .owner(&id()) + .space(StakeStateV2::size_of()) + .rent_exempt() + .build(), + ]) + .test_missing_signers(true) + .execute(); + } else { + // Various errors can occur for invalid merges, we just check it fails + let result = ctx + .process_with(MergeConfig { + destination: (&merge_dest, &merge_dest_account), + source: (&merge_source, &merge_source_account), + }) + .checks(&[]) // Skip Success check + .test_missing_signers(false) + .execute(); + assert!(result.program_result.is_err()); + } +} diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs index c0efd2fc..c3dea863 100644 --- a/program/tests/program_test.rs +++ b/program/tests/program_test.rs @@ -739,127 +739,6 @@ impl StakeLifecycle { } } -// XXX the original test_merge is a stupid test -// the real thing is test_merge_active_stake which actively controls clock and -// stake_history but im just trying to smoke test rn so lets do something -// simpler -#[test_matrix( - [StakeLifecycle::Uninitialized, StakeLifecycle::Initialized, StakeLifecycle::Activating, - StakeLifecycle::Active, StakeLifecycle::Deactivating, StakeLifecycle::Deactive], - [StakeLifecycle::Uninitialized, StakeLifecycle::Initialized, StakeLifecycle::Activating, - StakeLifecycle::Active, StakeLifecycle::Deactivating, StakeLifecycle::Deactive] -)] -#[tokio::test] -async fn program_test_merge(merge_source_type: StakeLifecycle, merge_dest_type: StakeLifecycle) { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let rent_exempt_reserve = get_stake_account_rent(&mut context.banks_client).await; - let minimum_delegation = get_minimum_delegation(&mut context).await; - let staked_amount = minimum_delegation; - - // stake accounts can be merged unconditionally: - // * inactive and inactive - // * inactive into activating - // can be merged IF vote pubkey and credits match: - // * active and active - // * activating and activating, IF activating in the same epoch - // in all cases, authorized and lockup also must match - // uninitialized stakes cannot be merged at all - let is_merge_allowed_by_type = match (merge_source_type, merge_dest_type) { - // inactive and inactive - (StakeLifecycle::Initialized, StakeLifecycle::Initialized) - | (StakeLifecycle::Initialized, StakeLifecycle::Deactive) - | (StakeLifecycle::Deactive, StakeLifecycle::Initialized) - | (StakeLifecycle::Deactive, StakeLifecycle::Deactive) => true, - - // activating into inactive is also allowed although this isnt clear from docs - (StakeLifecycle::Activating, StakeLifecycle::Initialized) - | (StakeLifecycle::Activating, StakeLifecycle::Deactive) => true, - - // inactive into activating - (StakeLifecycle::Initialized, StakeLifecycle::Activating) - | (StakeLifecycle::Deactive, StakeLifecycle::Activating) => true, - - // active and active - (StakeLifecycle::Active, StakeLifecycle::Active) => true, - - // activating and activating - (StakeLifecycle::Activating, StakeLifecycle::Activating) => true, - - // better luck next time - _ => false, - }; - - // create source first - let (merge_source_keypair, _, _) = merge_source_type - .new_stake_account(&mut context, &accounts.vote_account.pubkey(), staked_amount) - .await; - let merge_source = merge_source_keypair.pubkey(); - - // retrieve its data - let mut source_account = get_account(&mut context.banks_client, &merge_source).await; - let mut source_stake_state: StakeStateV2 = bincode::deserialize(&source_account.data).unwrap(); - - // create dest. this may mess source up if its in a transient state, but its - // fine - let (merge_dest_keypair, staker_keypair, withdrawer_keypair) = merge_dest_type - .new_stake_account(&mut context, &accounts.vote_account.pubkey(), staked_amount) - .await; - let merge_dest = merge_dest_keypair.pubkey(); - - // now we change source authorized to match dest - // we can also true up the epoch if source should have been transient - let clock = context.banks_client.get_sysvar::().await.unwrap(); - match &mut source_stake_state { - StakeStateV2::Initialized(ref mut meta) => { - meta.authorized.staker = staker_keypair.pubkey(); - meta.authorized.withdrawer = withdrawer_keypair.pubkey(); - } - StakeStateV2::Stake(ref mut meta, ref mut stake, _) => { - meta.authorized.staker = staker_keypair.pubkey(); - meta.authorized.withdrawer = withdrawer_keypair.pubkey(); - - match merge_source_type { - StakeLifecycle::Activating => stake.delegation.activation_epoch = clock.epoch, - StakeLifecycle::Deactivating => stake.delegation.deactivation_epoch = clock.epoch, - _ => (), - } - } - _ => (), - } - - // and store - source_account.data = bincode::serialize(&source_stake_state).unwrap(); - context.set_account(&merge_source, &source_account.into()); - - // attempt to merge - let instruction = ixn::merge(&merge_dest, &merge_source, &staker_keypair.pubkey()) - .into_iter() - .next() - .unwrap(); - - // failure can result in various different errors... dont worry about it for now - if is_merge_allowed_by_type { - process_instruction_test_missing_signers( - &mut context, - &instruction, - &vec![&staker_keypair], - ) - .await; - - let dest_lamports = get_account(&mut context.banks_client, &merge_dest) - .await - .lamports; - assert_eq!(dest_lamports, staked_amount * 2 + rent_exempt_reserve * 2); - } else { - process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - } -} - #[test_matrix( [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, StakeLifecycle::Deactivating, StakeLifecycle::Deactive], From 8bbc6977b594f6cc3c913be41dae6cc8ba6f2305 Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 12:20:56 +0000 Subject: [PATCH 08/10] migrate MoveLamports test --- program/tests/helpers/instruction_builders.rs | 70 +++ program/tests/helpers/utils.rs | 39 ++ program/tests/move_lamports.rs | 426 ++++++++++++++++++ program/tests/program_test.rs | 214 --------- 4 files changed, 535 insertions(+), 214 deletions(-) create mode 100644 program/tests/move_lamports.rs diff --git a/program/tests/helpers/instruction_builders.rs b/program/tests/helpers/instruction_builders.rs index 8f4a8e92..5953ac26 100644 --- a/program/tests/helpers/instruction_builders.rs +++ b/program/tests/helpers/instruction_builders.rs @@ -159,6 +159,76 @@ impl InstructionConfig for MergeConfig<'_> { } } +pub struct MoveLamportsConfig<'a> { + pub source: (&'a Pubkey, &'a AccountSharedData), + pub destination: (&'a Pubkey, &'a AccountSharedData), + pub amount: u64, + /// Override signer for testing wrong signer scenarios (defaults to ctx.staker) + pub override_signer: Option<&'a Pubkey>, +} + +impl<'a> MoveLamportsConfig<'a> { + /// Helper to get the default source vote account from context + pub fn with_default_vote(self, ctx: &'a StakeTestContext) -> MoveLamportsFullConfig<'a> { + MoveLamportsFullConfig { + source: self.source, + destination: self.destination, + override_signer: self.override_signer, + amount: self.amount, + source_vote: ( + ctx.vote_account.as_ref().expect("vote_account required"), + ctx.vote_account_data + .as_ref() + .expect("vote_account_data required"), + ), + dest_vote: None, + } + } +} + +impl InstructionConfig for MoveLamportsConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + let signer = self.override_signer.unwrap_or(&ctx.staker); + ixn::move_lamports(self.source.0, self.destination.0, signer, self.amount) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![ + (*self.source.0, self.source.1.clone()), + (*self.destination.0, self.destination.1.clone()), + ] + } +} + +pub struct MoveLamportsFullConfig<'a> { + pub source: (&'a Pubkey, &'a AccountSharedData), + pub destination: (&'a Pubkey, &'a AccountSharedData), + pub amount: u64, + /// Override signer for testing wrong signer scenarios (defaults to ctx.staker) + pub override_signer: Option<&'a Pubkey>, + pub source_vote: (&'a Pubkey, &'a AccountSharedData), + pub dest_vote: Option<(&'a Pubkey, &'a AccountSharedData)>, +} + +impl InstructionConfig for MoveLamportsFullConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + let signer = self.override_signer.unwrap_or(&ctx.staker); + ixn::move_lamports(self.source.0, self.destination.0, signer, self.amount) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + let mut accounts = vec![ + (*self.source.0, self.source.1.clone()), + (*self.destination.0, self.destination.1.clone()), + (*self.source_vote.0, self.source_vote.1.clone()), + ]; + if let Some((vote_pk, vote_acc)) = self.dest_vote { + accounts.push((*vote_pk, vote_acc.clone())); + } + accounts + } +} + pub struct SplitConfig<'a> { pub source: (&'a Pubkey, &'a AccountSharedData), pub destination: (&'a Pubkey, &'a AccountSharedData), diff --git a/program/tests/helpers/utils.rs b/program/tests/helpers/utils.rs index ee55f2ff..5b925a4e 100644 --- a/program/tests/helpers/utils.rs +++ b/program/tests/helpers/utils.rs @@ -1,4 +1,5 @@ use { + crate::helpers::{lifecycle::StakeLifecycle, stake_tracker::StakeTracker}, mollusk_svm::Mollusk, solana_account::{Account, AccountSharedData, ReadableAccount, WritableAccount}, solana_clock::Epoch, @@ -126,3 +127,41 @@ pub fn get_effective_stake(mollusk: &Mollusk, stake_account: &AccountSharedData) 0 } } + +/// Synchronize a transient stake's epoch to the current epoch +/// Updates both the account data and the tracker. +pub fn true_up_transient_stake_epoch( + mollusk: &mut Mollusk, + tracker: &mut StakeTracker, + stake_pubkey: &Pubkey, + stake_account: &mut AccountSharedData, + lifecycle: StakeLifecycle, +) { + if lifecycle != StakeLifecycle::Activating && lifecycle != StakeLifecycle::Deactivating { + return; + } + + let clock = mollusk.sysvars.clock.clone(); + let mut stake_state: StakeStateV2 = bincode::deserialize(stake_account.data()).unwrap(); + + if let StakeStateV2::Stake(_, ref mut stake, _) = &mut stake_state { + match lifecycle { + StakeLifecycle::Activating => { + stake.delegation.activation_epoch = clock.epoch; + + // Update tracker as well + if let Some(tracked) = tracker.delegations.get_mut(stake_pubkey) { + tracked.activation_epoch = clock.epoch; + } + } + StakeLifecycle::Deactivating => { + stake.delegation.deactivation_epoch = clock.epoch; + + // Update tracker as well + tracker.track_deactivation(stake_pubkey, clock.epoch); + } + _ => (), + } + } + stake_account.set_data(bincode::serialize(&stake_state).unwrap()); +} diff --git a/program/tests/move_lamports.rs b/program/tests/move_lamports.rs new file mode 100644 index 00000000..389b6922 --- /dev/null +++ b/program/tests/move_lamports.rs @@ -0,0 +1,426 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, + instruction_builders::{MoveLamportsConfig, MoveLamportsFullConfig}, + lifecycle::StakeLifecycle, + utils::{get_effective_stake, parse_stake_account, true_up_transient_stake_epoch}, + }, + mollusk_svm::result::Check, + solana_account::WritableAccount, + solana_program_error::ProgramError, + solana_stake_interface::{error::StakeError, state::Lockup}, + test_case::test_matrix, +}; + +#[test_matrix( + [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, + StakeLifecycle::Deactivating, StakeLifecycle::Deactive], + [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, + StakeLifecycle::Deactivating, StakeLifecycle::Deactive], + [false, true], + [false, true] +)] +fn test_move_lamports( + move_source_type: StakeLifecycle, + move_dest_type: StakeLifecycle, + different_votes: bool, + has_lockup: bool, +) { + let mut ctx = StakeTestContext::new(); + let min_delegation = ctx.minimum_delegation.unwrap(); + + // Put minimum in both accounts if they're active + let source_staked_amount = if move_source_type == StakeLifecycle::Active { + min_delegation + } else { + 0 + }; + + let dest_staked_amount = if move_dest_type == StakeLifecycle::Active { + min_delegation + } else { + 0 + }; + + // Test with and without lockup + let lockup = if has_lockup { + ctx.create_future_lockup(100) + } else { + Lockup::default() + }; + + // We put an extra minimum in every account, unstaked, to test moving them + let source_excess = min_delegation; + let dest_excess = min_delegation; + + let source_vote_account = ctx.vote_account.unwrap(); + let source_vote_account_data = ctx.vote_account_data.as_ref().unwrap().clone(); + + // Dest vote account (possibly different) + let (dest_vote_account, dest_vote_account_data) = if different_votes { + ctx.create_second_vote_account() + } else { + (source_vote_account, source_vote_account_data.clone()) + }; + + // Create source and dest stakes + let (move_source, mut move_source_account) = ctx + .stake_account(move_source_type) + .staked_amount(min_delegation) + .lockup(&lockup) + .build(); + + let (move_dest, mut move_dest_account) = if different_votes { + // Create with different vote account + ctx.stake_account(move_dest_type) + .staked_amount(min_delegation) + .vote_account(&dest_vote_account) + .lockup(&lockup) + .build() + } else { + ctx.stake_account(move_dest_type) + .staked_amount(min_delegation) + .lockup(&lockup) + .build() + }; + + // True up source epoch if transient (like original test) + // This ensures both stakes are in the current epoch context + true_up_transient_stake_epoch( + &mut ctx.mollusk, + ctx.tracker.as_mut().unwrap(), + &move_source, + &mut move_source_account, + move_source_type, + ); + + // Add excess lamports if Active (like original test) + if move_source_type == StakeLifecycle::Active { + move_source_account + .checked_add_lamports(source_excess) + .unwrap(); + } + if move_dest_type == StakeLifecycle::Active { + move_dest_account.checked_add_lamports(dest_excess).unwrap(); + } + + // Clear out state failures (activating/deactivating not allowed) + if move_source_type == StakeLifecycle::Activating + || move_source_type == StakeLifecycle::Deactivating + || move_dest_type == StakeLifecycle::Deactivating + { + let result = ctx + .process_with(MoveLamportsFullConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + override_signer: Some(&ctx.staker), + amount: source_excess, + source_vote: (&source_vote_account, &source_vote_account_data), + dest_vote: if different_votes { + Some((&dest_vote_account, &dest_vote_account_data)) + } else { + None + }, + }) + .checks(&[]) + .test_missing_signers(false) + .execute(); + assert!(result.program_result.is_err()); + return; + } + + // Overshoot and fail for underfunded source + ctx.process_with(MoveLamportsFullConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + override_signer: Some(&ctx.staker), + amount: source_excess + 1, + source_vote: (&source_vote_account, &source_vote_account_data), + dest_vote: if different_votes { + Some((&dest_vote_account, &dest_vote_account_data)) + } else { + None + }, + }) + .checks(&[Check::err(ProgramError::InvalidArgument)]) + .test_missing_signers(false) + .execute(); + + let before_source_lamports = parse_stake_account(&move_source_account).2; + let before_dest_lamports = parse_stake_account(&move_dest_account).2; + + // Now properly move the full excess + let result = ctx + .process_with(MoveLamportsFullConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + override_signer: Some(&ctx.staker), + amount: source_excess, + source_vote: (&source_vote_account, &source_vote_account_data), + dest_vote: if different_votes { + Some((&dest_vote_account, &dest_vote_account_data)) + } else { + None + }, + }) + .checks(&[Check::success()]) + .test_missing_signers(true) + .execute(); + + move_source_account = result.resulting_accounts[0].1.clone().into(); + move_dest_account = result.resulting_accounts[1].1.clone().into(); + + let after_source_lamports = parse_stake_account(&move_source_account).2; + let source_effective_stake = get_effective_stake(&ctx.mollusk, &move_source_account); + + // Source activation didn't change + assert_eq!(source_effective_stake, source_staked_amount); + + // Source lamports are right + assert_eq!( + after_source_lamports, + before_source_lamports - min_delegation + ); + assert_eq!( + after_source_lamports, + source_effective_stake + ctx.rent_exempt_reserve + ); + + let after_dest_lamports = parse_stake_account(&move_dest_account).2; + let dest_effective_stake = get_effective_stake(&ctx.mollusk, &move_dest_account); + + // Dest activation didn't change + assert_eq!(dest_effective_stake, dest_staked_amount); + + // Dest lamports are right + assert_eq!(after_dest_lamports, before_dest_lamports + min_delegation); + assert_eq!( + after_dest_lamports, + dest_effective_stake + ctx.rent_exempt_reserve + source_excess + dest_excess + ); +} + +#[test_matrix( + [(StakeLifecycle::Active, StakeLifecycle::Uninitialized), + (StakeLifecycle::Uninitialized, StakeLifecycle::Initialized), + (StakeLifecycle::Uninitialized, StakeLifecycle::Uninitialized)] +)] +fn test_move_lamports_uninitialized_fail(move_types: (StakeLifecycle, StakeLifecycle)) { + let mut ctx = StakeTestContext::new(); + let min_delegation = ctx.minimum_delegation.unwrap(); + let source_staked_amount = min_delegation * 2; + let (move_source_type, move_dest_type) = move_types; + + let (move_source, move_source_account) = ctx + .stake_account(move_source_type) + .staked_amount(source_staked_amount) + .build(); + let (move_dest, move_dest_account) = ctx.stake_account(move_dest_type).staked_amount(0).build(); + + let source_signer = if move_source_type == StakeLifecycle::Uninitialized { + move_source + } else { + ctx.staker + }; + + let vote_account = ctx.vote_account.unwrap(); + let vote_account_data = ctx.vote_account_data.as_ref().unwrap().clone(); + + ctx.process_with(MoveLamportsFullConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + override_signer: Some(&source_signer), + amount: min_delegation, + source_vote: (&vote_account, &vote_account_data), + dest_vote: None, + }) + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); +} + +#[test_matrix( + [StakeLifecycle::Initialized, StakeLifecycle::Active, StakeLifecycle::Deactive], + [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, StakeLifecycle::Deactive] +)] +fn test_move_lamports_general_fail( + move_source_type: StakeLifecycle, + move_dest_type: StakeLifecycle, +) { + let mut ctx = StakeTestContext::new(); + let min_delegation = ctx.minimum_delegation.unwrap(); + let source_staked_amount = min_delegation * 2; + let vote_account = ctx.vote_account.unwrap(); + let vote_account_data = ctx.vote_account_data.as_ref().unwrap().clone(); + let in_force_lockup = ctx.create_in_force_lockup(); + + // Create source + let (move_source, mut move_source_account) = ctx + .stake_account(move_source_type) + .staked_amount(source_staked_amount) + .build(); + move_source_account + .checked_add_lamports(min_delegation) + .unwrap(); + + // Self-move fails + ctx.process_with(MoveLamportsConfig { + source: (&move_source, &move_source_account), + destination: (&move_source, &move_source_account), + override_signer: None, + amount: min_delegation, + }) + .checks(&[Check::err(ProgramError::InvalidInstructionData)]) + .test_missing_signers(false) + .execute(); + + // Zero move fails + let (move_dest, mut move_dest_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .build(); + + // True up dest epoch if transient + true_up_transient_stake_epoch( + &mut ctx.mollusk, + ctx.tracker.as_mut().unwrap(), + &move_dest, + &mut move_dest_account, + move_dest_type, + ); + + ctx.process_with(MoveLamportsConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + override_signer: None, + amount: 0, + }) + .checks(&[Check::err(ProgramError::InvalidArgument)]) + .test_missing_signers(false) + .execute(); + + // Sign with withdrawer fails + let withdrawer = ctx.withdrawer; + ctx.process_with(MoveLamportsFullConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + override_signer: Some(&withdrawer), + amount: min_delegation, + source_vote: (&vote_account, &vote_account_data), + dest_vote: None, + }) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Source lockup fails + let (move_locked_source, mut move_locked_source_account) = ctx + .stake_account(move_source_type) + .staked_amount(source_staked_amount) + .lockup(&in_force_lockup) + .build(); + move_locked_source_account + .checked_add_lamports(min_delegation) + .unwrap(); + + let (move_dest2, move_dest2_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .build(); + + ctx.process_with(MoveLamportsConfig { + source: (&move_locked_source, &move_locked_source_account), + destination: (&move_dest2, &move_dest2_account), + override_signer: None, + amount: min_delegation, + }) + .checks(&[Check::err(StakeError::MergeMismatch.into())]) + .test_missing_signers(false) + .execute(); + + // Staker mismatch fails + let throwaway_staker = solana_pubkey::Pubkey::new_unique(); + let (move_dest3, move_dest3_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .stake_authority(&throwaway_staker) + .withdraw_authority(&withdrawer) + .build(); + + ctx.process_with(MoveLamportsConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest3, &move_dest3_account), + override_signer: None, + amount: min_delegation, + }) + .checks(&[Check::err(StakeError::MergeMismatch.into())]) + .test_missing_signers(false) + .execute(); + + // Also verify signing with dest's staker fails (wrong signer for source) + ctx.process_with(MoveLamportsFullConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest3, &move_dest3_account), + override_signer: Some(&throwaway_staker), + amount: min_delegation, + source_vote: (&vote_account, &vote_account_data), + dest_vote: None, + }) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Withdrawer mismatch fails + let throwaway_withdrawer = solana_pubkey::Pubkey::new_unique(); + let staker = ctx.staker; + let (move_dest4, move_dest4_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .stake_authority(&staker) + .withdraw_authority(&throwaway_withdrawer) + .build(); + + ctx.process_with(MoveLamportsConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest4, &move_dest4_account), + override_signer: None, + amount: min_delegation, + }) + .checks(&[Check::err(StakeError::MergeMismatch.into())]) + .test_missing_signers(false) + .execute(); + + // Also verify signing with dest's withdrawer fails (wrong signer for source) + ctx.process_with(MoveLamportsFullConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest4, &move_dest4_account), + override_signer: Some(&throwaway_withdrawer), + amount: min_delegation, + source_vote: (&vote_account, &vote_account_data), + dest_vote: None, + }) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Dest lockup fails + let (move_dest5, move_dest5_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .lockup(&in_force_lockup) + .build(); + + ctx.process_with(MoveLamportsConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest5, &move_dest5_account), + override_signer: None, + amount: min_delegation, + }) + .checks(&[Check::err(StakeError::MergeMismatch.into())]) + .test_missing_signers(false) + .execute(); +} diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs index c3dea863..f17e907a 100644 --- a/program/tests/program_test.rs +++ b/program/tests/program_test.rs @@ -992,220 +992,6 @@ async fn program_test_move_stake( } } -#[test_matrix( - [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, - StakeLifecycle::Deactivating, StakeLifecycle::Deactive], - [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, - StakeLifecycle::Deactivating, StakeLifecycle::Deactive], - [false, true], - [false, true] -)] -#[tokio::test] -async fn program_test_move_lamports( - move_source_type: StakeLifecycle, - move_dest_type: StakeLifecycle, - different_votes: bool, - has_lockup: bool, -) { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let rent_exempt_reserve = get_stake_account_rent(&mut context.banks_client).await; - let minimum_delegation = get_minimum_delegation(&mut context).await; - - // put minimum in both accounts if theyre active - let source_staked_amount = if move_source_type == StakeLifecycle::Active { - minimum_delegation - } else { - 0 - }; - - let dest_staked_amount = if move_dest_type == StakeLifecycle::Active { - minimum_delegation - } else { - 0 - }; - - // test with and without lockup. both of these cases pass, we test failures - // elsewhere - let lockup = if has_lockup { - let clock = context.banks_client.get_sysvar::().await.unwrap(); - let lockup = Lockup { - unix_timestamp: 0, - epoch: clock.epoch + 100, - custodian: Pubkey::new_unique(), - }; - - assert!(lockup.is_in_force(&clock, None)); - lockup - } else { - Lockup::default() - }; - - // we put an extra minimum in every account, unstaked, to test moving them - let source_excess = minimum_delegation; - let dest_excess = minimum_delegation; - - let move_source_keypair = Keypair::new(); - let move_dest_keypair = Keypair::new(); - let staker_keypair = Keypair::new(); - let withdrawer_keypair = Keypair::new(); - - // make a separate vote account if needed - let dest_vote_account = if different_votes { - let vote_account = Keypair::new(); - create_vote( - &mut context, - &Keypair::new(), - &Pubkey::new_unique(), - &Pubkey::new_unique(), - &vote_account, - ) - .await; - - vote_account.pubkey() - } else { - accounts.vote_account.pubkey() - }; - - // create source stake - move_source_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - minimum_delegation, - &move_source_keypair, - &staker_keypair, - &withdrawer_keypair, - &lockup, - ) - .await; - let move_source = move_source_keypair.pubkey(); - let mut source_account = get_account(&mut context.banks_client, &move_source).await; - let mut source_stake_state: StakeStateV2 = bincode::deserialize(&source_account.data).unwrap(); - - // create dest stake with same authorities - move_dest_type - .new_stake_account_fully_specified( - &mut context, - &dest_vote_account, - minimum_delegation, - &move_dest_keypair, - &staker_keypair, - &withdrawer_keypair, - &lockup, - ) - .await; - let move_dest = move_dest_keypair.pubkey(); - - // true up source epoch if transient - if move_source_type == StakeLifecycle::Activating - || move_source_type == StakeLifecycle::Deactivating - { - let clock = context.banks_client.get_sysvar::().await.unwrap(); - if let StakeStateV2::Stake(_, ref mut stake, _) = &mut source_stake_state { - match move_source_type { - StakeLifecycle::Activating => stake.delegation.activation_epoch = clock.epoch, - StakeLifecycle::Deactivating => stake.delegation.deactivation_epoch = clock.epoch, - _ => (), - } - } - - source_account.data = bincode::serialize(&source_stake_state).unwrap(); - context.set_account(&move_source, &source_account.into()); - } - - // if we activated the initial amount we need to top up with the test lamports - if move_source_type == StakeLifecycle::Active { - transfer(&mut context, &move_source, source_excess).await; - } - if move_dest_type == StakeLifecycle::Active { - transfer(&mut context, &move_dest, dest_excess).await; - } - - // clear out state failures - if move_source_type == StakeLifecycle::Activating - || move_source_type == StakeLifecycle::Deactivating - || move_dest_type == StakeLifecycle::Deactivating - { - let instruction = ixn::move_lamports( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - source_excess, - ); - - process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - return; - } - - // overshoot and fail for underfunded source - let instruction = ixn::move_lamports( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - source_excess + 1, - ); - - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidArgument); - - let (_, _, before_source_lamports) = - get_stake_account(&mut context.banks_client, &move_source).await; - let (_, _, before_dest_lamports) = - get_stake_account(&mut context.banks_client, &move_dest).await; - - // now properly move the full excess - let instruction = ixn::move_lamports( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - source_excess, - ); - - process_instruction_test_missing_signers(&mut context, &instruction, &vec![&staker_keypair]) - .await; - - let (_, _, after_source_lamports) = - get_stake_account(&mut context.banks_client, &move_source).await; - let source_effective_stake = get_effective_stake(&mut context.banks_client, &move_source).await; - - // source activation didnt change - assert_eq!(source_effective_stake, source_staked_amount); - - // source lamports are right - assert_eq!( - after_source_lamports, - before_source_lamports - minimum_delegation - ); - assert_eq!( - after_source_lamports, - source_effective_stake + rent_exempt_reserve - ); - - let (_, _, after_dest_lamports) = - get_stake_account(&mut context.banks_client, &move_dest).await; - let dest_effective_stake = get_effective_stake(&mut context.banks_client, &move_dest).await; - - // dest activation didnt change - assert_eq!(dest_effective_stake, dest_staked_amount); - - // dest lamports are right - assert_eq!( - after_dest_lamports, - before_dest_lamports + minimum_delegation - ); - assert_eq!( - after_dest_lamports, - dest_effective_stake + rent_exempt_reserve + source_excess + dest_excess - ); -} - #[test_matrix( [(StakeLifecycle::Active, StakeLifecycle::Uninitialized), (StakeLifecycle::Uninitialized, StakeLifecycle::Initialized), From 17943f27dde219cf5d292bdfe40b273a51aeebbf Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 12:28:46 +0000 Subject: [PATCH 09/10] migrate MoveStake tests --- program/tests/helpers/instruction_builders.rs | 70 ++ program/tests/move_stake.rs | 457 +++++++++++++ program/tests/program_test.rs | 626 ------------------ 3 files changed, 527 insertions(+), 626 deletions(-) create mode 100644 program/tests/move_stake.rs diff --git a/program/tests/helpers/instruction_builders.rs b/program/tests/helpers/instruction_builders.rs index 5953ac26..98ee2c18 100644 --- a/program/tests/helpers/instruction_builders.rs +++ b/program/tests/helpers/instruction_builders.rs @@ -229,6 +229,76 @@ impl InstructionConfig for MoveLamportsFullConfig<'_> { } } +pub struct MoveStakeConfig<'a> { + pub source: (&'a Pubkey, &'a AccountSharedData), + pub destination: (&'a Pubkey, &'a AccountSharedData), + pub amount: u64, + /// Override signer for testing wrong signer scenarios (defaults to ctx.staker) + pub override_signer: Option<&'a Pubkey>, +} + +impl<'a> MoveStakeConfig<'a> { + /// Helper to get the default source vote account from context + pub fn with_default_vote(self, ctx: &'a StakeTestContext) -> MoveStakeWithVoteConfig<'a> { + MoveStakeWithVoteConfig { + source: self.source, + destination: self.destination, + override_signer: self.override_signer, + amount: self.amount, + source_vote: ( + ctx.vote_account.as_ref().expect("vote_account required"), + ctx.vote_account_data + .as_ref() + .expect("vote_account_data required"), + ), + dest_vote: None, + } + } +} + +impl InstructionConfig for MoveStakeConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + let signer = self.override_signer.unwrap_or(&ctx.staker); + ixn::move_stake(self.source.0, self.destination.0, signer, self.amount) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![ + (*self.source.0, self.source.1.clone()), + (*self.destination.0, self.destination.1.clone()), + ] + } +} + +pub struct MoveStakeWithVoteConfig<'a> { + pub source: (&'a Pubkey, &'a AccountSharedData), + pub destination: (&'a Pubkey, &'a AccountSharedData), + pub amount: u64, + /// Override signer for testing wrong signer scenarios (defaults to ctx.staker) + pub override_signer: Option<&'a Pubkey>, + pub source_vote: (&'a Pubkey, &'a AccountSharedData), + pub dest_vote: Option<(&'a Pubkey, &'a AccountSharedData)>, +} + +impl InstructionConfig for MoveStakeWithVoteConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + let signer = self.override_signer.unwrap_or(&ctx.staker); + ixn::move_stake(self.source.0, self.destination.0, signer, self.amount) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + let mut accounts = vec![ + (*self.source.0, self.source.1.clone()), + (*self.destination.0, self.destination.1.clone()), + (*self.source_vote.0, self.source_vote.1.clone()), + ]; + if let Some((vote_pk, vote_acc)) = self.dest_vote { + accounts.push((*vote_pk, vote_acc.clone())); + } + accounts + } +} + pub struct SplitConfig<'a> { pub source: (&'a Pubkey, &'a AccountSharedData), pub destination: (&'a Pubkey, &'a AccountSharedData), diff --git a/program/tests/move_stake.rs b/program/tests/move_stake.rs new file mode 100644 index 00000000..7d020e6f --- /dev/null +++ b/program/tests/move_stake.rs @@ -0,0 +1,457 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, + instruction_builders::{MoveStakeConfig, MoveStakeWithVoteConfig}, + lifecycle::StakeLifecycle, + utils::{get_effective_stake, parse_stake_account, true_up_transient_stake_epoch}, + }, + mollusk_svm::result::Check, + solana_account::WritableAccount, + solana_program_error::ProgramError, + solana_stake_interface::{error::StakeError, state::Lockup}, + test_case::test_matrix, +}; + +#[test_matrix( + [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, + StakeLifecycle::Deactivating, StakeLifecycle::Deactive], + [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, + StakeLifecycle::Deactivating, StakeLifecycle::Deactive], + [false, true], + [false, true] +)] +fn test_move_stake( + move_source_type: StakeLifecycle, + move_dest_type: StakeLifecycle, + full_move: bool, + has_lockup: bool, +) { + let mut ctx = StakeTestContext::new(); + + // Source has 2x minimum so we can easily test partial moves + let source_staked_amount = ctx.minimum_delegation.unwrap() * 2; + + // This is the amount of *effective/activated* lamports for test assertions (not delegation amount) + // All dests are created with minimum_delegation, but only Active dests have it fully activated + let dest_staked_amount = if move_dest_type == StakeLifecycle::Active { + ctx.minimum_delegation.unwrap() + } else { + 0 // Non-Active destinations have 0 effective stake (Activating/Deactivating are transient) + }; + + // Test with and without lockup + let lockup = if has_lockup { + ctx.create_future_lockup(100) + } else { + Lockup::default() + }; + + // Extra lamports in each account to test they don't activate + let source_excess = ctx.minimum_delegation.unwrap(); + let dest_excess = ctx.minimum_delegation.unwrap(); + + // Create source and dest stakes + let min_delegation = ctx.minimum_delegation.unwrap(); + let (move_source, mut move_source_account) = ctx + .stake_account(move_source_type) + .staked_amount(source_staked_amount) + .lockup(&lockup) + .build(); + let (move_dest, mut move_dest_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .lockup(&lockup) + .build(); + + true_up_transient_stake_epoch( + &mut ctx.mollusk, + ctx.tracker.as_mut().unwrap(), + &move_source, + &mut move_source_account, + move_source_type, + ); + + true_up_transient_stake_epoch( + &mut ctx.mollusk, + ctx.tracker.as_mut().unwrap(), + &move_dest, + &mut move_dest_account, + move_dest_type, + ); + + // Add excess lamports + move_source_account + .checked_add_lamports(source_excess) + .unwrap(); + // Active accounts get additional excess on top of their staked amount + // Inactive accounts already have minimum_delegation as excess from creation + if move_dest_type == StakeLifecycle::Active { + move_dest_account.checked_add_lamports(dest_excess).unwrap(); + } + + // Check if this state combination is valid for MoveStake + match (move_source_type, move_dest_type) { + (StakeLifecycle::Active, StakeLifecycle::Initialized) + | (StakeLifecycle::Active, StakeLifecycle::Active) + | (StakeLifecycle::Active, StakeLifecycle::Deactive) => { + // Valid - continue with tests + } + _ => { + // Invalid state combination + let result = ctx + .process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + amount: if full_move { + source_staked_amount + } else { + ctx.minimum_delegation.unwrap() + }, + override_signer: None, + }) + .checks(&[]) + .test_missing_signers(false) + .execute(); + assert!(result.program_result.is_err()); + return; + } + } + + // The below checks need minimum_delegation > 1 + if ctx.minimum_delegation.unwrap() > 1 { + // Undershoot destination for inactive accounts + if move_dest_type != StakeLifecycle::Active { + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + amount: ctx.minimum_delegation.unwrap() - 1, + override_signer: None, + }) + .checks(&[Check::err(ProgramError::InvalidArgument)]) + .test_missing_signers(false) + .execute(); + } + + // Overshoot source (would leave source underfunded) + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + amount: ctx.minimum_delegation.unwrap() + 1, + override_signer: None, + }) + .checks(&[Check::err(ProgramError::InvalidArgument)]) + .test_missing_signers(false) + .execute(); + } + + let result = ctx + .process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + amount: if full_move { + source_staked_amount + } else { + ctx.minimum_delegation.unwrap() + }, + override_signer: None, + }) + .checks(&[Check::success()]) + .test_missing_signers(true) + .execute(); + + move_source_account = result.resulting_accounts[0].1.clone().into(); + move_dest_account = result.resulting_accounts[1].1.clone().into(); + + if full_move { + let (_, option_source_stake, source_lamports) = parse_stake_account(&move_source_account); + + // Source is deactivated and rent/excess stay behind + assert!(option_source_stake.is_none()); + assert_eq!(source_lamports, source_excess + ctx.rent_exempt_reserve); + + let (_, Some(dest_stake), dest_lamports) = parse_stake_account(&move_dest_account) else { + panic!("dest should be active") + }; + let dest_effective_stake = get_effective_stake(&ctx.mollusk, &move_dest_account); + + // Dest captured the entire source delegation, kept its rent/excess, didn't activate its excess + assert_eq!( + dest_stake.delegation.stake, + source_staked_amount + dest_staked_amount + ); + assert_eq!(dest_effective_stake, dest_stake.delegation.stake); + assert_eq!( + dest_lamports, + dest_effective_stake + dest_excess + ctx.rent_exempt_reserve + ); + } else { + let (_, Some(source_stake), source_lamports) = parse_stake_account(&move_source_account) + else { + panic!("source should be active") + }; + let source_effective_stake = get_effective_stake(&ctx.mollusk, &move_source_account); + + // Half of source delegation moved over, excess stayed behind + assert_eq!(source_stake.delegation.stake, source_staked_amount / 2); + assert_eq!(source_effective_stake, source_stake.delegation.stake); + assert_eq!( + source_lamports, + source_effective_stake + source_excess + ctx.rent_exempt_reserve + ); + + let (_, Some(dest_stake), dest_lamports) = parse_stake_account(&move_dest_account) else { + panic!("dest should be active") + }; + let dest_effective_stake = get_effective_stake(&ctx.mollusk, &move_dest_account); + + // Dest mirrors our observations + assert_eq!( + dest_stake.delegation.stake, + source_staked_amount / 2 + dest_staked_amount + ); + assert_eq!(dest_effective_stake, dest_stake.delegation.stake); + assert_eq!( + dest_lamports, + dest_effective_stake + dest_excess + ctx.rent_exempt_reserve + ); + } +} + +#[test_matrix( + [(StakeLifecycle::Active, StakeLifecycle::Uninitialized), + (StakeLifecycle::Uninitialized, StakeLifecycle::Initialized), + (StakeLifecycle::Uninitialized, StakeLifecycle::Uninitialized)] +)] +fn test_move_stake_uninitialized_fail(move_types: (StakeLifecycle, StakeLifecycle)) { + let mut ctx = StakeTestContext::new(); + let min_delegation = ctx.minimum_delegation.unwrap(); + let source_staked_amount = min_delegation * 2; + let (move_source_type, move_dest_type) = move_types; + + let (move_source, move_source_account) = ctx + .stake_account(move_source_type) + .staked_amount(source_staked_amount) + .build(); + let (move_dest, move_dest_account) = ctx.stake_account(move_dest_type).staked_amount(0).build(); + + let source_signer = if move_source_type == StakeLifecycle::Uninitialized { + move_source + } else { + ctx.staker + }; + + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + override_signer: Some(&source_signer), + amount: min_delegation, + }) + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); +} + +#[test_matrix( + [StakeLifecycle::Initialized, StakeLifecycle::Active, StakeLifecycle::Deactive], + [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, StakeLifecycle::Deactive] +)] +fn test_move_stake_general_fail(move_source_type: StakeLifecycle, move_dest_type: StakeLifecycle) { + let mut ctx = StakeTestContext::new(); + let min_delegation = ctx.minimum_delegation.unwrap(); + let source_staked_amount = min_delegation * 2; + + // Only test valid MoveStake combinations + if move_source_type != StakeLifecycle::Active || move_dest_type == StakeLifecycle::Activating { + return; + } + + let in_force_lockup = ctx.create_in_force_lockup(); + + // Create source + let (move_source, mut move_source_account) = ctx + .stake_account(move_source_type) + .staked_amount(source_staked_amount) + .build(); + move_source_account + .checked_add_lamports(min_delegation) + .unwrap(); + + // Self-move fails + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_source, &move_source_account), + amount: min_delegation, + override_signer: None, + }) + .checks(&[Check::err(ProgramError::InvalidInstructionData)]) + .test_missing_signers(false) + .execute(); + + // Zero move fails + let (move_dest, move_dest_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .build(); + + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + amount: 0, + override_signer: None, + }) + .checks(&[Check::err(ProgramError::InvalidArgument)]) + .test_missing_signers(false) + .execute(); + + // Sign with withdrawer fails + let withdrawer = ctx.withdrawer; + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest, &move_dest_account), + amount: min_delegation, + override_signer: Some(&withdrawer), + }) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Source lockup fails + let (move_locked_source, mut move_locked_source_account) = ctx + .stake_account(move_source_type) + .staked_amount(source_staked_amount) + .lockup(&in_force_lockup) + .build(); + move_locked_source_account + .checked_add_lamports(min_delegation) + .unwrap(); + + let (move_dest2, move_dest2_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .build(); + + ctx.process_with(MoveStakeConfig { + source: (&move_locked_source, &move_locked_source_account), + destination: (&move_dest2, &move_dest2_account), + amount: min_delegation, + override_signer: None, + }) + .checks(&[Check::err(StakeError::MergeMismatch.into())]) + .test_missing_signers(false) + .execute(); + + // Staker mismatch fails + let throwaway_staker = solana_pubkey::Pubkey::new_unique(); + let (move_dest3, move_dest3_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .stake_authority(&throwaway_staker) + .withdraw_authority(&withdrawer) + .build(); + + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest3, &move_dest3_account), + amount: min_delegation, + override_signer: None, + }) + .checks(&[Check::err(StakeError::MergeMismatch.into())]) + .test_missing_signers(false) + .execute(); + + // Also verify signing with dest's staker fails (wrong signer for source) + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest3, &move_dest3_account), + amount: min_delegation, + override_signer: Some(&throwaway_staker), + }) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Withdrawer mismatch fails + let throwaway_withdrawer = solana_pubkey::Pubkey::new_unique(); + let staker = ctx.staker; + let (move_dest4, move_dest4_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .stake_authority(&staker) + .withdraw_authority(&throwaway_withdrawer) + .build(); + + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest4, &move_dest4_account), + amount: min_delegation, + override_signer: None, + }) + .checks(&[Check::err(StakeError::MergeMismatch.into())]) + .test_missing_signers(false) + .execute(); + + // Also verify signing with dest's withdrawer fails (wrong signer for source) + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest4, &move_dest4_account), + amount: min_delegation, + override_signer: Some(&throwaway_withdrawer), + }) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Dest lockup fails + let (move_dest5, move_dest5_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .lockup(&in_force_lockup) + .build(); + + ctx.process_with(MoveStakeConfig { + source: (&move_source, &move_source_account), + destination: (&move_dest5, &move_dest5_account), + amount: min_delegation, + override_signer: None, + }) + .checks(&[Check::err(StakeError::MergeMismatch.into())]) + .test_missing_signers(false) + .execute(); + + // Different vote accounts for active dest + if move_dest_type == StakeLifecycle::Active { + let (dest_vote_account, dest_vote_account_data) = ctx.create_second_vote_account(); + + let move_dest6_pubkey = solana_pubkey::Pubkey::new_unique(); + let (_, move_dest6_account) = ctx + .stake_account(move_dest_type) + .staked_amount(min_delegation) + .vote_account(&dest_vote_account) + .stake_pubkey(&move_dest6_pubkey) + .build(); + + let (move_source2, move_source2_account) = ctx + .stake_account(move_source_type) + .staked_amount(source_staked_amount) + .build(); + + let staker = ctx.staker; + let vote_account = ctx.vote_account.unwrap(); + let vote_account_data = ctx.vote_account_data.as_ref().unwrap(); + ctx.process_with(MoveStakeWithVoteConfig { + source: (&move_source2, &move_source2_account), + destination: (&move_dest6_pubkey, &move_dest6_account), + override_signer: Some(&staker), + amount: min_delegation, + source_vote: (&vote_account, vote_account_data), + dest_vote: Some((&dest_vote_account, &dest_vote_account_data)), + }) + .checks(&[Check::err(StakeError::VoteAddressMismatch.into())]) + .test_missing_signers(false) + .execute(); + } +} diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs index f17e907a..91bf3c92 100644 --- a/program/tests/program_test.rs +++ b/program/tests/program_test.rs @@ -12,7 +12,6 @@ use { solana_sdk_ids::system_program, solana_signer::Signer, solana_stake_interface::{ - error::StakeError, instruction::{self as ixn, LockupArgs}, program::id, stake_history::StakeHistory, @@ -24,7 +23,6 @@ use { instruction as vote_instruction, state::{VoteInit, VoteStateV4}, }, - test_case::test_matrix, }; pub const USER_STARTING_LAMPORTS: u64 = 10_000_000_000_000; // 10k sol @@ -204,28 +202,6 @@ pub async fn get_effective_stake(banks_client: &mut BanksClient, pubkey: &Pubkey } } -async fn get_minimum_delegation(context: &mut ProgramTestContext) -> u64 { - let transaction = Transaction::new_signed_with_payer( - &[ixn::get_minimum_delegation()], - Some(&context.payer.pubkey()), - &[&context.payer], - context.last_blockhash, - ); - let mut data = context - .banks_client - .simulate_transaction(transaction) - .await - .unwrap() - .simulation_details - .unwrap() - .return_data - .unwrap() - .data; - data.resize(8, 0); - - data.try_into().map(u64::from_le_bytes).unwrap() -} - pub async fn create_independent_stake_account( context: &mut ProgramTestContext, authorized: &Authorized, @@ -738,605 +714,3 @@ impl StakeLifecycle { } } } - -#[test_matrix( - [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, - StakeLifecycle::Deactivating, StakeLifecycle::Deactive], - [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, - StakeLifecycle::Deactivating, StakeLifecycle::Deactive], - [false, true], - [false, true] -)] -#[tokio::test] -async fn program_test_move_stake( - move_source_type: StakeLifecycle, - move_dest_type: StakeLifecycle, - full_move: bool, - has_lockup: bool, -) { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let rent_exempt_reserve = get_stake_account_rent(&mut context.banks_client).await; - let minimum_delegation = get_minimum_delegation(&mut context).await; - - // source has 2x minimum so we can easily test an unfunded destination - let source_staked_amount = minimum_delegation * 2; - - // this is the amount of *staked* lamports for test checks - // destinations may have excess lamports but these are *never* activated by move - let dest_staked_amount = if move_dest_type == StakeLifecycle::Active { - minimum_delegation - } else { - 0 - }; - - // test with and without lockup. both of these cases pass, we test failures - // elsewhere - let lockup = if has_lockup { - let clock = context.banks_client.get_sysvar::().await.unwrap(); - let lockup = Lockup { - unix_timestamp: 0, - epoch: clock.epoch + 100, - custodian: Pubkey::new_unique(), - }; - - assert!(lockup.is_in_force(&clock, None)); - lockup - } else { - Lockup::default() - }; - - // we put an extra minimum in every account, unstaked, to test that no new - // lamports activate name them here so our asserts are readable - let source_excess = minimum_delegation; - let dest_excess = minimum_delegation; - - let move_source_keypair = Keypair::new(); - let move_dest_keypair = Keypair::new(); - let staker_keypair = Keypair::new(); - let withdrawer_keypair = Keypair::new(); - - // create source stake - move_source_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - source_staked_amount, - &move_source_keypair, - &staker_keypair, - &withdrawer_keypair, - &lockup, - ) - .await; - let move_source = move_source_keypair.pubkey(); - let mut source_account = get_account(&mut context.banks_client, &move_source).await; - let mut source_stake_state: StakeStateV2 = bincode::deserialize(&source_account.data).unwrap(); - - // create dest stake with same authorities - move_dest_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - minimum_delegation, - &move_dest_keypair, - &staker_keypair, - &withdrawer_keypair, - &lockup, - ) - .await; - let move_dest = move_dest_keypair.pubkey(); - - // true up source epoch if transient - if move_source_type == StakeLifecycle::Activating - || move_source_type == StakeLifecycle::Deactivating - { - let clock = context.banks_client.get_sysvar::().await.unwrap(); - if let StakeStateV2::Stake(_, ref mut stake, _) = &mut source_stake_state { - match move_source_type { - StakeLifecycle::Activating => stake.delegation.activation_epoch = clock.epoch, - StakeLifecycle::Deactivating => stake.delegation.deactivation_epoch = clock.epoch, - _ => (), - } - } - - source_account.data = bincode::serialize(&source_stake_state).unwrap(); - context.set_account(&move_source, &source_account.into()); - } - - // our inactive accounts have extra lamports, lets not let active feel left out - if move_dest_type == StakeLifecycle::Active { - transfer(&mut context, &move_dest, dest_excess).await; - } - - // hey why not spread the love around to everyone - transfer(&mut context, &move_source, source_excess).await; - - // alright first things first, clear out all the state failures - match (move_source_type, move_dest_type) { - // valid - (StakeLifecycle::Active, StakeLifecycle::Initialized) - | (StakeLifecycle::Active, StakeLifecycle::Active) - | (StakeLifecycle::Active, StakeLifecycle::Deactive) => (), - // invalid! get outta my test - _ => { - let instruction = ixn::move_stake( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - if full_move { - source_staked_amount - } else { - minimum_delegation - }, - ); - - // this is InvalidAccountData sometimes and Custom(5) sometimes but i dont care - process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - return; - } - } - - // the below checks are conceptually incoherent with a 1 lamport minimum - // the undershoot fails successfully (but because its a zero move, not because - // the destination ends underfunded) then the second one succeeds failedly - // (because its a full move, so the "underfunded" source is actually closed) - if minimum_delegation > 1 { - // first for inactive accounts lets undershoot and fail for underfunded dest - if move_dest_type != StakeLifecycle::Active { - let instruction = ixn::move_stake( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - minimum_delegation - 1, - ); - - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidArgument); - } - - // now lets overshoot and fail for underfunded source - let instruction = ixn::move_stake( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - minimum_delegation + 1, - ); - - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidArgument); - } - - // now we do it juuust right - let instruction = ixn::move_stake( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - if full_move { - source_staked_amount - } else { - minimum_delegation - }, - ); - - process_instruction_test_missing_signers(&mut context, &instruction, &vec![&staker_keypair]) - .await; - - if full_move { - let (_, option_source_stake, source_lamports) = - get_stake_account(&mut context.banks_client, &move_source).await; - - // source is deactivated and rent/excess stay behind - assert!(option_source_stake.is_none()); - assert_eq!(source_lamports, source_excess + rent_exempt_reserve); - - let (_, Some(dest_stake), dest_lamports) = - get_stake_account(&mut context.banks_client, &move_dest).await - else { - panic!("dest should be active") - }; - let dest_effective_stake = get_effective_stake(&mut context.banks_client, &move_dest).await; - - // dest captured the entire source delegation, kept its rent/excess, didnt - // activate its excess - assert_eq!( - dest_stake.delegation.stake, - source_staked_amount + dest_staked_amount - ); - assert_eq!(dest_effective_stake, dest_stake.delegation.stake); - assert_eq!( - dest_lamports, - dest_effective_stake + dest_excess + rent_exempt_reserve - ); - } else { - let (_, Some(source_stake), source_lamports) = - get_stake_account(&mut context.banks_client, &move_source).await - else { - panic!("source should be active") - }; - let source_effective_stake = - get_effective_stake(&mut context.banks_client, &move_source).await; - - // half of source delegation moved over, excess stayed behind - assert_eq!(source_stake.delegation.stake, source_staked_amount / 2); - assert_eq!(source_effective_stake, source_stake.delegation.stake); - assert_eq!( - source_lamports, - source_effective_stake + source_excess + rent_exempt_reserve - ); - - let (_, Some(dest_stake), dest_lamports) = - get_stake_account(&mut context.banks_client, &move_dest).await - else { - panic!("dest should be active") - }; - let dest_effective_stake = get_effective_stake(&mut context.banks_client, &move_dest).await; - - // dest mirrors our observations - assert_eq!( - dest_stake.delegation.stake, - source_staked_amount / 2 + dest_staked_amount - ); - assert_eq!(dest_effective_stake, dest_stake.delegation.stake); - assert_eq!( - dest_lamports, - dest_effective_stake + dest_excess + rent_exempt_reserve - ); - } -} - -#[test_matrix( - [(StakeLifecycle::Active, StakeLifecycle::Uninitialized), - (StakeLifecycle::Uninitialized, StakeLifecycle::Initialized), - (StakeLifecycle::Uninitialized, StakeLifecycle::Uninitialized)], - [false, true] -)] -#[tokio::test] -async fn program_test_move_uninitialized_fail( - move_types: (StakeLifecycle, StakeLifecycle), - move_lamports: bool, -) { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let minimum_delegation = get_minimum_delegation(&mut context).await; - let source_staked_amount = minimum_delegation * 2; - - let (move_source_type, move_dest_type) = move_types; - - let (move_source_keypair, staker_keypair, withdrawer_keypair) = move_source_type - .new_stake_account( - &mut context, - &accounts.vote_account.pubkey(), - source_staked_amount, - ) - .await; - let move_source = move_source_keypair.pubkey(); - - let move_dest_keypair = Keypair::new(); - move_dest_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - 0, - &move_dest_keypair, - &staker_keypair, - &withdrawer_keypair, - &Lockup::default(), - ) - .await; - let move_dest = move_dest_keypair.pubkey(); - - let source_signer = if move_source_type == StakeLifecycle::Uninitialized { - &move_source_keypair - } else { - &staker_keypair - }; - - let instruction = if move_lamports { - ixn::move_lamports( - &move_source, - &move_dest, - &source_signer.pubkey(), - minimum_delegation, - ) - } else { - ixn::move_stake( - &move_source, - &move_dest, - &source_signer.pubkey(), - minimum_delegation, - ) - }; - - let e = process_instruction(&mut context, &instruction, &vec![source_signer]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountData); -} - -#[test_matrix( - [StakeLifecycle::Initialized, StakeLifecycle::Active, StakeLifecycle::Deactive], - [StakeLifecycle::Initialized, StakeLifecycle::Activating, StakeLifecycle::Active, StakeLifecycle::Deactive], - [false, true] -)] -#[tokio::test] -async fn program_test_move_general_fail( - move_source_type: StakeLifecycle, - move_dest_type: StakeLifecycle, - move_lamports: bool, -) { - // the test_matrix includes all valid source/dest combinations for MoveLamports - // we dont test invalid combinations because they would fail regardless of the - // fail cases we test here valid source/dest for MoveStake are a strict - // subset of MoveLamports source must be active, and dest must be active or - // inactive. so we skip the additional invalid MoveStake cases - if !move_lamports - && (move_source_type != StakeLifecycle::Active - || move_dest_type == StakeLifecycle::Activating) - { - return; - } - - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let minimum_delegation = get_minimum_delegation(&mut context).await; - let source_staked_amount = minimum_delegation * 2; - - let in_force_lockup = { - let clock = context.banks_client.get_sysvar::().await.unwrap(); - Lockup { - unix_timestamp: 0, - epoch: clock.epoch + 1_000_000, - custodian: Pubkey::new_unique(), - } - }; - - let mk_ixn = if move_lamports { - ixn::move_lamports - } else { - ixn::move_stake - }; - - // we can reuse source but will need a lot of dest - let (move_source_keypair, staker_keypair, withdrawer_keypair) = move_source_type - .new_stake_account( - &mut context, - &accounts.vote_account.pubkey(), - source_staked_amount, - ) - .await; - let move_source = move_source_keypair.pubkey(); - transfer(&mut context, &move_source, minimum_delegation).await; - - // self-move fails - let instruction = mk_ixn( - &move_source, - &move_source, - &staker_keypair.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidInstructionData); - - // first we make a "normal" move dest - { - let move_dest_keypair = Keypair::new(); - move_dest_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - minimum_delegation, - &move_dest_keypair, - &staker_keypair, - &withdrawer_keypair, - &Lockup::default(), - ) - .await; - let move_dest = move_dest_keypair.pubkey(); - - // zero move fails - let instruction = mk_ixn(&move_source, &move_dest, &staker_keypair.pubkey(), 0); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidArgument); - - // sign with withdrawer fails - let instruction = mk_ixn( - &move_source, - &move_dest, - &withdrawer_keypair.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&withdrawer_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::MissingRequiredSignature); - - // good place to test source lockup - let move_locked_source_keypair = Keypair::new(); - move_source_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - source_staked_amount, - &move_locked_source_keypair, - &staker_keypair, - &withdrawer_keypair, - &in_force_lockup, - ) - .await; - let move_locked_source = move_locked_source_keypair.pubkey(); - transfer(&mut context, &move_locked_source, minimum_delegation).await; - - let instruction = mk_ixn( - &move_locked_source, - &move_dest, - &staker_keypair.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::MergeMismatch.into()); - } - - // staker mismatch - { - let move_dest_keypair = Keypair::new(); - let throwaway = Keypair::new(); - move_dest_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - minimum_delegation, - &move_dest_keypair, - &throwaway, - &withdrawer_keypair, - &Lockup::default(), - ) - .await; - let move_dest = move_dest_keypair.pubkey(); - - let instruction = mk_ixn( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::MergeMismatch.into()); - - let instruction = mk_ixn( - &move_source, - &move_dest, - &throwaway.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&throwaway]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::MissingRequiredSignature); - } - - // withdrawer mismatch - { - let move_dest_keypair = Keypair::new(); - let throwaway = Keypair::new(); - move_dest_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - minimum_delegation, - &move_dest_keypair, - &staker_keypair, - &throwaway, - &Lockup::default(), - ) - .await; - let move_dest = move_dest_keypair.pubkey(); - - let instruction = mk_ixn( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::MergeMismatch.into()); - - let instruction = mk_ixn( - &move_source, - &move_dest, - &throwaway.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&throwaway]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::MissingRequiredSignature); - } - - // dest lockup - { - let move_dest_keypair = Keypair::new(); - move_dest_type - .new_stake_account_fully_specified( - &mut context, - &accounts.vote_account.pubkey(), - minimum_delegation, - &move_dest_keypair, - &staker_keypair, - &withdrawer_keypair, - &in_force_lockup, - ) - .await; - let move_dest = move_dest_keypair.pubkey(); - - let instruction = mk_ixn( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::MergeMismatch.into()); - } - - // lastly we test different vote accounts for move_stake - if !move_lamports && move_dest_type == StakeLifecycle::Active { - let dest_vote_account_keypair = Keypair::new(); - create_vote( - &mut context, - &Keypair::new(), - &Pubkey::new_unique(), - &Pubkey::new_unique(), - &dest_vote_account_keypair, - ) - .await; - - let move_dest_keypair = Keypair::new(); - move_dest_type - .new_stake_account_fully_specified( - &mut context, - &dest_vote_account_keypair.pubkey(), - minimum_delegation, - &move_dest_keypair, - &staker_keypair, - &withdrawer_keypair, - &Lockup::default(), - ) - .await; - let move_dest = move_dest_keypair.pubkey(); - - let instruction = mk_ixn( - &move_source, - &move_dest, - &staker_keypair.pubkey(), - minimum_delegation, - ); - let e = process_instruction(&mut context, &instruction, &vec![&staker_keypair]) - .await - .unwrap_err(); - assert_eq!(e, StakeError::VoteAddressMismatch.into()); - } -} From f116799a3880167c3f61885582b3e9e153ab9953 Mon Sep 17 00:00:00 2001 From: rustopian <96253492+rustopian@users.noreply.github.com> Date: Tue, 4 Nov 2025 12:34:36 +0000 Subject: [PATCH 10/10] migrate Authorize and SetLockup tests --- program/tests/authorize.rs | 378 +++++++++ program/tests/helpers/instruction_builders.rs | 98 ++- program/tests/program_test.rs | 716 ------------------ program/tests/set_lockup.rs | 35 + 4 files changed, 510 insertions(+), 717 deletions(-) create mode 100644 program/tests/authorize.rs delete mode 100644 program/tests/program_test.rs create mode 100644 program/tests/set_lockup.rs diff --git a/program/tests/authorize.rs b/program/tests/authorize.rs new file mode 100644 index 00000000..1bd280ac --- /dev/null +++ b/program/tests/authorize.rs @@ -0,0 +1,378 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, + instruction_builders::{ + AuthorizeCheckedConfig, AuthorizeCheckedWithSeedConfig, AuthorizeConfig, + InstructionExecution, WithdrawConfig, + }, + lifecycle::StakeLifecycle, + utils::parse_stake_account, + }, + mollusk_svm::result::Check, + solana_account::AccountSharedData, + solana_program_error::ProgramError, + solana_pubkey::Pubkey, + solana_sdk_ids::system_program, + solana_stake_interface::state::{StakeAuthorize, StakeStateV2}, + solana_stake_program::id, + test_case::test_case, +}; + +#[derive(Debug, Clone, Copy)] +enum AuthorizeVariant { + Authorize, + AuthorizeChecked, + AuthorizeCheckedWithSeed, +} + +impl AuthorizeVariant { + /// Returns seed parameters only if this is the AuthorizeCheckedWithSeed variant + fn seed_params<'a>( + &self, + seed_base: &'a Pubkey, + seed: &'a str, + ) -> Option<(&'a Pubkey, &'a str)> { + match self { + Self::AuthorizeCheckedWithSeed => Some((seed_base, seed)), + _ => None, + } + } + + fn process_authorize<'a, 'b>( + self, + ctx: &'a StakeTestContext, + stake: (&'b Pubkey, &'b AccountSharedData), + authority: &'b Pubkey, + new_authority: &'b Pubkey, + stake_authorize: StakeAuthorize, + seed_params: Option<(&'b Pubkey, &'b str)>, + ) -> InstructionExecution<'a, 'b> { + match self { + Self::Authorize => { + if seed_params.is_some() { + panic!("Authorize variant should not have seed parameters"); + } + ctx.process_with(AuthorizeConfig { + stake, + override_authority: Some(authority), + new_authority, + stake_authorize, + }) + } + Self::AuthorizeChecked => { + if seed_params.is_some() { + panic!("AuthorizeChecked variant should not have seed parameters"); + } + ctx.process_with(AuthorizeCheckedConfig { + stake, + authority, + new_authority, + stake_authorize, + custodian: None, + }) + } + Self::AuthorizeCheckedWithSeed => { + let (authority_base, authority_seed) = seed_params + .expect("AuthorizeCheckedWithSeed requires seed parameters (base, seed)"); + ctx.process_with(AuthorizeCheckedWithSeedConfig { + stake, + authority_base, + authority_seed: authority_seed.to_string(), + authority_owner: &system_program::id(), + new_authority, + stake_authorize, + custodian: None, + }) + } + } + } +} + +#[test_case(AuthorizeVariant::Authorize; "authorize")] +#[test_case(AuthorizeVariant::AuthorizeChecked; "authorize_checked")] +#[test_case(AuthorizeVariant::AuthorizeCheckedWithSeed; "authorize_checked_with_seed")] +fn test_authorize(variant: AuthorizeVariant) { + let mut ctx = StakeTestContext::new(); + + // Set up seed-derived authorities for AuthorizeCheckedWithSeed variant + let (seed_base, staker_seed, withdrawer_seed, staker1, withdrawer1) = + if matches!(variant, AuthorizeVariant::AuthorizeCheckedWithSeed) { + let seed_base = Pubkey::new_unique(); + let staker_seed = "staker_seed"; + let withdrawer_seed = "withdrawer_seed"; + let seeded_staker = + Pubkey::create_with_seed(&seed_base, staker_seed, &system_program::id()).unwrap(); + let seeded_withdrawer = + Pubkey::create_with_seed(&seed_base, withdrawer_seed, &system_program::id()) + .unwrap(); + ( + seed_base, + staker_seed, + withdrawer_seed, + seeded_staker, + seeded_withdrawer, + ) + } else { + ( + Pubkey::new_unique(), + "", + "", + Pubkey::new_unique(), + Pubkey::new_unique(), + ) + }; + + let staker2 = Pubkey::new_unique(); + let staker3 = Pubkey::new_unique(); + + let withdrawer2 = Pubkey::new_unique(); + let withdrawer3 = Pubkey::new_unique(); + + let (stake, stake_account) = ctx.stake_account(StakeLifecycle::Uninitialized).build(); + + // Authorize uninitialized fails for staker + variant + .process_authorize( + &ctx, + (&stake, &stake_account), + &stake, + &staker1, + StakeAuthorize::Staker, + variant.seed_params(&stake, ""), + ) + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); + + // Authorize uninitialized fails for withdrawer + variant + .process_authorize( + &ctx, + (&stake, &stake_account), + &stake, + &withdrawer1, + StakeAuthorize::Withdrawer, + variant.seed_params(&stake, ""), + ) + .checks(&[Check::err(ProgramError::InvalidAccountData)]) + .test_missing_signers(false) + .execute(); + + let (stake, mut stake_account) = ctx + .stake_account(StakeLifecycle::Initialized) + .stake_authority(&staker1) + .withdraw_authority(&withdrawer1) + .build(); + + let rent_exempt_reserve = ctx.rent_exempt_reserve; + + // Change staker authority + let result = variant + .process_authorize( + &ctx, + (&stake, &stake_account), + &staker1, + &staker2, + StakeAuthorize::Staker, + variant.seed_params(&seed_base, staker_seed), + ) + .checks(&[ + Check::success(), + Check::all_rent_exempt(), + Check::account(&stake) + .lamports(rent_exempt_reserve) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + ]) + .test_missing_signers(true) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + let (meta, _, _) = parse_stake_account(&stake_account); + assert_eq!(meta.authorized.staker, staker2); + + // Change withdrawer authority + let result = variant + .process_authorize( + &ctx, + (&stake, &stake_account), + &withdrawer1, + &withdrawer2, + StakeAuthorize::Withdrawer, + variant.seed_params(&seed_base, withdrawer_seed), + ) + .checks(&[ + Check::success(), + Check::all_rent_exempt(), + Check::account(&stake) + .lamports(rent_exempt_reserve) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + ]) + .test_missing_signers(true) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + let (meta, _, _) = parse_stake_account(&stake_account); + assert_eq!(meta.authorized.withdrawer, withdrawer2); + + // Old staker authority no longer works + variant + .process_authorize( + &ctx, + (&stake, &stake_account), + &staker1, + &Pubkey::new_unique(), + StakeAuthorize::Staker, + variant.seed_params(&seed_base, staker_seed), + ) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Old withdrawer authority no longer works + variant + .process_authorize( + &ctx, + (&stake, &stake_account), + &withdrawer1, + &Pubkey::new_unique(), + StakeAuthorize::Withdrawer, + variant.seed_params(&seed_base, withdrawer_seed), + ) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Change staker authority again with new authority (staker2 is now the authority, not seed-derived) + // For AuthorizeCheckedWithSeed variant, use AuthorizeChecked since authority is not seed-derived + let result = if matches!(variant, AuthorizeVariant::AuthorizeCheckedWithSeed) { + AuthorizeVariant::AuthorizeChecked + } else { + variant + } + .process_authorize( + &ctx, + (&stake, &stake_account), + &staker2, + &staker3, + StakeAuthorize::Staker, + None, // staker2 is not seed-derived, so no seed params + ) + .checks(&[ + Check::success(), + Check::all_rent_exempt(), + Check::account(&stake) + .lamports(rent_exempt_reserve) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + ]) + .test_missing_signers(true) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + let (meta, _, _) = parse_stake_account(&stake_account); + assert_eq!(meta.authorized.staker, staker3); + + // Change withdrawer authority again with new authority (withdrawer2 is now the authority, not seed-derived) + // For AuthorizeCheckedWithSeed variant, use AuthorizeChecked since authority is not seed-derived + let result = if matches!(variant, AuthorizeVariant::AuthorizeCheckedWithSeed) { + AuthorizeVariant::AuthorizeChecked + } else { + variant + } + .process_authorize( + &ctx, + (&stake, &stake_account), + &withdrawer2, + &withdrawer3, + StakeAuthorize::Withdrawer, + None, // withdrawer2 is not seed-derived, so no seed params + ) + .checks(&[ + Check::success(), + Check::all_rent_exempt(), + Check::account(&stake) + .lamports(rent_exempt_reserve) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + ]) + .test_missing_signers(true) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + let (meta, _, _) = parse_stake_account(&stake_account); + assert_eq!(meta.authorized.withdrawer, withdrawer3); + + // Changing withdrawer using staker fails + // For AuthorizeCheckedWithSeed variant, use AuthorizeChecked since authority is not seed-derived + if matches!(variant, AuthorizeVariant::AuthorizeCheckedWithSeed) { + AuthorizeVariant::AuthorizeChecked + } else { + variant + } + .process_authorize( + &ctx, + (&stake, &stake_account), + &staker3, + &Pubkey::new_unique(), + StakeAuthorize::Withdrawer, + None, // staker3 is not seed-derived + ) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + + // Changing staker using withdrawer is fine + // For AuthorizeCheckedWithSeed variant, use AuthorizeChecked since authority is not seed-derived + let result = if matches!(variant, AuthorizeVariant::AuthorizeCheckedWithSeed) { + AuthorizeVariant::AuthorizeChecked + } else { + variant + } + .process_authorize( + &ctx, + (&stake, &stake_account), + &withdrawer3, + &staker1, + StakeAuthorize::Staker, + None, // withdrawer3 is not seed-derived + ) + .checks(&[ + Check::success(), + Check::all_rent_exempt(), + Check::account(&stake) + .lamports(rent_exempt_reserve) + .owner(&id()) + .space(StakeStateV2::size_of()) + .build(), + ]) + .test_missing_signers(true) + .execute(); + stake_account = result.resulting_accounts[0].1.clone().into(); + + let (meta, _, _) = parse_stake_account(&stake_account); + assert_eq!(meta.authorized.staker, staker1); + + // Withdraw using staker fails - test all three stakers to ensure none can withdraw + for staker in [staker1, staker2, staker3] { + let recipient = Pubkey::new_unique(); + ctx.process_with(WithdrawConfig { + stake: (&stake, &stake_account), + override_signer: Some(&staker), + recipient: (&recipient, &AccountSharedData::default()), + amount: ctx.rent_exempt_reserve, + }) + .checks(&[Check::err(ProgramError::MissingRequiredSignature)]) + .test_missing_signers(false) + .execute(); + } +} diff --git a/program/tests/helpers/instruction_builders.rs b/program/tests/helpers/instruction_builders.rs index 98ee2c18..b543c232 100644 --- a/program/tests/helpers/instruction_builders.rs +++ b/program/tests/helpers/instruction_builders.rs @@ -6,7 +6,7 @@ use { solana_pubkey::Pubkey, solana_stake_interface::{ instruction as ixn, - state::{Authorized, Lockup}, + state::{Authorized, Lockup, StakeAuthorize}, }, }; @@ -105,6 +105,86 @@ impl InstructionConfig for InitializeCheckedConfig<'_> { } } +pub struct AuthorizeConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + pub override_authority: Option<&'a Pubkey>, + pub new_authority: &'a Pubkey, + pub stake_authorize: StakeAuthorize, +} + +impl InstructionConfig for AuthorizeConfig<'_> { + fn build_instruction(&self, ctx: &StakeTestContext) -> Instruction { + let authority = self + .override_authority + .unwrap_or(match self.stake_authorize { + StakeAuthorize::Staker => &ctx.staker, + StakeAuthorize::Withdrawer => &ctx.withdrawer, + }); + ixn::authorize( + self.stake.0, + authority, + self.new_authority, + self.stake_authorize, + None, + ) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![(*self.stake.0, self.stake.1.clone())] + } +} + +pub struct AuthorizeCheckedConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + pub authority: &'a Pubkey, + pub new_authority: &'a Pubkey, + pub stake_authorize: StakeAuthorize, + pub custodian: Option<&'a Pubkey>, +} + +impl InstructionConfig for AuthorizeCheckedConfig<'_> { + fn build_instruction(&self, _ctx: &StakeTestContext) -> Instruction { + ixn::authorize_checked( + self.stake.0, + self.authority, + self.new_authority, + self.stake_authorize, + self.custodian, + ) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![(*self.stake.0, self.stake.1.clone())] + } +} + +pub struct AuthorizeCheckedWithSeedConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + pub authority_base: &'a Pubkey, + pub authority_seed: String, + pub authority_owner: &'a Pubkey, + pub new_authority: &'a Pubkey, + pub stake_authorize: StakeAuthorize, + pub custodian: Option<&'a Pubkey>, +} + +impl InstructionConfig for AuthorizeCheckedWithSeedConfig<'_> { + fn build_instruction(&self, _ctx: &StakeTestContext) -> Instruction { + ixn::authorize_checked_with_seed( + self.stake.0, + self.authority_base, + self.authority_seed.clone(), + self.authority_owner, + self.new_authority, + self.stake_authorize, + self.custodian, + ) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![(*self.stake.0, self.stake.1.clone())] + } +} pub struct DeactivateConfig<'a> { pub stake: (&'a Pubkey, &'a AccountSharedData), /// Override signer for testing wrong signer scenarios (defaults to ctx.staker) @@ -299,6 +379,22 @@ impl InstructionConfig for MoveStakeWithVoteConfig<'_> { } } +pub struct SetLockupCheckedConfig<'a> { + pub stake: (&'a Pubkey, &'a AccountSharedData), + pub lockup_args: &'a ixn::LockupArgs, + pub custodian: &'a Pubkey, +} + +impl InstructionConfig for SetLockupCheckedConfig<'_> { + fn build_instruction(&self, _ctx: &StakeTestContext) -> Instruction { + ixn::set_lockup_checked(self.stake.0, self.lockup_args, self.custodian) + } + + fn build_accounts(&self) -> Vec<(Pubkey, AccountSharedData)> { + vec![(*self.stake.0, self.stake.1.clone())] + } +} + pub struct SplitConfig<'a> { pub source: (&'a Pubkey, &'a AccountSharedData), pub destination: (&'a Pubkey, &'a AccountSharedData), diff --git a/program/tests/program_test.rs b/program/tests/program_test.rs deleted file mode 100644 index 91bf3c92..00000000 --- a/program/tests/program_test.rs +++ /dev/null @@ -1,716 +0,0 @@ -#![allow(clippy::arithmetic_side_effects)] - -use { - solana_account::Account as SolanaAccount, - solana_clock::Clock, - solana_instruction::Instruction, - solana_keypair::Keypair, - solana_program_entrypoint::ProgramResult, - solana_program_error::ProgramError, - solana_program_test::*, - solana_pubkey::Pubkey, - solana_sdk_ids::system_program, - solana_signer::Signer, - solana_stake_interface::{ - instruction::{self as ixn, LockupArgs}, - program::id, - stake_history::StakeHistory, - state::{Authorized, Lockup, Meta, Stake, StakeAuthorize, StakeStateV2}, - }, - solana_system_interface::instruction as system_instruction, - solana_transaction::{Signers, Transaction, TransactionError}, - solana_vote_interface::{ - instruction as vote_instruction, - state::{VoteInit, VoteStateV4}, - }, -}; - -pub const USER_STARTING_LAMPORTS: u64 = 10_000_000_000_000; // 10k sol -pub const NO_SIGNERS: &[Keypair] = &[]; - -pub fn program_test() -> ProgramTest { - program_test_without_features(&[]) -} - -pub fn program_test_without_features(feature_ids: &[Pubkey]) -> ProgramTest { - let mut program_test = ProgramTest::default(); - program_test.prefer_bpf(true); - - for feature_id in feature_ids { - program_test.deactivate_feature(*feature_id); - } - - program_test.add_upgradeable_program_to_genesis("solana_stake_program", &id()); - - program_test -} - -#[derive(Debug, PartialEq)] -pub struct Accounts { - pub validator: Keypair, - pub voter: Keypair, - pub withdrawer: Keypair, - pub vote_account: Keypair, -} - -impl Accounts { - pub async fn initialize(&self, context: &mut ProgramTestContext) { - let slot = context.genesis_config().epoch_schedule.first_normal_slot + 1; - context.warp_to_slot(slot).unwrap(); - - create_vote( - context, - &self.validator, - &self.voter.pubkey(), - &self.withdrawer.pubkey(), - &self.vote_account, - ) - .await; - } -} - -impl Default for Accounts { - fn default() -> Self { - let vote_account = Keypair::new(); - - Self { - validator: Keypair::new(), - voter: Keypair::new(), - withdrawer: Keypair::new(), - vote_account, - } - } -} - -pub async fn create_vote( - context: &mut ProgramTestContext, - validator: &Keypair, - voter: &Pubkey, - withdrawer: &Pubkey, - vote_account: &Keypair, -) { - let rent = context.banks_client.get_rent().await.unwrap(); - let rent_voter = rent.minimum_balance(VoteStateV4::size_of()); - - let mut instructions = vec![system_instruction::create_account( - &context.payer.pubkey(), - &validator.pubkey(), - rent.minimum_balance(0), - 0, - &system_program::id(), - )]; - instructions.append(&mut vote_instruction::create_account_with_config( - &context.payer.pubkey(), - &vote_account.pubkey(), - &VoteInit { - node_pubkey: validator.pubkey(), - authorized_voter: *voter, - authorized_withdrawer: *withdrawer, - ..VoteInit::default() - }, - rent_voter, - vote_instruction::CreateVoteAccountConfig { - space: VoteStateV4::size_of() as u64, - ..Default::default() - }, - )); - - let transaction = Transaction::new_signed_with_payer( - &instructions, - Some(&context.payer.pubkey()), - &[validator, vote_account, &context.payer], - context.last_blockhash, - ); - - // ignore errors for idempotency - let _ = context.banks_client.process_transaction(transaction).await; -} - -pub async fn transfer(context: &mut ProgramTestContext, recipient: &Pubkey, amount: u64) { - let transaction = Transaction::new_signed_with_payer( - &[system_instruction::transfer( - &context.payer.pubkey(), - recipient, - amount, - )], - Some(&context.payer.pubkey()), - &[&context.payer], - context.last_blockhash, - ); - context - .banks_client - .process_transaction(transaction) - .await - .unwrap(); -} - -pub async fn advance_epoch(context: &mut ProgramTestContext) { - refresh_blockhash(context).await; - - let root_slot = context.banks_client.get_root_slot().await.unwrap(); - let slots_per_epoch = context.genesis_config().epoch_schedule.slots_per_epoch; - context.warp_to_slot(root_slot + slots_per_epoch).unwrap(); -} - -pub async fn refresh_blockhash(context: &mut ProgramTestContext) { - context.last_blockhash = context - .banks_client - .get_new_latest_blockhash(&context.last_blockhash) - .await - .unwrap(); -} - -pub async fn get_account(banks_client: &mut BanksClient, pubkey: &Pubkey) -> SolanaAccount { - banks_client - .get_account(*pubkey) - .await - .expect("client error") - .expect("account not found") -} - -pub async fn get_stake_account( - banks_client: &mut BanksClient, - pubkey: &Pubkey, -) -> (Meta, Option, u64) { - let stake_account = get_account(banks_client, pubkey).await; - let lamports = stake_account.lamports; - match bincode::deserialize::(&stake_account.data).unwrap() { - StakeStateV2::Initialized(meta) => (meta, None, lamports), - StakeStateV2::Stake(meta, stake, _) => (meta, Some(stake), lamports), - StakeStateV2::Uninitialized => panic!("panic: uninitialized"), - _ => unimplemented!(), - } -} - -pub async fn get_stake_account_rent(banks_client: &mut BanksClient) -> u64 { - let rent = banks_client.get_rent().await.unwrap(); - rent.minimum_balance(std::mem::size_of::()) -} - -pub async fn get_effective_stake(banks_client: &mut BanksClient, pubkey: &Pubkey) -> u64 { - let clock = banks_client.get_sysvar::().await.unwrap(); - let stake_history = banks_client.get_sysvar::().await.unwrap(); - let stake_account = get_account(banks_client, pubkey).await; - match bincode::deserialize::(&stake_account.data).unwrap() { - StakeStateV2::Stake(_, stake, _) => { - stake - .delegation - .stake_activating_and_deactivating(clock.epoch, &stake_history, Some(0)) - .effective - } - _ => 0, - } -} - -pub async fn create_independent_stake_account( - context: &mut ProgramTestContext, - authorized: &Authorized, - stake_amount: u64, -) -> Pubkey { - create_independent_stake_account_with_lockup( - context, - authorized, - &Lockup::default(), - stake_amount, - ) - .await -} - -pub async fn create_independent_stake_account_with_lockup( - context: &mut ProgramTestContext, - authorized: &Authorized, - lockup: &Lockup, - stake_amount: u64, -) -> Pubkey { - let stake = Keypair::new(); - let lamports = get_stake_account_rent(&mut context.banks_client).await + stake_amount; - - let instructions = vec![ - system_instruction::create_account( - &context.payer.pubkey(), - &stake.pubkey(), - lamports, - std::mem::size_of::() as u64, - &id(), - ), - ixn::initialize(&stake.pubkey(), authorized, lockup), - ]; - - let transaction = Transaction::new_signed_with_payer( - &instructions, - Some(&context.payer.pubkey()), - &[&context.payer, &stake], - context.last_blockhash, - ); - - context - .banks_client - .process_transaction(transaction) - .await - .unwrap(); - - stake.pubkey() -} - -pub async fn create_blank_stake_account(context: &mut ProgramTestContext) -> Pubkey { - let stake = Keypair::new(); - create_blank_stake_account_from_keypair(context, &stake, false).await -} - -pub async fn create_closed_stake_account(context: &mut ProgramTestContext) -> Pubkey { - let stake = Keypair::new(); - create_blank_stake_account_from_keypair(context, &stake, true).await -} - -pub async fn create_blank_stake_account_from_keypair( - context: &mut ProgramTestContext, - stake: &Keypair, - is_closed: bool, -) -> Pubkey { - // lamports in a "closed" account is arbitrary, a real one via split/merge/withdraw would have 0 - let lamports = get_stake_account_rent(&mut context.banks_client).await; - - let transaction = Transaction::new_signed_with_payer( - &[system_instruction::create_account( - &context.payer.pubkey(), - &stake.pubkey(), - lamports, - if is_closed { - 0 - } else { - StakeStateV2::size_of() as u64 - }, - &id(), - )], - Some(&context.payer.pubkey()), - &[&context.payer, stake], - context.last_blockhash, - ); - - context - .banks_client - .process_transaction(transaction) - .await - .unwrap(); - - stake.pubkey() -} - -pub async fn process_instruction( - context: &mut ProgramTestContext, - instruction: &Instruction, - additional_signers: &T, -) -> ProgramResult { - let mut transaction = - Transaction::new_with_payer(&[instruction.clone()], Some(&context.payer.pubkey())); - - transaction.partial_sign(&[&context.payer], context.last_blockhash); - transaction.sign(additional_signers, context.last_blockhash); - - match context.banks_client.process_transaction(transaction).await { - Ok(_) => Ok(()), - Err(e) => { - // banks client error -> transaction error -> instruction error -> program error - match e.unwrap() { - TransactionError::InstructionError(_, e) => Err(e.try_into().unwrap()), - TransactionError::InsufficientFundsForRent { .. } => { - Err(ProgramError::InsufficientFunds) - } - _ => panic!("couldnt convert {:?} to ProgramError", e), - } - } - } -} - -pub async fn process_instruction_test_missing_signers( - context: &mut ProgramTestContext, - instruction: &Instruction, - additional_signers: &Vec<&Keypair>, -) { - // remove every signer one by one and ensure we always fail - for i in 0..instruction.accounts.len() { - if instruction.accounts[i].is_signer { - let mut instruction = instruction.clone(); - instruction.accounts[i].is_signer = false; - let reduced_signers: Vec<_> = additional_signers - .iter() - .filter(|s| s.pubkey() != instruction.accounts[i].pubkey) - .collect(); - - let e = process_instruction(context, &instruction, &reduced_signers) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::MissingRequiredSignature); - } - } - - // now make sure the instruction succeeds - process_instruction(context, instruction, additional_signers) - .await - .unwrap(); -} - -#[tokio::test] -async fn program_test_stake_checked_instructions() { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let staker_keypair = Keypair::new(); - let withdrawer_keypair = Keypair::new(); - let authorized_keypair = Keypair::new(); - let seed_base_keypair = Keypair::new(); - let custodian_keypair = Keypair::new(); - - let staker = staker_keypair.pubkey(); - let withdrawer = withdrawer_keypair.pubkey(); - let authorized = authorized_keypair.pubkey(); - let seed_base = seed_base_keypair.pubkey(); - let custodian = custodian_keypair.pubkey(); - - let seed = "test seed"; - let seeded_address = Pubkey::create_with_seed(&seed_base, seed, &system_program::id()).unwrap(); - - // Test AuthorizeChecked with non-signing staker - let stake = - create_independent_stake_account(&mut context, &Authorized { staker, withdrawer }, 0).await; - let instruction = - ixn::authorize_checked(&stake, &staker, &authorized, StakeAuthorize::Staker, None); - - process_instruction_test_missing_signers( - &mut context, - &instruction, - &vec![&staker_keypair, &authorized_keypair], - ) - .await; - - // Test AuthorizeChecked with non-signing withdrawer - let stake = - create_independent_stake_account(&mut context, &Authorized { staker, withdrawer }, 0).await; - let instruction = ixn::authorize_checked( - &stake, - &withdrawer, - &authorized, - StakeAuthorize::Withdrawer, - None, - ); - - process_instruction_test_missing_signers( - &mut context, - &instruction, - &vec![&withdrawer_keypair, &authorized_keypair], - ) - .await; - - // Test AuthorizeCheckedWithSeed with non-signing authority - for authority_type in [StakeAuthorize::Staker, StakeAuthorize::Withdrawer] { - let stake = - create_independent_stake_account(&mut context, &Authorized::auto(&seeded_address), 0) - .await; - let instruction = ixn::authorize_checked_with_seed( - &stake, - &seed_base, - seed.to_string(), - &system_program::id(), - &authorized, - authority_type, - None, - ); - - process_instruction_test_missing_signers( - &mut context, - &instruction, - &vec![&seed_base_keypair, &authorized_keypair], - ) - .await; - } - - // Test SetLockupChecked with non-signing lockup custodian - let stake = - create_independent_stake_account(&mut context, &Authorized { staker, withdrawer }, 0).await; - let instruction = ixn::set_lockup_checked( - &stake, - &LockupArgs { - unix_timestamp: None, - epoch: Some(1), - custodian: Some(custodian), - }, - &withdrawer, - ); - - process_instruction_test_missing_signers( - &mut context, - &instruction, - &vec![&withdrawer_keypair, &custodian_keypair], - ) - .await; -} - -#[tokio::test] -async fn program_test_authorize() { - let mut context = program_test().start_with_context().await; - let accounts = Accounts::default(); - accounts.initialize(&mut context).await; - - let rent_exempt_reserve = get_stake_account_rent(&mut context.banks_client).await; - - let stakers: [_; 3] = std::array::from_fn(|_| Keypair::new()); - let withdrawers: [_; 3] = std::array::from_fn(|_| Keypair::new()); - - let stake_keypair = Keypair::new(); - let stake = create_blank_stake_account_from_keypair(&mut context, &stake_keypair, false).await; - - // authorize uninitialized fails - for (authority, authority_type) in [ - (&stakers[0], StakeAuthorize::Staker), - (&withdrawers[0], StakeAuthorize::Withdrawer), - ] { - let instruction = ixn::authorize(&stake, &stake, &authority.pubkey(), authority_type, None); - let e = process_instruction(&mut context, &instruction, &vec![&stake_keypair]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::InvalidAccountData); - } - - let authorized = Authorized { - staker: stakers[0].pubkey(), - withdrawer: withdrawers[0].pubkey(), - }; - - let instruction = ixn::initialize(&stake, &authorized, &Lockup::default()); - process_instruction(&mut context, &instruction, NO_SIGNERS) - .await - .unwrap(); - - // changing authority works - for (old_authority, new_authority, authority_type) in [ - (&stakers[0], &stakers[1], StakeAuthorize::Staker), - (&withdrawers[0], &withdrawers[1], StakeAuthorize::Withdrawer), - ] { - let instruction = ixn::authorize( - &stake, - &old_authority.pubkey(), - &new_authority.pubkey(), - authority_type, - None, - ); - process_instruction_test_missing_signers(&mut context, &instruction, &vec![old_authority]) - .await; - - let (meta, _, _) = get_stake_account(&mut context.banks_client, &stake).await; - let actual_authority = match authority_type { - StakeAuthorize::Staker => meta.authorized.staker, - StakeAuthorize::Withdrawer => meta.authorized.withdrawer, - }; - assert_eq!(actual_authority, new_authority.pubkey()); - } - - // old authority no longer works - for (old_authority, new_authority, authority_type) in [ - (&stakers[0], Pubkey::new_unique(), StakeAuthorize::Staker), - ( - &withdrawers[0], - Pubkey::new_unique(), - StakeAuthorize::Withdrawer, - ), - ] { - let instruction = ixn::authorize( - &stake, - &old_authority.pubkey(), - &new_authority, - authority_type, - None, - ); - let e = process_instruction(&mut context, &instruction, &vec![old_authority]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::MissingRequiredSignature); - } - - // changing authority again works - for (old_authority, new_authority, authority_type) in [ - (&stakers[1], &stakers[2], StakeAuthorize::Staker), - (&withdrawers[1], &withdrawers[2], StakeAuthorize::Withdrawer), - ] { - let instruction = ixn::authorize( - &stake, - &old_authority.pubkey(), - &new_authority.pubkey(), - authority_type, - None, - ); - process_instruction_test_missing_signers(&mut context, &instruction, &vec![old_authority]) - .await; - - let (meta, _, _) = get_stake_account(&mut context.banks_client, &stake).await; - let actual_authority = match authority_type { - StakeAuthorize::Staker => meta.authorized.staker, - StakeAuthorize::Withdrawer => meta.authorized.withdrawer, - }; - assert_eq!(actual_authority, new_authority.pubkey()); - } - - // changing withdrawer using staker fails - let instruction = ixn::authorize( - &stake, - &stakers[2].pubkey(), - &Pubkey::new_unique(), - StakeAuthorize::Withdrawer, - None, - ); - let e = process_instruction(&mut context, &instruction, &vec![&stakers[2]]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::MissingRequiredSignature); - - // changing staker using withdrawer is fine - let instruction = ixn::authorize( - &stake, - &withdrawers[2].pubkey(), - &stakers[0].pubkey(), - StakeAuthorize::Staker, - None, - ); - process_instruction_test_missing_signers(&mut context, &instruction, &vec![&withdrawers[2]]) - .await; - - let (meta, _, _) = get_stake_account(&mut context.banks_client, &stake).await; - assert_eq!(meta.authorized.staker, stakers[0].pubkey()); - - // withdraw using staker fails - for staker in stakers { - let recipient = Pubkey::new_unique(); - let instruction = ixn::withdraw( - &stake, - &staker.pubkey(), - &recipient, - rent_exempt_reserve, - None, - ); - let e = process_instruction(&mut context, &instruction, &vec![&staker]) - .await - .unwrap_err(); - assert_eq!(e, ProgramError::MissingRequiredSignature); - } -} - -#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] -pub enum StakeLifecycle { - Uninitialized = 0, - Initialized, - Activating, - Active, - Deactivating, - Deactive, - Closed, -} -impl StakeLifecycle { - // (stake, staker, withdrawer) - pub async fn new_stake_account( - self, - context: &mut ProgramTestContext, - vote_account: &Pubkey, - staked_amount: u64, - ) -> (Keypair, Keypair, Keypair) { - let stake_keypair = Keypair::new(); - let staker_keypair = Keypair::new(); - let withdrawer_keypair = Keypair::new(); - - self.new_stake_account_fully_specified( - context, - vote_account, - staked_amount, - &stake_keypair, - &staker_keypair, - &withdrawer_keypair, - &Lockup::default(), - ) - .await; - - (stake_keypair, staker_keypair, withdrawer_keypair) - } - - #[allow(clippy::too_many_arguments)] - pub async fn new_stake_account_fully_specified( - self, - context: &mut ProgramTestContext, - vote_account: &Pubkey, - staked_amount: u64, - stake_keypair: &Keypair, - staker_keypair: &Keypair, - withdrawer_keypair: &Keypair, - lockup: &Lockup, - ) { - let is_closed = self == StakeLifecycle::Closed; - - let stake = - create_blank_stake_account_from_keypair(context, stake_keypair, is_closed).await; - if staked_amount > 0 { - transfer(context, &stake, staked_amount).await; - } - - if is_closed { - return; - } - - let authorized = Authorized { - staker: staker_keypair.pubkey(), - withdrawer: withdrawer_keypair.pubkey(), - }; - - if self >= StakeLifecycle::Initialized { - let instruction = ixn::initialize(&stake, &authorized, lockup); - process_instruction(context, &instruction, NO_SIGNERS) - .await - .unwrap(); - } - - if self >= StakeLifecycle::Activating { - let instruction = ixn::delegate_stake(&stake, &staker_keypair.pubkey(), vote_account); - process_instruction(context, &instruction, &vec![staker_keypair]) - .await - .unwrap(); - } - - if self >= StakeLifecycle::Active { - advance_epoch(context).await; - assert_eq!( - get_effective_stake(&mut context.banks_client, &stake).await, - staked_amount, - ); - } - - if self >= StakeLifecycle::Deactivating { - let instruction = ixn::deactivate_stake(&stake, &staker_keypair.pubkey()); - process_instruction(context, &instruction, &vec![staker_keypair]) - .await - .unwrap(); - } - - if self == StakeLifecycle::Deactive { - advance_epoch(context).await; - assert_eq!( - get_effective_stake(&mut context.banks_client, &stake).await, - 0, - ); - } - } - - // NOTE the program enforces that a deactive stake adheres to the split minimum, - // albeit spuriously after solana-program/stake-program #1 is addressed, - // Self::Deactive should move to false equivalently this could be combined - // with withdraw_minimum_enforced into a function minimum_enforced - pub fn split_minimum_enforced(&self) -> bool { - match self { - Self::Activating | Self::Active | Self::Deactivating | Self::Deactive => true, - Self::Uninitialized | Self::Initialized | Self::Closed => false, - } - } - - pub fn withdraw_minimum_enforced(&self) -> bool { - match self { - Self::Activating | Self::Active | Self::Deactivating => true, - Self::Uninitialized | Self::Initialized | Self::Deactive | Self::Closed => false, - } - } -} diff --git a/program/tests/set_lockup.rs b/program/tests/set_lockup.rs new file mode 100644 index 00000000..f556d90a --- /dev/null +++ b/program/tests/set_lockup.rs @@ -0,0 +1,35 @@ +#![allow(clippy::arithmetic_side_effects)] + +mod helpers; + +use { + helpers::{ + context::StakeTestContext, instruction_builders::SetLockupCheckedConfig, + lifecycle::StakeLifecycle, + }, + mollusk_svm::result::Check, + solana_pubkey::Pubkey, + solana_stake_interface::instruction as ixn, +}; + +#[test] +fn test_set_lockup_checked() { + let mut ctx = StakeTestContext::new(); + + let custodian = Pubkey::new_unique(); + + let (stake, initialized_stake_account) = ctx.stake_account(StakeLifecycle::Initialized).build(); + + ctx.process_with(SetLockupCheckedConfig { + stake: (&stake, &initialized_stake_account), + lockup_args: &ixn::LockupArgs { + unix_timestamp: None, + epoch: Some(1), + custodian: Some(custodian), + }, + custodian: &ctx.withdrawer, + }) + .checks(&[Check::success()]) + .test_missing_signers(true) + .execute(); +}