Skip to content

Conversation

@jesopo
Copy link
Member

@jesopo jesopo commented Jun 16, 2022

No description provided.

@jesopo jesopo marked this pull request as ready for review June 16, 2022 09:17
@dwfreed
Copy link
Member

dwfreed commented Jun 16, 2022

Note that authproc does not check whether IsGotId is set already, so if for some reason the webirc gateway is running both identd and wanting to spoof username via WEBIRC the identd will most likely override the spoof.

@jesopo jesopo requested a review from dwfreed June 16, 2022 12:22
#define FLAGS_EXEMPTSHIDE 0x04000000
#define FLAGS_EXEMPTJUPE 0x08000000
#define FLAGS_IDENTIFIED 0x10000000 /* owns their current nick */
#define FLAGS_USER_SPOOFING 0x00000080 /* username has already been set, so ignore it in USER */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collides with FLAGS_GOTID


/* dont replace username if its supposed to be spoofed --fl */
if(!IsConfDoSpoofIp(aconf) || !strchr(aconf->info.name, '@'))
if(!IsUserSpoof(source_p))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above-mentioned collision means that this if is always true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants