Skip to content

Commit 63ff64c

Browse files
Merge pull request #8 from solarspace-dev/share-code
Fix bundle
2 parents b47e100 + 091a6d8 commit 63ff64c

File tree

6 files changed

+63
-10
lines changed

6 files changed

+63
-10
lines changed

vscode-ext/.vscodeignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ vsc-extension-quickstart.md
1212
**/*.map
1313
**/*.ts
1414
**/.vscode-test.*
15+
webview/dist/**

vscode-ext/package-lock.json

Lines changed: 38 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vscode-ext/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"publisher": "solarspace",
44
"displayName": "Solar Space",
55
"description": "Sharable URLs for GitHub codespaces",
6-
"version": "0.0.7",
6+
"version": "0.0.8",
77
"license": "GPL-3.0-only",
88
"engines": {
99
"vscode": "^1.90.0"
@@ -36,7 +36,7 @@
3636
"build": "npm run build:webview && npm run build:ext",
3737
"compile": "webpack",
3838
"watch": "webpack --watch",
39-
"package": "webpack --mode production --devtool hidden-source-map",
39+
"package": "npm run build:webview && webpack --mode production --devtool hidden-source-map",
4040
"compile-tests": "tsc -p . --outDir out",
4141
"watch-tests": "tsc -p . -w --outDir out",
4242
"pretest": "npm run compile-tests && npm run compile && npm run lint",
@@ -51,6 +51,7 @@
5151
"@typescript-eslint/parser": "^8.7.0",
5252
"@vscode/test-cli": "^0.0.10",
5353
"@vscode/test-electron": "^2.4.1",
54+
"copy-webpack-plugin": "^13.0.0",
5455
"eslint": "^9.13.0",
5556
"ts-loader": "^9.5.1",
5657
"typescript": "^5.6.3",

vscode-ext/src/extension.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -282,11 +282,16 @@ async function createPanel (context: vscode.ExtensionContext): Promise<vscode.We
282282
},
283283
{
284284
enableScripts: true,
285-
localResourceRoots: [vscode.Uri.file(context.extensionPath)]
285+
localResourceRoots: [
286+
vscode.Uri.file(context.extensionPath),
287+
vscode.Uri.file(path.join(context.extensionPath, 'dist')),
288+
vscode.Uri.file(path.join(context.extensionPath, 'dist', 'webview')),
289+
]
286290
}
287291
);
288292
panel.webview.html = await readHtml(
289-
path.resolve(context.extensionPath, 'webview/index.html'),
293+
context,
294+
path.resolve(context.extensionPath, 'dist/webview/index.html'),
290295
panel
291296
);
292297
return panel;
@@ -303,10 +308,10 @@ async function saveImage (data: string): Promise<void> {
303308
}
304309
}
305310

306-
async function readHtml (htmlPath: string, panel: vscode.WebviewPanel): Promise<string> {
311+
async function readHtml(context: vscode.ExtensionContext, htmlPath: string, panel: vscode.WebviewPanel): Promise<string> {
307312
const template = await readFile(htmlPath, 'utf-8');
308-
const mainCss = panel.webview.asWebviewUri(vscode.Uri.file(path.resolve(htmlPath, '../dist/style.css')));
309-
const mainJs = panel.webview.asWebviewUri(vscode.Uri.file(path.resolve(htmlPath, '../dist/index.js')));
313+
const mainCss = panel.webview.asWebviewUri(vscode.Uri.file(path.resolve(context.extensionPath, 'dist/webview/style.css')));
314+
const mainJs = panel.webview.asWebviewUri(vscode.Uri.file(path.resolve(context.extensionPath, 'dist/webview/index.js')));
310315
const html = template
311316
.replace(/%CSP_SOURCE%/gu, panel.webview.cspSource)
312317
.replace('./style.css', mainCss.toString())

vscode-ext/webpack.config.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
'use strict';
44

55
const path = require('path');
6+
const CopyPlugin = require('copy-webpack-plugin');
67

78
//@ts-check
89
/** @typedef {import('webpack').Configuration} WebpackConfig **/
@@ -40,6 +41,13 @@ const extensionConfig = {
4041
}
4142
]
4243
},
44+
plugins: [
45+
new CopyPlugin({
46+
patterns: [
47+
{ from: path.resolve(__dirname, 'webview/dist'), to: path.resolve(__dirname, 'dist/webview') }
48+
],
49+
}),
50+
],
4351
devtool: 'nosources-source-map',
4452
infrastructureLogging: {
4553
level: "log", // enables logging required for problem matchers

vscode-ext/webview/index.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
/>
1111
<title>Share Space</title>
1212
<link rel="stylesheet" href="./style.css" />
13-
<script src="./src/index.ts" type="module"></script>
1413
</head>
1514

1615
<body>
@@ -59,5 +58,8 @@
5958
Copy Snapshot
6059
</button>
6160
</div>
61+
62+
63+
<script src="./src/index.ts"></script>
6264
</body>
6365
</html>

0 commit comments

Comments
 (0)