HTTP: Correctly check snprintf() return value.

cabelitos · cabelitos · commit 1893b4ac6115 · 2016-03-15T15:30:09.000-03:00
Signed-off-by: Guilherme Iscaro &lt;guilherme.iscaro@intel.com&gt;
diff --git a/src/lib/comms/sol-http-server-impl-microhttpd.c b/src/lib/comms/sol-http-server-impl-microhttpd.c
@@ -454,7 +454,7 @@ get_default_response(const struct sol_http_server *server, enum sol_http_status_
     }
 
     r = snprintf(buf, sizeof(buf), "status - %d", error);
-    if (r < 0 || r > (int)sizeof(buf)) {
+    if (r < 0 || r >= (int)sizeof(buf)) {
         SOL_WRN("Could not set the status code on response body");
         response = MHD_create_response_from_buffer(0, NULL, MHD_RESPMEM_PERSISTENT);
     } else {

Original file line number	Diff line number	Diff line change
`@@ -454,7 +454,7 @@ get_default_response(const struct sol_http_server *server, enum sol_http_status_`
`454`	`454`	`}`
`455`	`455`
`456`	`456`	`r = snprintf(buf, sizeof(buf), "status - %d", error);`
`457`		`- if (r < 0 \|\| r > (int)sizeof(buf)) {`
	`457`	`+ if (r < 0 \|\| r >= (int)sizeof(buf)) {`
`458`	`458`	`SOL_WRN("Could not set the status code on response body");`
`459`	`459`	`response = MHD_create_response_from_buffer(0, NULL, MHD_RESPMEM_PERSISTENT);`
`460`	`460`	`} else {`