form: Fix memory leak

ceolin · ceolin · commit 92e554152ef7 · 2016-01-26T16:45:43.000-02:00
sol_buffer_init is being called inside a loop without the
sol_buffer_fini causing the previous allocated data being lost.

Signed-off-by: Flavio Ceolin &lt;flavio.ceolin@intel.com&gt;
diff --git a/src/modules/flow/form/form.c b/src/modules/flow/form/form.c
@@ -3226,6 +3226,7 @@ string_formatted_open(struct sol_flow_node *node,
         numeric_field_present = true;
 
         ptr = tmp + 1;
+        sol_buffer_fini(&mdata->formatted_value);
     }
 
     if (!numeric_field_present) {

Original file line number	Diff line number	Diff line change
`@@ -3226,6 +3226,7 @@ string_formatted_open(struct sol_flow_node *node,`
`3226`	`3226`	`numeric_field_present = true;`
`3227`	`3227`
`3228`	`3228`	`ptr = tmp + 1;`
	`3229`	`+ sol_buffer_fini(&mdata->formatted_value);`
`3229`	`3230`	`}`
`3230`	`3231`
`3231`	`3232`	`if (!numeric_field_present) {`