Skip to content

Cleanup should delte id too? #34

@Joeysantoro

Description

@Joeysantoro

https://github.com/solidity-labs-io/safe-time-guard/blob/a70a7592226a39fb3d11c01a16ac369ff4051b52/src/Timelock.sol#L685

After cleanup on an expired operation, timestamp is still set so

  1. isOperationExpired is still true
  2. the assert statement can be hit on a second call to cleanup
  3. The specific id of the expired operation can no longer be called at all because schedule calls will fail and there is no way to delete the id anymore

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions