Skip to content

[vite] exports order incorrect for vite #17

@waynevanson

Description

@waynevanson

Hey there!

I'm using this preset in the vite config's rollupOptions, and receive the following warning from vite when running vite build after following the instructions from print instructions.

Screenshot of error message

Image

Export from `rollup-preset-solid`
".": {
     "solid": "./dist/source/index.jsx",
     "import": "./dist/esm/index.js",
     "browser": "./dist/esm/index.js",
     "require": "./dist/esm/index.js",
     "node": "./dist/esm/index.js"
   }
Exports that remove the warning
".": {
      "solid": "./dist/source/index.jsx",
      "node": "./dist/esm/index.js",
      "browser": "./dist/esm/index.js",
      "import": "./dist/esm/index.js",
      "require": "./dist/esm/index.js"
    }

We should change presets to use the latter.

Would you accept this as an issue? If so I can create a PR.

This preset is awesome, thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions