feat: check that template is valid before attempting to create it

Author: Tommypop2

packages/create/src/index.ts

@@ -6,10 +6,9 @@ import { createStart } from "./create-start";
 import {
 	getTemplatesList,
 	GIT_IGNORE,
+	isValidTemplate,
 	PROJECT_TYPES,
 	ProjectType,
-	StartTemplate,
-	VanillaTemplate,
 } from "./utils/constants";
 import { detectPackageManager } from "@solid-cli/utils/package-manager";
 import { existsSync, writeFileSync } from "node:fs";
@@ -111,25 +110,29 @@ export const createSolid = (version: string) =>
 
 			// Need to transpile if the user wants Jabascript, but their selected template isn't Javascript
 			const transpileToJS = useJS && !template.startsWith("js");
-			if (projectType === "start") {
+			if (projectType === "start" && isValidTemplate("start", template)) {
 				await spinnerify({
 					startText: "Creating project",
 					finishText: "Project created 🎉",
-					fn: () => createStart({ template: template as StartTemplate, destination: projectName }, transpileToJS),
+					fn: () => createStart({ template, destination: projectName }, transpileToJS),
 				});
-			} else if (projectType === "library") {
+			} else if (projectType === "library" && isValidTemplate("library", template)) {
 				await spinnerify({
 					startText: "Creating project",
 					finishText: "Project created 🎉",
 					fn: () => createLibrary({ destination: projectName }),
 				});
-			} else {
+			} else if (projectType === "vanilla" && isValidTemplate(projectType, template)) {
 				await spinnerify({
 					startText: "Creating project",
 					finishText: "Project created 🎉",
-					fn: () => createVanilla({ template: template as VanillaTemplate, destination: projectName }, transpileToJS),
+					fn: () => createVanilla({ template, destination: projectName }, transpileToJS),
 				});
 			}
+			else {
+				p.log.error(`Template ${template} is not valid for project type ${projectType}`);
+				process.exit(0);
+			}
 			// Add .gitignore
 			writeFileSync(join(projectName, ".gitignore"), GIT_IGNORE);
 			// Add "Created with Solid CLI" text to bottom of README

packages/create/src/utils/constants.ts

@@ -112,10 +112,10 @@ export function getTemplatesList(projectType: ProjectType) {
  * @param maybe_template the template string to test
  * @returns the template string if it is valid, undefined if not
  */
-export function isValidTemplate(type: "vanilla", maybe_template: string): VanillaTemplate;
-export function isValidTemplate(type: "start", maybe_template: string): StartTemplate;
-export function isValidTemplate(type: "library", maybe_template: string): LibraryTemplate;
+export function isValidTemplate(type: "vanilla", maybe_template: string): maybe_template is VanillaTemplate;
+export function isValidTemplate(type: "start", maybe_template: string): maybe_template is StartTemplate;
+export function isValidTemplate(type: "library", maybe_template: string): maybe_template is LibraryTemplate;
 export function isValidTemplate(type: ProjectType, maybe_template: string) {
 	const templates = getTemplatesList(type);
-	return templates.find(t => t === maybe_template)
+	return templates.find(t => t === maybe_template) !== undefined
 }