test(signals): disable hotTime in attribution tests asserting exact w… #2323
ryansolidAnnotations
4 errors and 1 warning
|
job
Process completed with exit code 1.
|
|
job
@solidjs/signals#coverage: command (/home/runner/work/solid/solid/packages/signals) /home/runner/setup-pnpm/node_modules/.bin/pnpm run coverage exited (1)
|
|
tests/attribution-benchmark-eval.test.ts > healthy fine-grained benchmark implementation (false-positive control) > update-every-10th-row over a store emits zero perf diagnostics:
packages/signals/tests/attribution-benchmark-eval.test.ts#L236
AssertionError: expected [ { sequence: 11, …(6) } ] to have a length of +0 but got 1
- Expected
+ Received
- 0
+ 1
❯ tests/attribution-benchmark-eval.test.ts:236:56
|
|
tests/attribution-benchmark-eval.test.ts > JSFB select-row (naive: every row reads the selected signal) > stays quiet on the selector-inverted version (the correct fix):
packages/signals/tests/attribution-benchmark-eval.test.ts#L162
AssertionError: expected [ { sequence: 9, …(6) } ] to have a length of +0 but got 1
- Expected
+ Received
- 0
+ 1
❯ tests/attribution-benchmark-eval.test.ts:162:56
|
|
job
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-node@v4, pnpm/action-setup@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|