Skip to content

Commit 63c7cb5

Browse files
ryansolidnickshirocursoragent
committed
test(babel-plugin,compiler): pin the #3127 report's exact cases in the universal fixture
Adopted from @nickshiro's PR #3144, which fixed the babel text half the same way hours before 320f1f5 landed both compilers. Co-authored-by: nickshiro <nickshiro@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 320f1f5 commit 63c7cb5

4 files changed

Lines changed: 108 additions & 77 deletions

File tree

  • packages
    • babel-plugin/test/__universal_fixtures__/textInterpolation
    • compiler/__tests__/fixtures

‎packages/babel-plugin/test/__universal_fixtures__/textInterpolation/code.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ const escape3 = <>
5252

5353
const injection = <span>Hi{"<script>alert();</script>"}</span>;
5454

55+
const staticLessThan = <item>{"<span> restyles a run"}</item>;
56+
const staticAmpersand = <item>{"<b> & <i>"}</item>;
57+
const jsxEntity = <item>lit &lt; text</item>;
58+
5559
let value = "World";
5660
const evaluated = <span>Hello {value + "!"}</span>;
5761

‎packages/babel-plugin/test/__universal_fixtures__/textInterpolation/output.js‎

Lines changed: 35 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -86,44 +86,53 @@ var _el$26 = _$createElement("span"),
8686
_el$27 = _$createTextNode(`Hi<script>alert();</script>`);
8787
_$insertNode(_el$26, _el$27);
8888
const injection = _el$26;
89+
var _el$29 = _$createElement("item");
90+
_$insertNode(_el$29, _$createTextNode(`<span> restyles a run`));
91+
const staticLessThan = _el$29;
92+
var _el$31 = _$createElement("item");
93+
_$insertNode(_el$31, _$createTextNode(`<b> & <i>`));
94+
const staticAmpersand = _el$31;
95+
var _el$33 = _$createElement("item");
96+
_$insertNode(_el$33, _$createTextNode(`lit < text`));
97+
const jsxEntity = _el$33;
8998
let value = "World";
90-
var _el$29 = _$createElement("span"),
91-
_el$30 = _$createTextNode(`Hello World!`);
92-
_$insertNode(_el$29, _el$30);
93-
const evaluated = _el$29;
94-
let number = 4 + 5;
95-
var _el$32 = _$createElement("span"),
96-
_el$33 = _$createTextNode(`4 + 5 = 9`);
97-
_$insertNode(_el$32, _el$33);
98-
const evaluatedNonString = _el$32;
99-
var _el$35 = _$createElement("div"),
100-
_el$36 = _$createTextNode(`\nd`);
99+
var _el$35 = _$createElement("span"),
100+
_el$36 = _$createTextNode(`Hello World!`);
101101
_$insertNode(_el$35, _el$36);
102-
_$insert(_el$35, s, _el$36);
103-
const newLineLiteral = _el$35;
104-
var _el$38 = _$createElement("div");
105-
_$insert(_el$38, expr);
106-
const trailingSpace = _el$38;
102+
const evaluated = _el$35;
103+
let number = 4 + 5;
104+
var _el$38 = _$createElement("span"),
105+
_el$39 = _$createTextNode(`4 + 5 = 9`);
106+
_$insertNode(_el$38, _el$39);
107+
const evaluatedNonString = _el$38;
108+
var _el$41 = _$createElement("div"),
109+
_el$42 = _$createTextNode(`\nd`);
110+
_$insertNode(_el$41, _el$42);
111+
_$insert(_el$41, s, _el$42);
112+
const newLineLiteral = _el$41;
113+
var _el$44 = _$createElement("div");
114+
_$insert(_el$44, expr);
115+
const trailingSpace = _el$44;
107116
const trailingSpaceComp = _$createComponent(Comp, {
108117
children: expr
109118
});
110119
const trailingSpaceFrag = expr;
111-
var _el$39 = _$createElement("span"),
112-
_el$40 = _$createTextNode(` `);
113-
_$insertNode(_el$39, _el$40);
114-
_$insert(_el$39, expr, null);
115-
const leadingSpaceElement = _el$39;
120+
var _el$45 = _$createElement("span"),
121+
_el$46 = _$createTextNode(` `);
122+
_$insertNode(_el$45, _el$46);
123+
_$insert(_el$45, expr, null);
124+
const leadingSpaceElement = _el$45;
116125
const leadingSpaceComponent = _$createComponent(Div, {
117126
get children() {
118127
return [" ", expr];
119128
}
120129
});
121130
const leadingSpaceFragment = [" ", expr];
122-
var _el$41 = _$createElement("span"),
123-
_el$42 = _$createTextNode(` `);
124-
_$insertNode(_el$41, _el$42);
125-
_$insert(_el$41, expr, _el$42);
126-
const trailingSpaceElement = _el$41;
131+
var _el$47 = _$createElement("span"),
132+
_el$48 = _$createTextNode(` `);
133+
_$insertNode(_el$47, _el$48);
134+
_$insert(_el$47, expr, _el$48);
135+
const trailingSpaceElement = _el$47;
127136
const trailingSpaceComponent = _$createComponent(Div, {
128137
get children() {
129138
return [expr, " "];

‎packages/compiler/__tests__/fixtures/dynamic-universal/textInterpolation/output.js‎

Lines changed: 35 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -74,40 +74,49 @@ var _el$21 = _$createElement("span");
7474
var _el$22 = _$createTextNode("Hi<script>alert();<\/script>");
7575
_$insertNode(_el$21, _el$22);
7676
const injection = _el$21;
77+
var _el$23 = _$createElement("item");
78+
_$insertNode(_el$23, _$createTextNode("<span> restyles a run"));
79+
const staticLessThan = _el$23;
80+
var _el$24 = _$createElement("item");
81+
_$insertNode(_el$24, _$createTextNode("<b> & <i>"));
82+
const staticAmpersand = _el$24;
83+
var _el$25 = _$createElement("item");
84+
_$insertNode(_el$25, _$createTextNode("lit < text"));
85+
const jsxEntity = _el$25;
7786
let value = "World";
78-
var _el$23 = _$createElement("span");
79-
var _el$24 = _$createTextNode("Hello World!");
80-
_$insertNode(_el$23, _el$24);
81-
const evaluated = _el$23;
87+
var _el$26 = _$createElement("span");
88+
var _el$27 = _$createTextNode("Hello World!");
89+
_$insertNode(_el$26, _el$27);
90+
const evaluated = _el$26;
8291
let number = 4 + 5;
83-
var _el$25 = _$createElement("span");
84-
var _el$26 = _$createTextNode("4 + 5 = 9");
85-
_$insertNode(_el$25, _el$26);
86-
const evaluatedNonString = _el$25;
87-
var _el$27 = _$createElement("div");
88-
var _el$28 = _$createTextNode("\nd");
89-
_$insertNode(_el$27, _el$28);
90-
_$insert(_el$27, s, _el$28);
91-
const newLineLiteral = _el$27;
92-
var _el$29 = _$createElement("div");
93-
_$insert(_el$29, expr);
94-
const trailingSpace = _el$29;
92+
var _el$28 = _$createElement("span");
93+
var _el$29 = _$createTextNode("4 + 5 = 9");
94+
_$insertNode(_el$28, _el$29);
95+
const evaluatedNonString = _el$28;
96+
var _el$30 = _$createElement("div");
97+
var _el$31 = _$createTextNode("\nd");
98+
_$insertNode(_el$30, _el$31);
99+
_$insert(_el$30, s, _el$31);
100+
const newLineLiteral = _el$30;
101+
var _el$32 = _$createElement("div");
102+
_$insert(_el$32, expr);
103+
const trailingSpace = _el$32;
95104
const trailingSpaceComp = _$createComponent(Comp, { children: expr });
96105
const trailingSpaceFrag = expr;
97-
var _el$30 = _$createElement("span");
98-
var _el$31 = _$createTextNode(" ");
99-
_$insertNode(_el$30, _el$31);
100-
_$insert(_el$30, expr, null);
101-
const leadingSpaceElement = _el$30;
106+
var _el$33 = _$createElement("span");
107+
var _el$34 = _$createTextNode(" ");
108+
_$insertNode(_el$33, _el$34);
109+
_$insert(_el$33, expr, null);
110+
const leadingSpaceElement = _el$33;
102111
const leadingSpaceComponent = _$createComponent(Div, { get children() {
103112
return [" ", expr];
104113
} });
105114
const leadingSpaceFragment = [" ", expr];
106-
var _el$32 = _$createElement("span");
107-
var _el$33 = _$createTextNode(" ");
108-
_$insertNode(_el$32, _el$33);
109-
_$insert(_el$32, expr, _el$33);
110-
const trailingSpaceElement = _el$32;
115+
var _el$35 = _$createElement("span");
116+
var _el$36 = _$createTextNode(" ");
117+
_$insertNode(_el$35, _el$36);
118+
_$insert(_el$35, expr, _el$36);
119+
const trailingSpaceElement = _el$35;
111120
const trailingSpaceComponent = _$createComponent(Div, { get children() {
112121
return [expr, " "];
113122
} });

‎packages/compiler/__tests__/fixtures/universal/textInterpolation/output.js‎

Lines changed: 34 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -70,34 +70,43 @@ var _el$22 = _$createTextNode("Hi<script>alert();<\/script>");
7070
_$insertNode(_el$21, _el$22);
7171
/* prettier-ignore */
7272
const injection = _el$21;
73+
var _el$23 = _$createElement("item");
74+
_$insertNode(_el$23, _$createTextNode("<span> restyles a run"));
75+
const staticLessThan = _el$23;
76+
var _el$24 = _$createElement("item");
77+
_$insertNode(_el$24, _$createTextNode("<b> & <i>"));
78+
const staticAmpersand = _el$24;
79+
var _el$25 = _$createElement("item");
80+
_$insertNode(_el$25, _$createTextNode("lit < text"));
81+
const jsxEntity = _el$25;
7382
let value = "World";
74-
var _el$23 = _$createElement("span");
75-
var _el$24 = _$createTextNode("Hello World!");
76-
_$insertNode(_el$23, _el$24);
77-
const evaluated = _el$23;
83+
var _el$26 = _$createElement("span");
84+
var _el$27 = _$createTextNode("Hello World!");
85+
_$insertNode(_el$26, _el$27);
86+
const evaluated = _el$26;
7887
let number = 4 + 5;
79-
var _el$25 = _$createElement("span");
80-
var _el$26 = _$createTextNode("4 + 5 = 9");
81-
_$insertNode(_el$25, _el$26);
82-
const evaluatedNonString = _el$25;
83-
var _el$27 = _$createElement("div");
84-
var _el$28 = _$createTextNode("\nd");
85-
_$insertNode(_el$27, _el$28);
86-
_$insert(_el$27, s, _el$28);
87-
const newLineLiteral = _el$27;
88-
var _el$29 = _$createElement("div");
89-
_$insert(_el$29, expr);
90-
const trailingSpace = _el$29;
91-
var _el$30 = _$createElement("span");
92-
var _el$31 = _$createTextNode(" ");
88+
var _el$28 = _$createElement("span");
89+
var _el$29 = _$createTextNode("4 + 5 = 9");
90+
_$insertNode(_el$28, _el$29);
91+
const evaluatedNonString = _el$28;
92+
var _el$30 = _$createElement("div");
93+
var _el$31 = _$createTextNode("\nd");
9394
_$insertNode(_el$30, _el$31);
94-
_$insert(_el$30, expr, null);
95-
const leadingSpaceElement = _el$30;
96-
var _el$32 = _$createElement("span");
97-
var _el$33 = _$createTextNode(" ");
98-
_$insertNode(_el$32, _el$33);
99-
_$insert(_el$32, expr, _el$33);
100-
const trailingSpaceElement = _el$32;
95+
_$insert(_el$30, s, _el$31);
96+
const newLineLiteral = _el$30;
97+
var _el$32 = _$createElement("div");
98+
_$insert(_el$32, expr);
99+
const trailingSpace = _el$32;
100+
var _el$33 = _$createElement("span");
101+
var _el$34 = _$createTextNode(" ");
102+
_$insertNode(_el$33, _el$34);
103+
_$insert(_el$33, expr, null);
104+
const leadingSpaceElement = _el$33;
105+
var _el$35 = _$createElement("span");
106+
var _el$36 = _$createTextNode(" ");
107+
_$insertNode(_el$35, _el$36);
108+
_$insert(_el$35, expr, _el$36);
109+
const trailingSpaceElement = _el$35;
101110
const escapeAttribute = _$createElement("div", {
102111
normal: "Search…",
103112
title: "Search&hellip;"

0 commit comments

Comments
 (0)