Are createMemo and createEffect necessary in this port of React's use-gesture?

[imedadel]

I am porting parts of use-gesture from React to Solid and I'm confused about using createMemo and createEffect. The original code uses useMemo and useEffect in React, should I follow the same model?

export function useRecognizers<Config extends GenericOptions>(
  handlers: InternalHandlers,
  config: Config | {} = {},
  gestureKey?: GestureKey,
  nativeHandlers?: NativeHandlers
): HookReturnType<Config> {
  const ctrl = React.useMemo(() => new Controller(handlers), [])
  ctrl.applyHandlers(handlers, nativeHandlers)
  ctrl.applyConfig(config, gestureKey)

  React.useEffect(ctrl.effect.bind(ctrl))

  React.useEffect(() => {
    return ctrl.clean.bind(ctrl)
  }, [])

  // When target is undefined we return the bind function of the controller which
  // returns prop handlers.
  // @ts-ignore
  if (config.target === undefined) {
    return ctrl.bind.bind(ctrl) as any
  }
  return undefined as any
}

My first draft looked like this:

export function useRecognizers<Config extends GenericOptions>(
  handlers: InternalHandlers,
  config: Config | {} = {},
  gestureKey?: GestureKey,
  nativeHandlers?: NativeHandlers
): HookReturnType<Config> {
  const ctrl = createMemo(() => new Controller(handlers))
  ctrl().applyHandlers(handlers, nativeHandlers)
  ctrl().applyConfig(config, gestureKey)

  createEffect(ctrl().effect.bind(ctrl()))

  createEffect(() => {
    return ctrl().clean.bind(ctrl())
  })

  // When target is undefined we return the bind function of the controller which
  // returns prop handlers.
  // @ts-ignore
  if (config.target === undefined) {
    return ctrl().bind.bind(ctrl()) as any
  }
  return undefined as any
}

I tried avoiding createMemo and relying on onMount and onCleanup and it works without any issues. Am I doing it right?

export function useRecognizers<Config extends GenericOptions>(
  handlers: InternalHandlers,
  config: Config | {} = {},
  gestureKey?: GestureKey,
  nativeHandlers?: NativeHandlers
): HookReturnType<Config> {
  const ctrl = new Controller(handlers)
  ctrl.applyHandlers(handlers, nativeHandlers)
  ctrl.applyConfig(config, gestureKey)

  onMount(() => {
    ctrl.effect.bind(ctrl)
  })

  onCleanup(() => {
    ctrl.clean.bind(ctrl)
  })

  // When target is undefined we return the bind function of the controller which
  // returns prop handlers.
  // @ts-ignore
  if (config.target === undefined) {
    return ctrl.bind.bind(ctrl) as any
  }
  return undefined as any
}

Thank you!

[ryansolid]

Yep because Solid only runs once, if there is nothing that requires reactive tracking and updates the createMemo is unnecessary. The empty dependency list in React is why I feel extra confident of this, since it indicates it never updates. At that point you may only need onMount to wait until after render and onCleanup to well, cleanup. I'm not even sure onMount is absolutely necessary, but maybe it's better to wait to do that part of the setup until after render.