Skip to content

Commit 946b1f1

Browse files
authored
Merge pull request #42 from kjriga/fix-github-actions-workflow
Fix Github actions test runs
2 parents 839144d + afbfdf3 commit 946b1f1

File tree

13 files changed

+44
-42
lines changed

13 files changed

+44
-42
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -19,36 +19,19 @@ jobs:
1919
fail-fast: true
2020
matrix:
2121
rails-version:
22-
- "7.2"
23-
- "8.0"
22+
- "7.0"
2423
ruby-version:
24+
- "3.1"
2525
- "3.2"
26-
- "3.4"
26+
- "3.3"
2727
solidus-branch:
28-
- "v4.1"
29-
- "v4.2"
30-
- "v4.3"
31-
- "v4.4"
32-
- "v4.5"
28+
- "v3.2"
29+
- "v3.3"
30+
- "v3.4"
3331
database:
3432
- "postgresql"
3533
- "mysql"
3634
- "sqlite"
37-
exclude:
38-
- rails-version: "7.2"
39-
solidus-branch: "v4.3"
40-
- rails-version: "7.2"
41-
solidus-branch: "v4.2"
42-
- rails-version: "7.2"
43-
solidus-branch: "v4.1"
44-
- ruby-version: "3.4"
45-
rails-version: "7.0"
46-
- ruby-version: "3.2"
47-
rails-version: "8.0"
48-
- solidus-branch: "v4.3"
49-
rails-version: "8.0"
50-
- solidus-branch: "v4.4"
51-
rails-version: "8.0"
5235
steps:
5336
- uses: actions/checkout@v4
5437
- name: Run extension tests

Gemfile

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
source 'https://rubygems.org'
44
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
55

6-
branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
7-
solidus_git, solidus_frontend_git = if (branch == 'master') || (branch >= 'v3.2')
6+
branch = ENV.fetch('SOLIDUS_BRANCH', 'v3.4')
7+
solidus_git, solidus_frontend_git = if (branch == 'main') || (branch == 'master') || (branch >= 'v3.2')
88
%w[solidusio/solidus solidusio/solidus_frontend]
99
else
1010
%w[solidusio/solidus] * 2
@@ -20,13 +20,25 @@ gem 'rails', '>0.a'
2020
# Provides basic authentication functionality for testing parts of your engine
2121
gem 'solidus_auth_devise'
2222

23+
# Standard library gems that became separate in Ruby 3.4+
24+
gem 'bigdecimal'
25+
gem 'mutex_m'
26+
gem 'drb'
27+
gem 'csv'
28+
gem 'ostruct'
29+
30+
# This is locked due to a 'stack level too deep' error/bug in v0.1.0.
31+
gem 'state_machines', '~> 0.6.0'
32+
33+
gem 'concurrent-ruby', '1.3.4'
34+
2335
case ENV['DB']
2436
when 'mysql'
2537
gem 'mysql2'
2638
when 'postgresql'
2739
gem 'pg'
2840
else
29-
gem 'sqlite3'
41+
gem 'sqlite3', '~> 1.4'
3042
end
3143

3244
gemspec

Rakefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# frozen_string_literal: true
22

3+
require 'logger'
34
require 'solidus_dev_support/rake_tasks'
45
SolidusDevSupport::RakeTasks.install
56

app/decorators/models/solidus_tracking/spree/order/track_order_fulfillment.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ module SolidusTracking
44
module Spree
55
module Order
66
module TrackOrderFulfillment
7-
def self.prepended(base)
8-
base.after_update :track_fulfilled_order
7+
extend ActiveSupport::Concern
8+
9+
prepended do
10+
after_update :track_fulfilled_order
911
end
1012

1113
private

app/decorators/models/solidus_tracking/spree/order/track_order_lifecycle.rb

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@ module SolidusTracking
44
module Spree
55
module Order
66
module TrackOrderLifecycle
7-
def self.prepended(base)
8-
base.state_machine.after_transition to: :address, do: :track_started_checkout
9-
base.state_machine.after_transition to: :complete, do: :track_ordered_product
10-
base.state_machine.after_transition to: :complete, do: :track_placed_order
11-
base.state_machine.after_transition to: :canceled, do: :track_cancelled_order
7+
extend ActiveSupport::Concern
8+
9+
prepended do
10+
state_machine.after_transition to: :address, do: :track_started_checkout
11+
state_machine.after_transition to: :complete, do: :track_ordered_product
12+
state_machine.after_transition to: :complete, do: :track_placed_order
13+
state_machine.after_transition to: :canceled, do: :track_cancelled_order
1214
end
1315

1416
private

app/decorators/models/solidus_tracking/spree/user/track_signup.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ module SolidusTracking
44
module Spree
55
module User
66
module TrackSignup
7-
def self.prepended(base)
8-
base.after_commit :track_signup, on: :create
7+
extend ActiveSupport::Concern
8+
9+
prepended do
10+
after_commit :track_signup, on: :create
911
end
1012

1113
private

spec/solidus_tracking/event/cancelled_order_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
end
5050

5151
it 'includes an event ID and value' do
52-
order = build_stubbed(:order)
52+
order = create(:order)
5353
allow(SolidusTracking::Serializer::LineItem).to receive(:serialize)
5454
.with(order)
5555
.and_return('foo' => 'bar')

spec/solidus_tracking/event/fulfilled_order_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
end
5050

5151
it 'includes an event ID and value' do
52-
order = build_stubbed(:order)
52+
order = create(:order)
5353
allow(SolidusTracking::Serializer::LineItem).to receive(:serialize)
5454
.with(order)
5555
.and_return('foo' => 'bar')

spec/solidus_tracking/event/placed_order_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
end
5050

5151
it 'includes an event ID and value' do
52-
order = build_stubbed(:order)
52+
order = create(:order)
5353
allow(SolidusTracking::Serializer::LineItem).to receive(:serialize)
5454
.with(order)
5555
.and_return('foo' => 'bar')

spec/solidus_tracking/event/started_checkout_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
end
5050

5151
it 'includes an event ID and value' do
52-
order = build_stubbed(:order)
52+
order = create(:order)
5353
allow(SolidusTracking::Serializer::LineItem).to receive(:serialize)
5454
.with(order)
5555
.and_return('foo' => 'bar')

0 commit comments

Comments
 (0)