Skip to content

Commit aa84714

Browse files
authored
update Makefile targets (#10)
* update Makefile targets * tidy * go mod tidy
1 parent 2d5adc2 commit aa84714

File tree

5 files changed

+167
-27
lines changed

5 files changed

+167
-27
lines changed

Makefile

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ PACKAGE_PATH:=github.com/solo-io/anyvendor
77
OUTPUT_DIR ?= $(ROOTDIR)/_output
88
SOURCES := $(shell find . -name "*.go" | grep -v test.go)
99
VERSION ?= $(shell git describe --tags)
10+
DEPSGOBIN=$(shell pwd)/.bin
1011

1112
#----------------------------------------------------------------------------------
1213
# Repo init
@@ -23,12 +24,13 @@ init:
2324

2425
.PHONY: update-deps
2526
update-deps: mod-download
26-
GO111MODULE=off go get -u golang.org/x/tools/cmd/goimports
27-
GO111MODULE=off go get -u github.com/golang/protobuf/protoc-gen-go
28-
GO111MODULE=off go get -u github.com/envoyproxy/protoc-gen-validate
29-
GO111MODULE=off go install github.com/envoyproxy/protoc-gen-validate
30-
GO111MODULE=off go get -u github.com/golang/mock/gomock
31-
GO111MODULE=off go install github.com/golang/mock/mockgen
27+
mkdir -p $(DEPSGOBIN)
28+
PATH=$(DEPSGOBIN):$$PATH go get -u golang.org/x/tools/cmd/goimports
29+
PATH=$(DEPSGOBIN):$$PATH go get -u github.com/golang/protobuf/protoc-gen-go
30+
PATH=$(DEPSGOBIN):$$PATH go get -u github.com/envoyproxy/protoc-gen-validate
31+
PATH=$(DEPSGOBIN):$$PATH go install github.com/envoyproxy/protoc-gen-validate
32+
PATH=$(DEPSGOBIN):$$PATH go get -u github.com/golang/mock/gomock
33+
PATH=$(DEPSGOBIN):$$PATH go install github.com/golang/mock/mockgen
3234

3335

3436
.PHONY: mod-download
@@ -44,7 +46,8 @@ generated-code: $(OUTPUT_DIR)/.generated-code
4446

4547
SUBDIRS:=pkg anyvendor
4648
$(OUTPUT_DIR)/.generated-code:
47-
mkdir -p ${OUTPUT_DIR}
48-
$(GO_BUILD_FLAGS) go generate ./...
49-
goimports -w $(SUBDIRS)
50-
touch $@
49+
PATH=$(DEPSGOBIN):$$PATH mkdir -p ${OUTPUT_DIR}
50+
PATH=$(DEPSGOBIN):$$PATH $(GO_BUILD_FLAGS) go generate ./...
51+
PATH=$(DEPSGOBIN):$$PATH goimports -w $(SUBDIRS)
52+
PATH=$(DEPSGOBIN):$$PATH go mod tidy
53+
PATH=$(DEPSGOBIN):$$PATH touch $@

ci/check-code-gen.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ PATH=/workspace/gopath/bin:$PATH
1212

1313
set +e
1414

15-
make generated-code -B
15+
make update-deps generated-code -B
1616
if [[ $? -ne 0 ]]; then
1717
echo "Code generation failed"
1818
exit 1;
1919
fi
2020
if [[ $(git status --porcelain | wc -l) -ne 0 ]]; then
2121
echo "Generating code produced a non-empty diff."
22-
echo "Try running 'dep ensure && make install-codegen-deps generated-code -B' then re-pushing."
22+
echo "Try running 'make update-deps generated-code -B' then re-pushing."
2323
git status --porcelain
2424
git diff | cat
2525
exit 1;

go.mod

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,20 @@ module github.com/solo-io/anyvendor
33
go 1.13
44

55
require (
6-
github.com/envoyproxy/protoc-gen-validate v0.1.0
7-
github.com/golang/mock v1.3.1
8-
github.com/golang/protobuf v1.3.2
9-
github.com/iancoleman/strcase v0.0.0-20191112232945-16388991a334 // indirect
10-
github.com/lyft/protoc-gen-star v0.4.14 // indirect
6+
github.com/envoyproxy/protoc-gen-validate v0.4.1
7+
github.com/golang/mock v1.4.4
8+
github.com/golang/protobuf v1.4.3
9+
github.com/iancoleman/strcase v0.1.3 // indirect
10+
github.com/lyft/protoc-gen-star v0.5.2 // indirect
1111
github.com/mattn/go-zglob v0.0.3
1212
github.com/onsi/ginkgo v1.11.0
1313
github.com/onsi/gomega v1.8.1
1414
github.com/rotisserie/eris v0.1.1
15-
github.com/spf13/afero v1.2.2
16-
github.com/stretchr/testify v1.6.1 // indirect
15+
github.com/spf13/afero v1.5.1
16+
golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5 // indirect
17+
golang.org/x/mod v0.4.1 // indirect
18+
golang.org/x/net v0.0.0-20210119194325-5f4716e94777 // indirect
19+
golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c // indirect
20+
golang.org/x/text v0.3.5 // indirect
21+
golang.org/x/tools v0.1.0 // indirect
1722
)

0 commit comments

Comments
 (0)