test failing extractor config; add break to switch (#23)

* test failing extractor config; add break to switch
solo-io · Sep 2, 2019 · 90aada7 · 90aada7
1 parent 2d3466c
commit 90aada7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/source/extensions/filters/http/transformation/inja_transformer.cc b/source/extensions/filters/http/transformation/inja_transformer.cc
@@ -135,12 +135,15 @@ InjaTransformer::InjaTransformer(
       throw EnvoyException(
           fmt::format("Failed to parse body template {}", e.what()));
     }
+    break;
   }
   case envoy::api::v2::filter::http::TransformationTemplate::
       kMergeExtractorsToBody: {
     merged_extractors_to_body_ = true;
+    break;
   }
   case envoy::api::v2::filter::http::TransformationTemplate::kPassthrough:
+    break;
   case envoy::api::v2::filter::http::TransformationTemplate::
       BODY_TRANSFORMATION_NOT_SET: {
     break;

diff --git a/test/extensions/filters/http/transformation/inja_transformer_test.cc b/test/extensions/filters/http/transformation/inja_transformer_test.cc
@@ -113,6 +113,19 @@ TEST(ExtractorUtil, ExtractIdFromHeader) {
   EXPECT_EQ("123", res);
 }
 
+TEST(ExtractorUtil, ExtractorFail) {
+  Http::TestHeaderMapImpl headers{{":method", "GET"},
+                                  {":authority", "www.solo.io"},
+                                  {":path", "/users/123"}};
+  envoy::api::v2::filter::http::Extraction extractor;
+  extractor.set_header(":path");
+  extractor.set_regex("ILLEGAL REGEX \\ \\ \\ \\ a\\ \\a\\ a\\  \\d+)");
+  extractor.set_subgroup(1);
+  EXPECT_THROW_WITH_MESSAGE(Extractor a(extractor), EnvoyException,
+                            "Invalid regex 'ILLEGAL REGEX \\ \\ \\ \\ a\\ "
+                            "\\a\\ a\\  \\d+)': regex_error");
+}
+
 TEST(Transformer, transform) {
   Http::TestHeaderMapImpl headers{{":method", "GET"},
                                   {":authority", "www.solo.io"},