Skip to content

Commit 5875e84

Browse files
Rachael-GrahamNadine2016artberger
authored
Doc fixes (#10624)
Co-authored-by: Nadine Spies <[email protected]> Co-authored-by: Art Berger <[email protected]> Co-authored-by: changelog-bot <changelog-bot>
1 parent 9a001ee commit 5875e84

File tree

5 files changed

+25
-12
lines changed

5 files changed

+25
-12
lines changed
+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
changelog:
2+
- type: NON_USER_FACING
3+
resolvesIssue: true
4+
description: >-
5+
Weekly doc fixes and minor updates.

docs/content/guides/security/access_logging/_index.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -411,14 +411,14 @@ You can apply different filters on your access logs to reduce and optimize the n
411411

412412
### Using status code filters
413413

414-
You can apply access log filters to requests that match a specific HTTP status code by using the `defaultValue` or `runtimeKey` option.
414+
You can apply access log filters to requests that match a specific HTTP status code by using the `defaultValue` and `runtimeKey` option.
415415

416416
**Option 1: Use `defaultValue`** </br>
417417

418418
Use the `defaultValue` option in the Gateway resource to specify the HTTP status code for which you want to apply the access log filter. Note that the `defaultValue` is set for a specific Gateway only. To apply the same HTTP status code to multiple Gateway resources, see `Option 2: Override the default value with a runtime key-value pair`.
419419

420420
1. Follow the steps in [File-based](#file-based-access-logging) or [gRPC](#grpc-access-logging) access logging to enable access logging for your gateway.
421-
2. To apply additional filters to your access logs, you create or edit your gateway resource and add the access log filters to the `spec.options.accessLoggingService.accessLog` section. The following example uses file-based access logging and captures access logs only for requests with an HTTP response code that is greater than or equal to 400.
421+
2. To apply additional filters to your access logs, you create or edit your gateway resource and add the access log filters to the `spec.options.accessLoggingService.accessLog` section. The following example uses file-based access logging and captures access logs only for requests with an HTTP response code that is greater than or equal to 400. Note that the `runtimeKey` overrides any settings in `defaultValue`, so in this example, the `runtimeKey` is also set to 400.
422422
```yaml
423423
apiVersion: gateway.solo.io/v1
424424
kind: Gateway
@@ -445,6 +445,7 @@ Use the `defaultValue` option in the Gateway resource to specify the HTTP status
445445
op: GE
446446
value:
447447
defaultValue: 400
448+
runtimeKey: "400"
448449
proxyNames:
449450
- gateway-proxy
450451
ssl: false
@@ -467,7 +468,7 @@ Note that the `runtimeKey` is enforced only if it matches a key that is defined
467468
3. Create or edit your gateway resource and add the access log filters to the `spec.options.accessLoggingService.accessLog` section. The following example uses file-based access logging and captures access logs only for requests with an HTTP response code that is greater than or equal to what is defined in the `access_log_status_filter` runtime value.
468469

469470
{{% notice note %}}
470-
Note that the `runtimeKey` overrides any settings in `defaultValue`
471+
Note that the `runtimeKey` overrides any settings in `defaultValue`.
471472
{{% /notice %}}
472473

473474
```yaml

docs/content/guides/traffic_management/request_processing/upstream_health_checks/_index.md

+14-7
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,21 @@ weight: 50
44
description: Automatically monitor the status of Upstreams by configuring health checks for them
55
---
66

7-
As part of configuring an Upstream, Gloo Gateway provides the option of adding *health checks* that periodically assess the readiness of the Upstream to receive requests. See the [Envoy documentation](https://www.envoyproxy.io/docs/envoy/v1.14.1/intro/arch_overview/upstream/health_checking#arch-overview-health-checking) for more information.
7+
As part of configuring an Upstream, Gloo Gateway provides the option of adding *health checks* that periodically assess the readiness of the Upstream to receive requests. For more information, see the [Envoy documentation](https://www.envoyproxy.io/docs/envoy/v1.14.1/intro/arch_overview/upstream/health_checking#arch-overview-health-checking).
88

99
{{% notice note %}}
10-
Upstreams with working health checks will not be removed from Envoy's service directory, even due to configuration changes. To allow them to be removed, set `ignoreHealthOnHostRemoval` in the Upstream's configuration.
10+
Upstreams with working health checks are not removed from Envoy's service directory, even due to configuration changes. To allow removal in such cases, set `ignoreHealthOnHostRemoval` in the Upstream's configuration.
1111
{{% /notice %}}
12+
1213
## Configuration
1314

14-
Descriptions of the options available for configuring health checks can be found {{< protobuf name="solo.io.envoy.api.v2.core.HealthCheck" display="here" >}}.
15+
Review the following sections for example configuration settings of common use cases. For descriptions of each field, refer to the [API documentation]({{% versioned_link_path fromRoot="/reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/options/healthcheck/healthcheck.proto.sk/" %}}).
1516

1617
### Custom paths for HttpHealthChecks
1718

18-
There is a way to add custom paths to health check requests shown in the example below.
19+
To add custom paths to health check requests, review the following example.
1920

20-
{{< highlight yaml >}}
21+
```yaml
2122
spec:
2223
healthChecks:
2324
- healthyThreshold: 1
@@ -26,6 +27,12 @@ spec:
2627
interval: 30s
2728
timeout: 10s
2829
unhealthyThreshold: 1
29-
{{< /highlight >}}
30+
```
3031
31-
A `path` represents an explicitly-specified path to check the health of the upstream. The `timeout` declares how much time between checks there should be. An `unhealthyThreshold` is the limit of checks that are allowed to fail before declaring the upstream unhealthy. A `healthyThreshold` is the limit of checks that are allowed to pass before declaring an upstream healthy. The `interval` is the interval of time that you send `healthchecks` as to not overload your upstream service.
32+
| Setting | Description |
33+
| --- | --- |
34+
| `path` | The specific path to send the health check request to the upstream. Make sure that the backing destination handles health checks along this path. |
35+
| `timeout` | The amount of time that the health check waits for a response before considering the request unsuccessful and timing out. |
36+
| `unhealthyThreshold` | The number of checks that can fail before the upstream is considered unhealthy. The example allows only one failed health check. |
37+
| `healthyThreshold` | The number of checks that must succeed before an upstream is considered healthy. The example requires only one successful health check.
38+
| `interval` | How often the health check sends requests. Set a value that will not overload your upstream service. |

docs/content/operations/production_deployment/_index.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ global:
214214
extAuth:
215215
signingKey:
216216
name: extauth-signing-key
217-
signing-key: <signing-key-value>
217+
key: <signing-key-value>
218218
```
219219

220220
#### Pod Disruption Budgets and Affinity/Anti-Affinity rules

docs/content/reference/api/_index.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Gloo Edge is a high-performance, plugin-extendable, platform-agnostic API Gatewa
1919
Gateway
2020
- Gateway: {{< protobuf name="gateway.solo.io.Gateway" >}}
2121
- HTTPGateway: {{< protobuf name="gateway.solo.io.HttpGateway" >}}
22-
- HTTPListenerOptions: {{< protobuf name="gloo.solo.io.HTTPListenerOptions" >}}
22+
- HTTPListenerOptions: {{< protobuf name="gloo.solo.io.HttpListenerOptions" >}}
2323
- ListenerOptions: {{< protobuf name="gloo.solo.io.ListenerOptions" >}}
2424
- TCPGateway: {{< protobuf name="gateway.solo.io.TcpGateway" >}}
2525

0 commit comments

Comments
 (0)