Skip to content

Commit 5d4f634

Browse files
authored
[1.18] 6748-spawn-upstream-span-backport (#10566)
1 parent db4142d commit 5d4f634

File tree

13 files changed

+99
-12
lines changed

13 files changed

+99
-12
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
2+
changelog:
3+
- type: FIX
4+
issueLink: https://github.com/solo-io/solo-projects/issues/6748
5+
resolvesIssue: true
6+
description: >
7+
Expose spawn_upstream_span on the tracing API. This setting tells
8+
envoy to spawn a new span for each upstream request.
9+
10+

docs/content/reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/options/tracing/tracing.proto.sk.md

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

install/helm/gloo/crds/gateway.solo.io_v1_Gateway.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,6 +1143,8 @@ spec:
11431143
nullable: true
11441144
type: string
11451145
type: array
1146+
spawnUpstreamSpan:
1147+
type: boolean
11461148
tracePercentages:
11471149
properties:
11481150
clientSamplePercentage:
@@ -1821,6 +1823,8 @@ spec:
18211823
nullable: true
18221824
type: string
18231825
type: array
1826+
spawnUpstreamSpan:
1827+
type: boolean
18241828
tracePercentages:
18251829
properties:
18261830
clientSamplePercentage:
@@ -3165,6 +3169,8 @@ spec:
31653169
nullable: true
31663170
type: string
31673171
type: array
3172+
spawnUpstreamSpan:
3173+
type: boolean
31683174
tracePercentages:
31693175
properties:
31703176
clientSamplePercentage:

install/helm/gloo/crds/gateway.solo.io_v1_HttpListenerOption.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1134,6 +1134,8 @@ spec:
11341134
nullable: true
11351135
type: string
11361136
type: array
1137+
spawnUpstreamSpan:
1138+
type: boolean
11371139
tracePercentages:
11381140
properties:
11391141
clientSamplePercentage:

install/helm/gloo/crds/gateway.solo.io_v1_MatchableHttpGateway.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1137,6 +1137,8 @@ spec:
11371137
nullable: true
11381138
type: string
11391139
type: array
1140+
spawnUpstreamSpan:
1141+
type: boolean
11401142
tracePercentages:
11411143
properties:
11421144
clientSamplePercentage:

projects/gloo/api/v1/options/tracing/tracing.proto

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,11 @@ message ListenerTracingSettings {
4343
repeated TracingTagEnvironmentVariable environment_variables_for_tags = 6;
4444
// Optional. If specified, Envoy will include the literals with the given tag as tracing tags.
4545
repeated TracingTagLiteral literals_for_tags = 7;
46+
47+
// Optional
48+
// Create separate tracing span for each upstream request if true. And if this flag is set to true, the tracing provider will assume that Envoy
49+
// will be independent hop in the trace chain and may set span type to client or server based on this flag.
50+
bool spawn_upstream_span = 10;
4651
}
4752

4853
// Contains settings for configuring Envoy's tracing capabilities at the route level.

projects/gloo/pkg/api/v1/options/tracing/tracing.pb.clone.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projects/gloo/pkg/api/v1/options/tracing/tracing.pb.equal.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projects/gloo/pkg/api/v1/options/tracing/tracing.pb.go

Lines changed: 16 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projects/gloo/pkg/api/v1/options/tracing/tracing.pb.hash.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)