Skip to content

Commit 64c87b7

Browse files
ryanroldsandy-fong
andauthored
HTTP tunneling documentation improvements (#10706)
Co-authored-by: Andy Fong <[email protected]>
1 parent f1931d9 commit 64c87b7

File tree

7 files changed

+25
-8
lines changed

7 files changed

+25
-8
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
changelog:
2+
- type: FIX
3+
description: >-
4+
Improved HTTP tunneling documentation and added note about remote JWKS configuration
5+
using an upstream with `httpProxyHostname` requiring additional configuration.
6+
issueLink: https://github.com/solo-io/solo-projects/issues/7497
7+
resolvesIssue: false

docs/content/reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/enterprise/options/jwt/jwt.proto.sk.md

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/content/reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/upstream.proto.sk.md

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projects/gloo/api/v1/enterprise/options/jwt/jwt.proto

+3
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,9 @@ message RemoteJwks {
124124
// This is used to set the host and path in the request
125125
string url = 1;
126126
// The Upstream representing the Json Web Key Set server
127+
//
128+
// Note: Setting this to an upstream using an HTTP tunnel (`httpProxyHostname`)
129+
// requires also using that upstream in a route.
127130
core.solo.io.ResourceRef upstream_ref = 2;
128131
// Duration after which the cached JWKS should be expired.
129132
// If not specified, default cache duration is 5 minutes.

projects/gloo/api/v1/upstream.proto

+5-3
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,10 @@ message Upstream {
139139
// See [RFC7540, sec. 8.1](https://datatracker.ietf.org/doc/html/rfc7540#section-8.1) for details.
140140
google.protobuf.BoolValue override_stream_error_on_invalid_http_message = 26;
141141

142-
// Tells envoy that the upstream is an HTTP proxy (e.g., another proxy in a DMZ) that supports HTTP Connect.
143-
// This configuration sets the hostname used as part of the HTTP Connect request.
142+
// Tells Envoy that the upstream is an HTTP proxy that supports [HTTP CONNECT method](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/CONNECT).
143+
// The hostname is the destination of the tunnel established by the proxy.
144+
// Some Envoy Command Operators (.e.g `%REQUESTED_SERVER_NAME%`) are supported allowing for dynamic destinations.
145+
//
144146
// For example, setting to: host.com:443 and making a request routed to the upstream such as `curl <envoy>:<port>/v1`
145147
// would result in the following request:
146148
//
@@ -152,7 +154,7 @@ message Upstream {
152154
// user-agent: curl/7.64.1
153155
// accept: */*
154156
//
155-
// Note: if setting this field to a hostname rather than IP:PORT, you may want to also set `host_rewrite` on the route
157+
// Note: If setting this field to a hostname rather than IP:PORT, you may want to also set `host_rewrite` on the route
156158
google.protobuf.StringValue http_proxy_hostname = 21;
157159

158160
// HttpConnectSslConfig contains the options necessary to configure envoy to originate TLS to an HTTP Connect proxy.

projects/gloo/pkg/api/v1/enterprise/options/jwt/jwt.pb.go

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projects/gloo/pkg/api/v1/upstream.pb.go

+5-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)