Should skip install update (#10568)

sheidkamp · web-flow · commit 7d09cd753320 · 2025-01-13T17:54:42.000Z
diff --git a/changelog/v1.19.0-beta3/ShouldSkipInstall-update.yaml b/changelog/v1.19.0-beta3/ShouldSkipInstall-update.yaml
@@ -0,0 +1,6 @@
+changelog:
+  - type: FIX
+    issueLink: https://github.com/solo-io/solo-projects/issues/7432
+    resolvesIssue: false
+    description: >-
+      Export IsGatewayInstalled for use in other packages
diff --git a/test/kubernetes/e2e/test.go b/test/kubernetes/e2e/test.go
@@ -197,13 +197,13 @@ func (i *TestInstallation) InstallGlooGatewayWithTestHelper(ctx context.Context,
 	i.InstallGlooGateway(ctx, installFn)
 }
 
-func (i *TestInstallation) isGatewayInstalled(ctx context.Context) bool {
+func (i *TestInstallation) IsGatewayInstalled(ctx context.Context) bool {
 	return i.Assertions.CheckResourcesOk(ctx) == nil
 }
 
 func (i *TestInstallation) InstallGlooGateway(ctx context.Context, installFn func(ctx context.Context) error) {
 
-	if !testutils.ShouldSkipInstall(i.isGatewayInstalled(ctx)) {
+	if !testutils.ShouldSkipInstall(i.IsGatewayInstalled(ctx)) {
 		err := installFn(ctx)
 		i.Assertions.Require.NoError(err)
 		i.Assertions.EventuallyInstallationSucceeded(ctx)

Original file line number	Diff line number	Diff line change
`@@ -197,13 +197,13 @@ func (i *TestInstallation) InstallGlooGatewayWithTestHelper(ctx context.Context,`
`197`	`197`	`i.InstallGlooGateway(ctx, installFn)`
`198`	`198`	`}`
`199`	`199`
`200`		`-func (i *TestInstallation) isGatewayInstalled(ctx context.Context) bool {`
	`200`	`+func (i *TestInstallation) IsGatewayInstalled(ctx context.Context) bool {`
`201`	`201`	`return i.Assertions.CheckResourcesOk(ctx) == nil`
`202`	`202`	`}`
`203`	`203`
`204`	`204`	`func (i *TestInstallation) InstallGlooGateway(ctx context.Context, installFn func(ctx context.Context) error) {`
`205`	`205`
`206`		`- if !testutils.ShouldSkipInstall(i.isGatewayInstalled(ctx)) {`
	`206`	`+ if !testutils.ShouldSkipInstall(i.IsGatewayInstalled(ctx)) {`
`207`	`207`	`err := installFn(ctx)`
`208`	`208`	`i.Assertions.Require.NoError(err)`
`209`	`209`	`i.Assertions.EventuallyInstallationSucceeded(ctx)`