Skip to content

Commit fef8641

Browse files
authored
Merge pull request #10349 from solo-io/fix-unit-tests-gloo
fix failing unit tests
2 parents f40d935 + c559bed commit fef8641

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/pr-unit-tests.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ name: Unit Tests
66
#
77
# Our historical unit tests are run via CloudBuild
88
# Overtime, it would be valuable to consolidate these approaches
9+
env:
10+
VERSION: '1.0.0-ci1'
11+
GITHUB_TOKEN: ${{ github.token }}
912

1013
on:
1114
pull_request:

test/kubernetes/testutils/helper/util_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ func TestReturnsLatestPatchForMinor(t *testing.T) {
2323
ctx := context.Background()
2424
// this is fine because this is a public repo
2525
client := githubutils.GetClientWithOrWithoutToken(ctx)
26-
minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 8)
26+
minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 9)
2727
require.NoError(t, err)
2828

29-
assert.Equal(t, "v1.8.37", minor.String())
29+
assert.Equal(t, "v1.9.30", minor.String())
3030
}

0 commit comments

Comments
 (0)