Skip to content

Commit de5cb29

Browse files
authored
Update to Go 1.24 and address compilation errors (#56)
1 parent 2e54b7c commit de5cb29

File tree

6 files changed

+16
-10
lines changed

6 files changed

+16
-10
lines changed

.github/workflows/pull_request.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ jobs:
2222
- uses: actions/checkout@v3
2323
with:
2424
fetch-depth: 0
25-
- name: Set up Go 1.22.2
25+
- name: Set up Go
2626
uses: actions/setup-go@v4
2727
with:
28-
go-version: 1.22.2
28+
go-version-file: go.mod
2929
- uses: actions/cache@v3
3030
with:
3131
path: ~/go/pkg/mod

changelog/v0.10.0/go-124.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
changelog:
2+
- type: BREAKING_CHANGE
3+
description: >
4+
Bump dependencies to support Go 1.24
5+
issueLink: https://github.com/solo-io/solo-projects/issues/7609
6+
resolvesIssue: false

debugutils/kube_dump.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func KubeDumpOnFail(out io.Writer, namespaces []string, additionalCommands Names
1919
if err != nil {
2020
fmt.Fprintf(out, "getting kube dump failed: %v", err)
2121
}
22-
fmt.Fprintf(out, dump)
22+
fmt.Fprint(out, dump)
2323
}
2424
}
2525

go.mod

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/solo-io/k8s-utils
22

3-
go 1.23.0
3+
go 1.24
44

55
require (
66
github.com/avast/retry-go v2.2.0+incompatible
@@ -16,7 +16,7 @@ require (
1616
github.com/onsi/gomega v1.35.1
1717
github.com/pkg/errors v0.9.1
1818
github.com/rotisserie/eris v0.1.1
19-
github.com/solo-io/go-utils v0.27.4
19+
github.com/solo-io/go-utils v0.28.4
2020
github.com/spf13/afero v1.6.0
2121
go.uber.org/zap v1.27.0
2222
golang.org/x/sync v0.8.0

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,8 @@ github.com/shopspring/decimal v1.3.1/go.mod h1:DKyhrW/HYNuLGql+MJL6WCR6knT2jwCFR
459459
github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPxbbu5VWo=
460460
github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
461461
github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
462-
github.com/solo-io/go-utils v0.27.4 h1:/VOXUZTsIfnP+aWeWdkiWI4hCyF8nODOr1x+TX+e+dk=
463-
github.com/solo-io/go-utils v0.27.4/go.mod h1:xJncbCIrp5iovb95MReJQFf88q3P23NgB1RyGckzq7k=
462+
github.com/solo-io/go-utils v0.28.4 h1:IH3p/CttV5kzRgxBgk+beynbdFBQyxNFN2bOsgK1nGs=
463+
github.com/solo-io/go-utils v0.28.4/go.mod h1:/V0ovlR+tGhb4+QNYIffKscuhtUIEoN29mJhWjYLYA4=
464464
github.com/spf13/afero v1.6.0 h1:xoax2sJ2DT8S8xA2paPFjDCScCNeWsg75VG0DLRreiY=
465465
github.com/spf13/afero v1.6.0/go.mod h1:Ai8FlHk4v/PARR026UzYexafAt9roJ7LcLMAmO6Z93I=
466466
github.com/spf13/cast v1.3.1/go.mod h1:Qx5cxh0v+4UWYiBimWS+eyWzqEqokIECu5etghLkUJE=

installutils/helminstall/installer.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func (i *installer) Install(ctx context.Context, installerConfig *types.Installe
5858
}
5959

6060
if !installerConfig.DryRun && installerConfig.PreInstallMessage != "" {
61-
fmt.Fprintf(i.out, installerConfig.PreInstallMessage)
61+
fmt.Fprint(i.out, installerConfig.PreInstallMessage)
6262
} else {
6363
i.defaultPreInstallMessage(installerConfig)
6464
}
@@ -106,7 +106,7 @@ func (i *installer) Install(ctx context.Context, installerConfig *types.Installe
106106
return err
107107
}
108108
if !installerConfig.DryRun && installerConfig.PostInstallMessage != "" {
109-
fmt.Fprintf(i.out, installerConfig.PostInstallMessage)
109+
fmt.Fprint(i.out, installerConfig.PostInstallMessage)
110110
} else {
111111
i.defaultPostInstallMessage(installerConfig)
112112
}
@@ -116,7 +116,7 @@ func (i *installer) Install(ctx context.Context, installerConfig *types.Installe
116116
}
117117

118118
if installerConfig.DryRun {
119-
fmt.Fprintf(i.out, rel.Manifest)
119+
fmt.Fprint(i.out, rel.Manifest)
120120
}
121121

122122
return nil

0 commit comments

Comments
 (0)