Skip to content

Commit 22e66cd

Browse files
authored
Merge pull request #26 from solo-io/disableKubeMarkers-description
Fix disableKubeMarkers description
2 parents 5fffab7 + e39941e commit 22e66cd

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,4 @@ Other supported options are:
7575
* `int_native`
7676
* when set to `true`, the native openapi schemas will be used for Integer types instead of Solo wrappers that add Kubernetes extension headers to the schema to treat int as strings.
7777
* `disable_kube_markers`
78-
* when set to `true`, kubebuilder markers and validations such as PreserveUnknownFields, Required, default, and all CEL rules will be omitted from the OpenAPI schema. The Type marker will be maintained.
78+
* when set to `true`, kubebuilder markers and validations such as PreserveUnknownFields, MinItems, default, and all CEL rules will be omitted from the OpenAPI schema. The Type and Required markers will be maintained.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
changelog:
2+
- type: FIX
3+
issueLink: https://github.com/solo-io/gloo-mesh-enterprise/issues/17005
4+
resolvesIssue: false
5+
description: |
6+
Fixes the description of the disable_kube_markers option to correctly state which markers are respected and which are disabled.

openapiGenerator.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ type openapiGenerator struct {
118118

119119
markerRegistry *markers.Registry
120120

121-
// If set to true, kubebuilder markers and validations such as PreserveUnknownFields, Required, default, and all CEL rules will be omitted from the OpenAPI schema.
122-
// The Type marker will be maintained.
121+
// If set to true, kubebuilder markers and validations such as PreserveUnknownFields, MinItems, default, and all CEL rules will be omitted from the OpenAPI schema.
122+
// The Type and Required markers will be maintained.
123123
disableKubeMarkers bool
124124
}
125125

0 commit comments

Comments
 (0)