Open
Description
this line of code always throws an interface panic https://github.com/solo-io/solo-kit/blob/v0.24.2/pkg/api/v1/control-plane/cache/generic_snapshot.go#L134
we need to fix it so we can test / validate generic snapshot marshalling
resolving this will require updates to the base Resource
interface and perhaps sweeping changes across codegen
Activity
kdorosh commentedon Apr 8, 2022
also highly relevant to this part of the code https://bryanftan.medium.com/accept-interfaces-return-structs-in-go-d4cab29a301b
kdorosh commentedon Apr 13, 2022
this codepath is never currently called hence why it has not been an issue, but if we ever start getting snapshots in the ratelimit or extauth translator syncers then this code will panic