Skip to content

cannot GetSnapshot or CloneSnapshot for GenericSnapshot #461

Open
@kdorosh

Description

@kdorosh

this line of code always throws an interface panic https://github.com/solo-io/solo-kit/blob/v0.24.2/pkg/api/v1/control-plane/cache/generic_snapshot.go#L134

we need to fix it so we can test / validate generic snapshot marshalling

resolving this will require updates to the base Resource interface and perhaps sweeping changes across codegen

Activity

self-assigned this
on Mar 29, 2022
kdorosh

kdorosh commented on Apr 8, 2022

@kdorosh
ContributorAuthor
removed their assignment
on Apr 13, 2022
kdorosh

kdorosh commented on Apr 13, 2022

@kdorosh
ContributorAuthor

this codepath is never currently called hence why it has not been an issue, but if we ever start getting snapshots in the ratelimit or extauth translator syncers then this code will panic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @kdorosh

      Issue actions

        cannot `GetSnapshot` or `CloneSnapshot` for `GenericSnapshot` · Issue #461 · solo-io/solo-kit