Wrong asset id

[tima1906]

Initial Checks

• I have searched the existing issues for a duplicate and I'm sure this is something new
• I am confident that the issue in the project code

Description

I use the aiosteampy to keep statistics and look for matches between purchases and sales by float and pattern.
But I noticed that some links are broken and cannot be processed by CSFloat Api.
During my search, I found that the problem arises due to insufficient uniqueness of the parameters.
Functiion create_ident_code(mixed_data["instanceid"], mixed_data["classid"], app_id) generate code , but if (as I understand it) the same seller sells the 2 similar items ( M4 Solitude in my case), at the moment of generation MarketHistoryListingItem in _parse_assets_for_history_listings the second skin will have the assetid of the first skin. Perhaps my guess is wrong and the bug is caused by something else, but the fix helped generate it.
I just added assetid to create_ident_code in aiosteampy/mixins/market.py/:

    def _parse_item_descrs_from_my_listings_or_market_history(
        cls,
        data: dict[str, dict | list[dict]],
        item_descrs_map: T_SHARED_DESCRIPTIONS,
    ):
        # assets field, has descriptions for listings, so we can not parse descrs from listings
        for app_id, app_data in (data["assets"] or {}).items():  # thanks Steam for an empty list instead of a dict
            for context_id, context_data in app_data.items():
                for asset_id, mixed_data in context_data.items():
                    key = create_ident_code(mixed_data["instanceid"], mixed_data["classid"], asset_id, app_id) <--- added asset_id
                    if key not in item_descrs_map:
                        item_descrs_map[key] = cls._create_item_descr(mixed_data)

     

and in function _parse_assets_for_history_listings (same file):

description=item_descrs_map[
                    create_ident_code(
                        a_data["instanceid"],
                        a_data["classid"],
                        a_data["id"], <--- added param asset_id
                        app_id,
                    )

it would really be good to set create ident code with 4 params to make code more unique in all other places where this function is used
Example of bugged link steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20M649201682349301907A45781488869D5246137917394352524
Correct link steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20M652579382071856318A45781488869D5246137917394352524

Steps To Reproduce

Run events, total_count = await self.client.get_my_market_history(start=start, count=count)
Link creating link = description.actions[0].link.replace('%assetid%', str(asset.asset_id))

Environment

Winodws 11 
Python 3.13
aiosteampy 0.7.15

Additional Information

No response

[tima1906]

Also if key generated with 4 params function _parse_my_listings must be changed :

return [
            MyMarketListing(
                id=int(l_data["listingid"]),
                price=l_data["price"],
                lister_steam_id=self.steam_id,
                time_created=datetime.fromtimestamp(l_data["time_created"]),
                item=MarketListingItem(
                    asset_id=int(l_data["asset"]["id"]),
                    unowned_id=int(l_data["asset"]["unowned_id"]) if "unowned_id" in l_data["asset"] else None,
                    owner_id=self.steam_id,
                    market_id=int(l_data["listingid"]),
                    unowned_context_id=int(l_data["asset"]["unowned_contextid"])
                    if "unowned_contextid" in l_data["asset"]
                    else None,
                    amount=int(l_data["asset"]["amount"]),
                    app_context=AppContext((App(int(l_data["asset"]["appid"])), int(l_data["asset"]["contextid"]))),
                    description=item_descrs_map[
                        create_ident_code(
                            l_data["asset"]["instanceid"],
                            l_data["asset"]["classid"],
                            l_data["asset"]["id"], ,   <--- new id param
                            l_data["asset"]["appid"],
                        )
                    ],
                ),
                status=MarketListingStatus(l_data["status"]),
                active=bool(l_data["active"]),
                item_expired=l_data["item_expired"],
                cancel_reason=l_data["cancel_reason"],
                time_finish_hold=l_data["time_finish_hold"],
            )
            for l_data in listings
        ]

[somespecialone]

Can you then check if generated ident code for those items does contain same asset_id?

[tima1906]

Finally i comeback and find mistake.
Our example object is Charm | Lil' Goop with pattern 98215.
In my buy history response i bought 3 times this charm and have invalid link only in one charm so we have

"47057043619": {
          "currency": 0,
          "appid": 730,
          "contextid": "2",
          "id": "47057043619",
          "classid": "7545315231",
          "instanceid": "7557445026",
          "link": "steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20M640198363412623182A%assetid%D2659065017582416913",
},
"46878606644": {
          "currency": 0,
          "appid": 730,
          "contextid": "2",
          "id": "46878606644",
          "classid": "7545315231",
          "instanceid": "7557444535",
        "link": "steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20M649205562646749695A%assetid%D54687402165990137",
},
"46876468550": {
          "currency": 0,
          "appid": 730,
          "contextid": "2",
          "id": "46876468550",
          "classid": "7545315231",
          "instanceid": "7557444535",
         "link": "steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20M641324263317270971A%assetid%D54687402165990137"
}

How you can see second and third have same params classid and instanse id but different inspect links, so function _parse_item_descrs_from_my_listings_or_market_history when code run create_ident_code(mixed_data["instanceid"], mixed_data["classid"], app_id) function will return already created key which not unique because of instance and class id .