Commit 2a62684
authored
fix: updating the maas-api-auth policy to read from the params.env file instead of being hardcoded (opendatahub-io#527)
During testing on the lates RHOAI operator build noticed that the
namespace for our auth policy is still opendatahub.
I updated it so it should be pulling from the `params.env` now. Also
changes the url to try to make it easier to identify this mistake
earlier (fail fast).
How did I test:
Can change the app_namespace in the `params.env` to whatever
`my_totally_correct_namespace` and validate the url looks correct
```
jland@fedora:~/Documents/RedHat/poc/models-as-a-service$
kustomize build deployment/overlays/odh | grep -E "url:|api-keys/validate"
url: https://maas-api.my_totally_correct_namespace.svc.cluster.local:8443/internal/v1/api-keys/validate
```
And I checked the actual prams being installed with the operator and
that looks right.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Updated internal authentication policy configuration to use
overlay-based URL replacement pattern, improving deployment flexibility
across environments.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent 06285b3 commit 2a62684
File tree
2 files changed
+10
-1
lines changed- deployment
- base/maas-api/policies
- overlays/odh
2 files changed
+10
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
128 | 136 | | |
129 | 137 | | |
130 | 138 | | |
| |||
0 commit comments